From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2161CD5BB1 for ; Tue, 26 May 2026 16:46:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1136A10E68E; Tue, 26 May 2026 16:46:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="dm6om/QB"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7FF8610E68E; Tue, 26 May 2026 16:46:26 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 4EB3E41850; Tue, 26 May 2026 16:46:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 803721F000E9; Tue, 26 May 2026 16:46:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779813986; bh=uIyvspHblRrdrbJfHD/CPhWE9oReqSGbA+uFa9zkY4c=; h=From:Subject:Date:To:Cc; b=dm6om/QBISwUQlgnD4LRNgffNUqnA/hxrqGsb8gM0ehHRciELxq9rD/1vhliseCez us4Mb8O/0NV6hoz5ut5vxRUyK+6pamkVskQm6Cpba2orzsp46/6ntpP4KMrXune5Bc +lf5tvBELKqBAtVZq4SbFHomP+bBOjzexY45sChgdco9n9xuc3GJ76QBEZ5OlexmnK mMfjNrqDfVqeZevrcKeq3YpzSC0+J/w8rV0K709P13mMfmyV+lnx8dw1Kn4TjaI1qk M3SwxKN/pb+hs9pxv3dtf9V37y5j8Kt9NaJ99lX5QAuSXg7kPelxKtvuAAo9n/NgHt o+dJKZY1r3oSg== From: Maxime Ripard Subject: [PATCH v6 00/19] drm/atomic: Rework initial state allocation Date: Tue, 26 May 2026 18:46:12 +0200 Message-Id: <20260526-drm-mode-config-init-v6-0-852346394200@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAAAAAAC/33OTW6DMBAF4Ksgr+vK4x8wWfUeVRaxPSZWi2ltg lJF3L2GLJIK0eWb0ftmbiRjCpjJobqRhFPIYYgl1C8VsedT7JAGVzLhjNdMAKMu9bQfHFI7RB8 6GmIYKSB4xU0jlWOkVL8S+nBd2ffjPSf8vhR9vA+JOeWF6PswHqrVDNnSiNeRLqcoUxQkWbrnk Mch/awfTrCW/39mAlo22Ii2sRrB+rcPTBE/X4fUreLEnxS+p/Ci2Fp4ACGxqe1GEQ9FcrmjiKJ oU2vXOsOcNhtFPhQFfEeRRVEtOO+sBePbjaKelXZHUUURWhsmBAcU+o8yz/MvQc/qDQ0CAAA= X-Change-ID: 20260310-drm-mode-config-init-1e1f52b745d0 To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Shuah Khan , Dmitry Baryshkov , Jyri Sarha , Tomi Valkeinen , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Simon Ser , Harry Wentland , Melissa Wen , Sebastian Wick , Alex Hung , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Chen-Yu Tsai , Samuel Holland , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Stone , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Maxime Ripard , Laurent Pinchart , Laurent Pinchart X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=5972; i=mripard@kernel.org; h=from:subject:message-id; bh=R8cMkBgch6OdecOXXUVZ645zaDP9sOBrv+AVIkkeRDM=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDFmi58LyWb6dmnj4gQTXAZGgCXaXra6s09t5+ZFkoNK0L jYvnVPPO6ayMAhzMsiKKbI8kQk7vbx9cZWD/cofMHNYmUCGMHBxCsBE/hkw1pktfeh0R+s76+bb Oozd+/UNpm36UCSpdKPEaEO4i5F79PLN1v8NNQOFdNWf77ivseS0O2PDis5jt4123N957/ssPX5 Zz50Kb1vTUqTsa2c+3v3e411wkbTTPGaRk54e7yY1ugr9C/0AAA== X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, This series started from my work on the hardware state readout[1], and more specifically a discussion with Thomas[2]. This series expands the work that has been merged recently to make drm_private_obj and drm_private_state allocation a bit more consistent and ended up creating a new atomic_create_state callback to allocate a new state with no side effect. The first patches document the existing behaviour and fix a few cleanups and typos. Then, __drm_*_state_reset() helpers are renamed to __drm_*_state_init() to clarify that they initialize rather than reset state, and we add the new atomic_create_state callback to every other DRM object (planes, CRTCs, connectors, colorops). Next, we leverage those new callbacks to create a new helper, drm_mode_config_create_initial_state(), to create the initial state for all the objects of a driver, and update the driver skeleton to recommend it. Finally, we convert the tidss driver and the bridge_connector to the new pattern. This was tested on a TI SK-AM62, with the tidss driver. Let me know what you think, Maxime 1: https://lore.kernel.org/dri-devel/20250902-drm-state-readout-v1-0-14ad5315da3f@kernel.org/ 2: https://lore.kernel.org/dri-devel/5920ffe5-b6b1-484b-b320-332b9eb9db82@suse.de/ Signed-off-by: Maxime Ripard --- Changes in v6: - Reword the docs according to Thomas review - Link to v5: https://lore.kernel.org/r/20260519-drm-mode-config-init-v5-0-388b03321e38@kernel.org Changes in v5: - Address sashiko reviews - Improve the docs - Fix drmm_connector_hdmi_init - Drop drm/tidss: Switch to drm_mode_config_create_initial_state since not all possible bridges would have been converted to create_state - Link to v4: https://lore.kernel.org/r/20260512-drm-mode-config-init-v4-0-591dfdcc1bf9@kernel.org Changes in v4: - Rebased on current drm-misc-next - Update drm_atomic_state to drm_atomic_commit - Various doc impromvements - Don't call drm_crtc_vblank_reset in create_state - Prevent mem leak if states already have a state when drm_mode_config_reset or _create_initial_state are called - Link to v3: https://lore.kernel.org/r/20260424-drm-mode-config-init-v3-0-8b68d9db0d8b@kernel.org Changes in v3: - Reintroduce state documentation that was dropped by accident - Change name to drm_mode_config_create_initial_state() - Don't call drm_mode_config_create_initial_state() in drm_dev_register anymore - Drop __drm_atomic_helper_*_create_state - Improve documentation and commit messages where necessary - Collected tags - Link to v2: https://lore.kernel.org/r/20260320-drm-mode-config-init-v2-0-c63f1134e76c@kernel.org Changes in v2: - Change the _state_reset function names to _state_init - Change the colorop too - Various doc improvements - Link to v1: https://lore.kernel.org/r/20260310-drm-mode-config-init-v1-0-de7397c8e1cf@kernel.org --- Maxime Ripard (19): drm/atomic: Document atomic commit lifetime drm/colorop: Fix typos in the doc drm/atomic: Drop drm_private_obj.state assignment from create_state drm/atomic: Expand atomic_create_state expectations for drm_private_obj drm/mode-config: Document drm_private_obj exclusion from drm_mode_config_reset() drm/colorop: Rename __drm_colorop_state_reset() drm/colorop: Create drm_atomic_helper_colorop_create_state() drm/atomic-state-helper: Fix __drm_atomic_helper_plane_reset() doc typo drm/atomic-state-helper: Rename __drm_atomic_helper_plane_state_reset() drm/plane: Add new atomic_create_state callback drm/atomic-state-helper: Rename __drm_atomic_helper_crtc_state_reset() drm/crtc: Add new atomic_create_state callback drm/atomic-state-helper: Rename __drm_atomic_helper_connector_state_reset() drm/hdmi: Rename __drm_atomic_helper_connector_hdmi_reset() drm/connector: Add new atomic_create_state callback drm/mode-config: Create drm_mode_config_create_initial_state() drm/drv: Switch skeleton to drm_mode_config_create_initial_state() drm/tidss: Convert to atomic_create_state drm/bridge_connector: Convert to atomic_create_state Documentation/gpu/drm-kms.rst | 6 + drivers/gpu/drm/display/drm_bridge_connector.c | 17 +- drivers/gpu/drm/display/drm_hdmi_state_helper.c | 15 +- drivers/gpu/drm/drm_atomic.c | 80 +++++++++ drivers/gpu/drm/drm_atomic_state_helper.c | 114 ++++++++++--- drivers/gpu/drm/drm_colorop.c | 41 ++++- drivers/gpu/drm/drm_connector.c | 10 +- drivers/gpu/drm/drm_drv.c | 4 +- drivers/gpu/drm/drm_mode_config.c | 189 ++++++++++++++++++++- drivers/gpu/drm/i915/display/intel_crtc.c | 2 +- drivers/gpu/drm/i915/display/intel_plane.c | 2 +- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 2 +- drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 2 +- drivers/gpu/drm/tidss/tidss_crtc.c | 17 +- drivers/gpu/drm/tidss/tidss_plane.c | 2 +- drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +- include/drm/display/drm_hdmi_state_helper.h | 4 +- include/drm/drm_atomic.h | 5 +- include/drm/drm_atomic_state_helper.h | 12 +- include/drm/drm_colorop.h | 2 + include/drm/drm_connector.h | 16 ++ include/drm/drm_crtc.h | 16 ++ include/drm/drm_mode_config.h | 1 + include/drm/drm_plane.h | 16 ++ 24 files changed, 509 insertions(+), 68 deletions(-) --- base-commit: 69c95e4c529297c25503e60acba757fba24fdc95 change-id: 20260310-drm-mode-config-init-1e1f52b745d0 Best regards, -- Maxime Ripard