From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B915CD6E40 for ; Tue, 26 May 2026 14:30:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 691A710E6AB; Tue, 26 May 2026 14:30:36 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="klmHdAEw"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2170A10E695; Tue, 26 May 2026 14:30:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cSnwpH826zG+aCRPJzfw8hJJ/S+BJpSQ5BQzAsOm7wU=; b=klmHdAEwHjR6ulnkyMVa4AUqiN otpBub8LejGHtmC0Jkw6/4JEtK6385OchOoPDcubZtsEWN5OuJHT9ls4keURhZS+AjMk9PRvVAycl wv/l27PbNSbe2hTaDcish1A7jcHKT1mvtlnl8ifmjFpqPAnbG8mgQhVD2wUvAS1FQHspKv4IISEVL RzhEHUqnybE7jcbvtudAFkIbHbRJ1M6KZX++oPIMQFCGvE6RK5nGe6LovamjnO8pOw18oLYaImIdj iRbIl7JXHLPSN3zyEk5OQJwcq8HuJNIBsid/BdSbAwzwr2TnNCMiPSqP28kh0RuYZmpX2qjQIne3c 7FczzxjQ==; Received: from [79.117.146.159] (helo=killbill.home) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1wRsn0-008TUc-4Y; Tue, 26 May 2026 16:29:50 +0200 From: Melissa Wen To: airlied@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, simona@ffwll.ch, tzimmermann@suse.de Cc: Alex Hung , Simon Ser , Uma Shankar , Chaitanya Kumar Borah , Xaver Hugl , Pekka Paalanen , Louis Chauvet , Matthew Schwartz , John Harrison , Rodrigo Siqueira , amd-gfx@lists.freedesktop.org, kernel-dev@igalia.com, Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH 0/3] don't allow changes to inactive colorops Date: Tue, 26 May 2026 16:17:07 +0200 Message-ID: <20260526142940.504911-1-mwen@igalia.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This series is a follow-up of what was discussed in [1] and on #wayland IRC channel regarding policy and userspace expectations on changes in colorop properties and the current status of the color pipeline in which the colorop is part of. In short, we agreed that userspace can change properties of colorops that are currently part of an active color pipeline or when the pipeline is switching status in the same commit. However, userspace cannot change colorop properties of inactive color pipeline in the expactation that it will be activated at some point in the future. Userspace also expects persistence of color pipeline already set, even if it becomes inactive for a while, when activated, colorop settings previouly set should be preserved. In addition, I found some bugs on IGT tests when this policy is applied. So I sent some bug fixes [2]. The rest of the series in [1] was detached in [3] since there is no dependecy between them. [1] https://lore.kernel.org/dri-devel/20260519211111.228303-1-mwen@igalia.com/ [2] https://lore.kernel.org/dri-devel/20260525100524.304263-1-mwen@igalia.com/ [3] https://lore.kernel.org/igt-dev/20260526140752.503380-1-mwen@igalia.com/ Melissa Wen (3): drm/atomic: only add states of active or transient active colorops drm/atomic: duplicate state of all colorops drm/atomic: reject colorop update from inactive color pipeline drivers/gpu/drm/drm_atomic.c | 126 ++++++++++++++++++++++++++-- drivers/gpu/drm/drm_atomic_helper.c | 9 +- 2 files changed, 120 insertions(+), 15 deletions(-) -- 2.53.0