public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Leandro Ribeiro <leandro.ribeiro@collabora.com>
To: dri-devel@lists.freedesktop.org
Cc: airlied@gmail.com, daniels@collabora.com,
	jani.nikula@linux.intel.com, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org, pekka.paalanen@collabora.com,
	simona@ffwll.ch, tzimmermann@suse.de,
	ville.syrjala@linux.intel.com, linux-kernel@vger.kernel.org
Subject: [PATCH v4 0/2] drm/drm_blend: allow blend mode property without PREMULTI
Date: Tue, 26 May 2026 15:16:58 -0300	[thread overview]
Message-ID: <20260526181700.25310-1-leandro.ribeiro@collabora.com> (raw)

Some hardware only supports the COVERAGE blend mode and lacks PREMULTI
support entirely. DRM currently requires that PREMULTI is present when
creating a blend mode property, which prevents such drivers from being
properly upstreamed.

This series removes this restriction and allows drivers to create a blend
mode property without PREMULTI.

On Weston (userspace), we are working [1] towards adding support for
this kind of hardware.

[1] https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/2046

v4:
- Trigger warnings instead of errors when pixel format with alpha is
  exposed but blend mode is not setup.
- Require blend mode only when plane exposes pixel formats with alpha, not
  when it supports the alpha property.

v3:
- Changed where we enforce drivers to expose blend mode for planes that
  support the alpha property or pixel formats with alpha.
- Fixed missing check to forbid calling
  drm_plane_create_blend_mode_property() with a zero bitmask of
  supported modes.

v2:
- Force drivers to expose blend mode if plane supports alpha property
  or pixel format with alpha.

Leandro Ribeiro (2):
  drm/drm_blend: allow blend mode property without PREMULTI
  drm: ensure blend mode supported if pixel format with alpha exposed

 drivers/gpu/drm/drm_blend.c       | 20 ++++++++++++++------
 drivers/gpu/drm/drm_mode_config.c | 21 +++++++++++++++++++++
 2 files changed, 35 insertions(+), 6 deletions(-)

-- 
2.54.0


             reply	other threads:[~2026-05-26 18:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26 18:16 Leandro Ribeiro [this message]
2026-05-26 18:16 ` [PATCH v4 1/2] drm/drm_blend: allow blend mode property without PREMULTI Leandro Ribeiro
2026-05-27  4:23   ` Claude review: " Claude Code Review Bot
2026-05-26 18:17 ` [PATCH v4 2/2] drm: ensure blend mode supported if pixel format with alpha exposed Leandro Ribeiro
2026-05-27  4:23   ` Claude review: " Claude Code Review Bot
2026-05-27  4:22 ` Claude review: drm/drm_blend: allow blend mode property without PREMULTI Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260526181700.25310-1-leandro.ribeiro@collabora.com \
    --to=leandro.ribeiro@collabora.com \
    --cc=airlied@gmail.com \
    --cc=daniels@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=pekka.paalanen@collabora.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox