From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CC93CD5BD1 for ; Tue, 2 Jun 2026 22:48:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7174E10F654; Tue, 2 Jun 2026 22:48:50 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="d7ZcWRft"; dkim-atps=neutral Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id D1B8910F663 for ; Tue, 2 Jun 2026 22:48:48 +0000 (UTC) Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-45efa80e0afso2901730f8f.2 for ; Tue, 02 Jun 2026 15:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780440527; x=1781045327; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Yhq+U5OSRDicP85+S9FaWBdLNaFdwOPlYIYghUJlarA=; b=d7ZcWRftgieCE+eA1vnQpfOS5sUmWWeJJxauvoeueH9dgjf5FVtlmfh/mYFa3OlLYR 5NdmoX71G/JBBavriS9r9GrMh0NjkHBT/FaBC4MXL3Ec+DIrbJTCcGzMAQu16MhVodpL YXqnS6uTkTkDxX0C8eSZswA/HUtwPUhDYFxPBrvFddTpz6AtF5TCji2CxmeC4Do6WdUD 3JRgTk3xfp4KSBJERX37C6/DczPgQy5IRp7eNzLibacL5A4+E40qBRs44v0K6HZTikTP 87ZivLqIGAvmsp3ADeHgq8/VKHaF+Jm7VQt13TQaKn2WKfDgZOmuoD+Ej6uDqMLm8RFe eTvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780440527; x=1781045327; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Yhq+U5OSRDicP85+S9FaWBdLNaFdwOPlYIYghUJlarA=; b=alcjMubNOdUYM6aO/uak2Py7rkV706zuWrbuVbWKYo3AF5a40GUTXXC84/4v1av6Ig ZBKIbW3jIWF3uq02IWXYLVr1rC7deuwsreWWnwT9cGaS2EBBNFsPduk6TvwamMbnSoRD GpqerlT9/dpWpw7miRtHDgmB2x+d86hZqMlG51u+sqY9nnAkfuArDJsFxunmPS5B6acH rSUOovSf04QLKPacg1t77Cv8FzoaqktH0N7/J7Kr2/B7Nbsu4uxkakDWUhvUcIaAWmXD MwdMS2GLviAovs4ckXZYiN9ptFcbf+4Jg+9Z+gBD9Z7NTchr26jQ6aCRxIgsmGklStFR jTmA== X-Forwarded-Encrypted: i=1; AFNElJ+5WysGf4E1+fx9bVmUk13+XU0F7ypGskS4vVXwUfeUeb+pBOiGayFkatu28/ho2yz0dRSyjxduwps=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzWoajovDfUteYeNyAcQmyg5vnXj+89zchoHr0RN9g1epyBSU6f X97gsh3O2lu5hpiSqkKfq7PG7UegK73kneQDJzVBhUBnwdjWiDz2FEre X-Gm-Gg: Acq92OHoO0E0Td9C5VbViEt/959xEAYS3HHmKZwJi9zLsq1AQYgZYQm8V3TTd6pqzva /H8TxotnJ5+Hmf+VNlNTRqy1LmQam6CKxohH74qMZt3H46vpA45CtUFF5sSenP8zsM334mifEoH R8DE0CAPzXieQ27NQmXtzbjOSVEJD6rsaa62clGN3YHN5Hx72k/wv3uXqaSOjNrrBpQ9Soro8T3 Mwwjmuwg5kpJopmyGR3a5ojv4vN+q5lYi5wn88Kuz2I+3i1q1SaoQZVrdgFVwsQCmPqmh+aaxe4 IrMJvRWRzONV0LKWLT0qU7OgQM6rzBcxTfv+2fxia4xcMrxMe2CX9PZcpq49JrLQ1uGToW/AjcT /aUQuTmIqIvOd7ndR+43DH1ysmmiN2O9B7EAfgTLZ9RTHmeSusYmG7wGoaSEUw0VdLexUAdki9c owmyUp5Zny3XQwxEYMcAlCdcml95MUR80ZI2jsZv+OoS+DwXf9+Qx7 X-Received: by 2002:a05:6000:1cc8:b0:45e:ed7f:1d9 with SMTP id ffacd0b85a97d-460216e6c10mr535924f8f.17.1780440527095; Tue, 02 Jun 2026 15:48:47 -0700 (PDT) Received: from [172.16.188.153] ([213.181.114.83]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-4601f2f2710sm1999791f8f.14.2026.06.02.15.48.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 15:48:46 -0700 (PDT) From: Jim Cromie Date: Tue, 02 Jun 2026 22:48:10 +0000 Subject: [PATCH v4 13/25] dyndbg: reduce verbose/debug clutter MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260602-dd-maint-2-v4-13-19a1445585a8@gmail.com> References: <20260602-dd-maint-2-v4-0-19a1445585a8@gmail.com> In-Reply-To: <20260602-dd-maint-2-v4-0-19a1445585a8@gmail.com> To: Jonathan Corbet , Shuah Khan , Arnd Bergmann , Jason Baron , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Andrew Morton , Shuah Khan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, linux-kselftest@vger.kernel.org, dri-devel@lists.freedesktop.org, Jim Cromie , Louis Chauvet X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780440488; l=5056; i=jim.cromie@gmail.com; s=20260203; h=from:subject:message-id; bh=weM4kXK4ZroqgxDMQCEUnSrZj0zxepbFA1mJkvW7x2I=; b=60JsmO3vGkvHB8Wbkptgdh59idXBHU6megWsjkTqaulbU6qXBQ5J81a4YTYlMRoJy6Y/7nNeR EmZCu3IAwOSDqEqibblfA4hs2wXiRSlGkqwoD/KbxNqiLScteYh5W8g X-Developer-Key: i=jim.cromie@gmail.com; a=ed25519; pk=C6E5ODlPQo7ZBynATXH9wg7K6HxP0pIXyf4s38Qw0XE= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" currently, for verbose=3, these are logged (blank lines for clarity): dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op='+' dyndbg: flags=0x1 dyndbg: *flagsp=0x1 *maskp=0xffffffff dyndbg: parsed: func="" file="" module="" format="" lineno=0-0 class=... dyndbg: no matches for query dyndbg: no-match: func="" file="" module="" format="" lineno=0-0 class=... dyndbg: processed 1 queries, with 0 matches, 0 errs That is excessive, so this patch: - shrinks 3 lines of 2nd stanza to single line - drops 1st 2 lines of 3rd stanza 3rd line is like 1st, with result, not procedure. 2nd line is just status, retold in 4th, with more info. New output: dyndbg: query 0: "class DRM_UT_CORE +p" dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op='+' flags=0x1 maskp=0xffffffff dyndbg: processed 1 queries, with 0 matches, 0 errs Also drop several verbose=3 messages in ddebug_add_module When modprobing a module, dyndbg currently logs/says "add-module", and then "skipping" if the module has no prdbgs. Instead just check 1st and return quietly. no functional change Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet --- v4: rename vpr_dq_info to v3pr_dq_info to tell its active logging level adjust some vX levels per doc'd intentions v2: RvB after SoB trivial change to verbose-debug output line to output the actual "module" keyword rather than "mod:", and do so only when the module is constrained by the callchain (ie as part of a modprobe). was: query X: "(keyword value)* [+-=]flags" mod:* now: query X: "(keyword value)* [+-=]flags" or query X: module FOO "keyword value)* [+-=]flags" IOW, adjust output to reflect the input grammar more closely. drop-info-parsed vinfo-applied-nomatch dyndbg: tweak verbose-levels per doc --- lib/dynamic_debug.c | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 0377d9f8dcd1..a967e3ef1dbc 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -128,7 +128,7 @@ do { \ #define v3pr_info(fmt, ...) vnpr_info(3, fmt, ##__VA_ARGS__) #define v4pr_info(fmt, ...) vnpr_info(4, fmt, ##__VA_ARGS__) -static void vpr_info_dq(const struct ddebug_query *query, const char *msg) +static void v3pr_info_dq(const struct ddebug_query *query, const char *msg) { /* trim any trailing newlines */ int fmtlen = 0; @@ -276,9 +276,6 @@ static int ddebug_change(const struct ddebug_query *query, } mutex_unlock(&ddebug_lock); - if (!nfound && verbose) - pr_info("no matches for query\n"); - return nfound; } @@ -487,7 +484,6 @@ static int ddebug_parse_query(char *words[], int nwords, */ query->module = modname; - vpr_info_dq(query, "parsed"); return 0; } @@ -511,7 +507,6 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers) pr_err("bad flag-op %c, at start of %s\n", *str, str); return -EINVAL; } - v3pr_info("op='%c'\n", op); for (; *str ; ++str) { for (i = ARRAY_SIZE(opt_array) - 1; i >= 0; i--) { @@ -525,7 +520,6 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers) return -EINVAL; } } - v3pr_info("flags=0x%x\n", modifiers->flags); /* calculate final flags, mask based upon op */ switch (op) { @@ -541,7 +535,7 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers) modifiers->flags = 0; break; } - v3pr_info("*flagsp=0x%x *maskp=0x%x\n", modifiers->flags, modifiers->mask); + v3pr_info("op='%c' flags=0x%x maskp=0x%x\n", op, modifiers->flags, modifiers->mask); return 0; } @@ -570,7 +564,7 @@ static int ddebug_exec_query(char *query_string, const char *modname) } /* actually go and implement the change */ nfound = ddebug_change(&query, &modifiers); - vpr_info_dq(&query, nfound ? "applied" : "no-match"); + v3pr_info_dq(&query, nfound ? "applied" : "no-match"); return nfound; } @@ -593,7 +587,10 @@ static int ddebug_exec_queries(char *query, const char *modname) if (!query || !*query || *query == '#') continue; - vpr_info("query %d: \"%s\" mod:%s\n", i, query, modname ?: "*"); + if (modname) + v2pr_info("query %d: module %s \"%s\"\n", i, modname, query); + else + v2pr_info("query %d: \"%s\"\n", i, query); rc = ddebug_exec_query(query, modname); if (rc < 0) { @@ -1159,11 +1156,10 @@ static int ddebug_add_module(struct _ddebug_info *di, const char *modname) { struct ddebug_table *dt; - v3pr_info("add-module: %s.%d sites\n", modname, di->num_descs); - if (!di->num_descs) { - v3pr_info(" skip %s\n", modname); + if (!di->num_descs) return 0; - } + + v3pr_info("add-module: %s %d sites\n", modname, di->num_descs); dt = kzalloc_obj(*dt); if (dt == NULL) { -- 2.54.0