From: Alexey Charkov <alchark@flipper.net>
To: Sandy Huang <hjc@rock-chips.com>, Heiko Stübner <heiko@sntech.de>,
Andy Yan <andy.yan@rock-chips.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Alexey Charkov <alchark@flipper.net>
Subject: [PATCH 1/2] drm/rockchip: vop2: honor TV margins from CRTC state for overscan compensation
Date: Tue, 02 Jun 2026 21:00:39 +0400 [thread overview]
Message-ID: <20260602-hdmi-overscan-v1-1-31f71b817c80@flipper.net> (raw)
In-Reply-To: <20260602-hdmi-overscan-v1-0-31f71b817c80@flipper.net>
Replace the hard-coded percent values with pixel margins carried in struct
rockchip_crtc_state, sourced from the standard DRM "left/right/top/bottom
margin" connector properties (struct drm_connector_tv_margins) to pave way
for HDMI overscan compensation support.
Signed-off-by: Alexey Charkov <alchark@flipper.net>
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 2 ++
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 17 +++++++++++------
2 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.h b/drivers/gpu/drm/rockchip/rockchip_drm_drv.h
index 2e86ad00979c..83f8ec4f3319 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.h
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.h
@@ -10,6 +10,7 @@
#define _ROCKCHIP_DRM_DRV_H
#include <drm/drm_atomic_helper.h>
+#include <drm/drm_connector.h>
#include <drm/drm_gem.h>
#include <linux/bits.h>
@@ -53,6 +54,7 @@ struct rockchip_crtc_state {
u32 bus_format;
u32 bus_flags;
int color_space;
+ struct drm_connector_tv_margins tv_margins;
};
#define to_rockchip_crtc_state(s) \
container_of(s, struct rockchip_crtc_state, base)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
index a160077a507f..55307b8493ae 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
@@ -1558,30 +1558,35 @@ static void vop2_post_config(struct drm_crtc *crtc)
{
struct vop2_video_port *vp = to_vop2_video_port(crtc);
struct vop2 *vop2 = vp->vop2;
+ struct rockchip_crtc_state *vcstate = to_rockchip_crtc_state(crtc->state);
struct drm_display_mode *mode = &crtc->state->adjusted_mode;
+ const struct drm_connector_tv_margins *m = &vcstate->tv_margins;
u64 bgcolor = crtc->state->background_color;
u16 vtotal = mode->crtc_vtotal;
u16 hdisplay = mode->crtc_hdisplay;
u16 hact_st = mode->crtc_htotal - mode->crtc_hsync_start;
u16 vdisplay = mode->crtc_vdisplay;
u16 vact_st = mode->crtc_vtotal - mode->crtc_vsync_start;
- u32 left_margin = 100, right_margin = 100;
- u32 top_margin = 100, bottom_margin = 100;
- u16 hsize = hdisplay * (left_margin + right_margin) / 200;
- u16 vsize = vdisplay * (top_margin + bottom_margin) / 200;
+ u16 hsize = hdisplay;
+ u16 vsize = vdisplay;
u16 hact_end, vact_end;
u32 val;
vop2->ops->setup_bg_dly(vp);
+ if (m->left + m->right < hdisplay)
+ hsize = hdisplay - m->left - m->right;
+ if (m->top + m->bottom < vdisplay)
+ vsize = vdisplay - m->top - m->bottom;
+
vsize = rounddown(vsize, 2);
hsize = rounddown(hsize, 2);
- hact_st += hdisplay * (100 - left_margin) / 200;
+ hact_st += m->left;
hact_end = hact_st + hsize;
val = hact_st << 16;
val |= hact_end;
vop2_vp_write(vp, RK3568_VP_POST_DSP_HACT_INFO, val);
- vact_st += vdisplay * (100 - top_margin) / 200;
+ vact_st += m->top;
vact_end = vact_st + vsize;
val = vact_st << 16;
val |= vact_end;
--
2.52.0
next prev parent reply other threads:[~2026-06-02 22:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 17:00 [PATCH 0/2] drm/rockchip: dw_hdmi_qp: Add support for HDMI overscan compensation Alexey Charkov
2026-06-02 17:00 ` Alexey Charkov [this message]
2026-06-04 2:35 ` Claude review: drm/rockchip: vop2: honor TV margins from CRTC state for " Claude Code Review Bot
2026-06-02 17:00 ` [PATCH 2/2] drm/rockchip: dw_hdmi_qp: expose "overscan" property Alexey Charkov
2026-06-03 7:55 ` Maxime Ripard
2026-06-03 8:15 ` Alexey Charkov
2026-06-03 13:11 ` Andy Yan
2026-06-04 2:35 ` Claude review: " Claude Code Review Bot
2026-06-04 2:35 ` Claude review: drm/rockchip: dw_hdmi_qp: Add support for HDMI overscan compensation Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260602-hdmi-overscan-v1-1-31f71b817c80@flipper.net \
--to=alchark@flipper.net \
--cc=airlied@gmail.com \
--cc=andy.yan@rock-chips.com \
--cc=cristian.ciocaltea@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox