From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70AA1CD8C80 for ; Thu, 4 Jun 2026 18:05:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FA8C11291F; Thu, 4 Jun 2026 18:05:52 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="lcdo8Ktb"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by gabe.freedesktop.org (Postfix) with ESMTPS id 78A70112915; Thu, 4 Jun 2026 18:05:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=iW7MmJbWSEeEFgiTLXEtF0Skl9HYrWG5uWuRvtFvnhI=; b=lcdo8Ktbbz4OO7C+uOEXZNXuia nR3hK7t3nD9fbi6T++naZ415nxApdRi/HF1o1eWr0WqRbyYlM54judA8TiRvQq1T8V4cLBowb1Ogm YOOKuZ1McmNE1p/dvqBYm5wbBmVWeJuHAr3RnsWEWg1v7TCCatFIt71udo7VjemXGiqxzO4r9IPC8 mrb4Hpzm8aqtgpMlXXclKVAFsHksHlfdYuF6HiNe62210pic4Mo1T+Nb3dLPnAfToIIdbJhczjXLo A7HanBn2OCSYqAqBV77YU9UPku2iRttLpDsL4bOKe5fLXszkc7GlyRxiCn6XYbWT6pFges3+xo4OB 9X95t/Zg==; Received: from [79.117.146.159] (helo=killbill.home) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1wVCRG-00Ckqs-0Y; Thu, 04 Jun 2026 20:05:06 +0200 From: Melissa Wen To: airlied@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, simona@ffwll.ch, tzimmermann@suse.de Cc: Alex Hung , Simon Ser , Uma Shankar , Chaitanya Kumar Borah , Xaver Hugl , Pekka Paalanen , Louis Chauvet , Matthew Schwartz , Sebastian Wick , John Harrison , Rodrigo Siqueira , amd-gfx@lists.freedesktop.org, kernel-dev@igalia.com, Rob Clark , Dmitry Baryshkov , Sean Paul , Marijn Suijten , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH v2 0/3] don't allow changes to inactive colorops Date: Thu, 4 Jun 2026 19:59:04 +0200 Message-ID: <20260604180457.1110110-1-mwen@igalia.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This series is a follow-up of what was discussed in [1] and on #wayland IRC channel regarding policy and userspace expectations on changes in colorop properties and the current status of the color pipeline in which the colorop is part of. In short, we agreed that userspace can change properties of colorops that are currently part of an active color pipeline or when the pipeline is switching status in the same commit. However, userspace cannot change colorop properties of inactive color pipeline in the expactation that it will be activated at some point in the future. Userspace also expects persistence of color pipeline already set, even if it becomes inactive for a while, when activated, colorop settings previouly set should be preserved. In addition, I found some bugs on IGT tests when this policy is applied. So I sent bug fixes to kms_colorop and kms_properties to behave according to this contract [2]. The rest of the series in [1] was detached in [3] since there is no dependecy between them. [1] https://lore.kernel.org/dri-devel/20260519211111.228303-1-mwen@igalia.com/ [2] https://lore.kernel.org/igt-dev/20260602211259.898147-1-mwen@igalia.com [3] https://lore.kernel.org/igt-dev/20260526140752.503380-1-mwen@igalia.com/ [v1] https://lore.kernel.org/dri-devel/20260526142940.504911-1-mwen@igalia.com/ Changes: - define a macro to walk in the color pipeline (Alex H.) - fix checkpatch warning (Alex H.) Melissa Melissa Wen (3): drm/atomic: only add states of active or transient active colorops drm/atomic: duplicate state of all colorops drm/atomic: reject colorop update from inactive color pipeline drivers/gpu/drm/drm_atomic.c | 125 ++++++++++++++++++++++++++-- drivers/gpu/drm/drm_atomic_helper.c | 9 +- include/drm/drm_colorop.h | 3 + 3 files changed, 122 insertions(+), 15 deletions(-) -- 2.53.0