public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: David Heidelberg <david@ixit.cz>
To: Yedaya Katsman <yedaya.ka@gmail.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Kamil Gołda <kamil.golda@protonmail.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: phone-devel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 2/3] drm: panel: Add Samsung S6E8FCO DSI controller for M1906F9 panel
Date: Thu, 12 Mar 2026 13:10:55 +0100	[thread overview]
Message-ID: <29621ceb-b95f-4123-8237-e1465c02c8df@ixit.cz> (raw)
In-Reply-To: <20260312-panel-patches-v3-2-6ed8c006d0be@gmail.com>

On 12/03/2026 12:55, Yedaya Katsman wrote:
> Add driver for Samsung S6E8FCO DSI controller for M1906F9 video mode panel,
> found in Xiaomi Mi A3 mobile phone.
> 
> Co-developed-by: Kamil Gołda <kamil.golda@protonmail.com>
> Signed-off-by: Kamil Gołda <kamil.golda@protonmail.com>
> Signed-off-by: Yedaya Katsman <yedaya.ka@gmail.com>
> ---
>   MAINTAINERS                                        |   1 +
>   drivers/gpu/drm/panel/Kconfig                      |  13 +
>   drivers/gpu/drm/panel/Makefile                     |   1 +
>   .../gpu/drm/panel/panel-samsung-s6e8fco-m1906f9.c  | 302 +++++++++++++++++++++
>   4 files changed, 317 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d7aee8dab903cd42c245fea3cf8971dcd99b2196..d00775a09445a8a1bd626ecfd27903471d08d33a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8187,6 +8187,7 @@ DRM DRIVER FOR SAMSUNG S6E8FCO PANELS
>   M:	Yedaya Katsman <yedaya.ka@gmail.com>
>   S:	Maintained
>   F:	Documentation/devicetree/bindings/display/panel/samsung,s6e8fco-m1906f9.yaml
> +F:	drivers/gpu/drm/panel/panel-samsung-s6e8fco-m1906f9.c
>   
>   DRM DRIVER FOR SAMSUNG SOFEF00 DDIC
>   M:	David Heidelberg <david@ixit.cz>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 7a83804fedca1b688ce6fbe4295ec9009007e693..ee9cc6939f2ac1dc4542563fd73f68ac5f9ee371 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -893,6 +893,19 @@ config DRM_PANEL_SAMSUNG_S6E8AA5X01_AMS561RA01
>   	  ~5.6 inch AMOLED display, and the controller is driven by the MIPI
>   	  DSI protocol with 4 lanes.
>   
> +config DRM_PANEL_SAMSUNG_S6E8FCO_M1906F9
> +	tristate "Samsung M1906F9 panel with S6E8FCO DSI controller"
> +	depends on OF
> +	depends on BACKLIGHT_CLASS_DEVICE
> +	select DRM_MIPI_DSI
> +	select VIDEOMODE_HELPERS

one more small nit - please double check you need VIDEOMODE_HELPERS

David

[...]
-- 
David Heidelberg


  parent reply	other threads:[~2026-03-12 12:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12 11:55 [PATCH v3 0/3] Add support for the Samsung S6E8FCO DSI and M1906F9 display panel Yedaya Katsman
2026-03-12 11:55 ` [PATCH v3 1/3] dt-bindings: display: panel: Add Samsung S6E8FCO-M1906F9 Yedaya Katsman
2026-03-13  4:15   ` Claude review: " Claude Code Review Bot
2026-03-12 11:55 ` [PATCH v3 2/3] drm: panel: Add Samsung S6E8FCO DSI controller for M1906F9 panel Yedaya Katsman
2026-03-12 12:09   ` David Heidelberg
2026-03-13  4:15     ` Claude review: " Claude Code Review Bot
2026-03-12 12:10   ` David Heidelberg [this message]
2026-03-12 11:55 ` [PATCH v3 3/3] arm64: dts: qcom: sm6125-xiaomi-laurel-sprout: Enable MDSS and add panel Yedaya Katsman
2026-03-12 13:31   ` Dmitry Baryshkov
2026-03-13  4:15     ` Claude review: " Claude Code Review Bot
2026-03-13  4:15 ` Claude review: Add support for the Samsung S6E8FCO DSI and M1906F9 display panel Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29621ceb-b95f-4123-8237-e1465c02c8df@ixit.cz \
    --to=david@ixit.cz \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=kamil.golda@protonmail.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=yedaya.ka@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox