From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87FBEFD2D84 for ; Tue, 10 Mar 2026 13:33:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E7CC810E6AA; Tue, 10 Mar 2026 13:33:57 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="fLk14I5W"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EB8koMsR"; dkim-atps=neutral Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 460A210E6AA for ; Tue, 10 Mar 2026 13:33:56 +0000 (UTC) Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62ACaUvc3759233 for ; Tue, 10 Mar 2026 13:33:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=DfYI+6/c4jccnkJp/ZUObodv ikdpc4ospvMOIs2KDfk=; b=fLk14I5WdfwOiHMMZiPNPQ4vf9T+FksJtzYMRJJY YvB7QEwbxYHan/7ms8GAwjsWP/BVwc9mP6OQS2dw629bt6iL25SMq9QP0DK94zYy 5O7DJ6E//zPlVB2OpBxgEoKFt9lh5A+QfXRAQtUkCRWCAbO9YwNc0qHoi1DgX0d1 6riAPENs3U2QGOM4DN83TE81L+GnmbYLWdIyIrn9R279Tohk0IWNDAGaKA7gMJV1 aoEdRUCbfnVvgko4ae1CTK2pZbzmK4Mnj+P93CbOz/URpie2UUo/qOzGW4XAMVob Qa35VUrO9h4s4pmwx07BvknB/DQucay/OgLhQnT1LE+FYQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctk8ug7wm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 13:33:55 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-5092efe29dcso25335201cf.3 for ; Tue, 10 Mar 2026 06:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773149635; x=1773754435; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DfYI+6/c4jccnkJp/ZUObodvikdpc4ospvMOIs2KDfk=; b=EB8koMsRf2EGw999edm7e7yyVl/5yjw+3ImbJk2TdhHPlbOaa90IkESqN4Hv3Rhr8a eNLOhnAQYCnyG0HsKVA3SOGkzG3zqM4d98kbc3qckzl1K6VYYzl+Zb6XN429zFiBqzpT 3WZCYmoyl0SaosyBa6CxS4rbkoC0vJMaYE/iEf/1+b/PBGUSp68x17koM0LdiDdACPUT +65Bx9GJBZXVrfv8U47ZFDH75zSoCQr6ZZdDwjB6xcuA/a7sdzT1M5g0WKYOpZvGSvo2 JniiJncFSn1XB+mEdmdjVCsC7erknLTs7ca2PRfENdlQA64mAXOVpn/URRWke2f5YR+y lSpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773149635; x=1773754435; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DfYI+6/c4jccnkJp/ZUObodvikdpc4ospvMOIs2KDfk=; b=nsTimhnAj+VokCS5Q9Z89VBnXIWZSTCA6dWsyOs6jial+FrTGw8pht5MweLfJmNFDY rL/IfjG7zNIhcKFX5tJe084DOeaKNQ7Gsu0gWXrXXJKVMhQfMh9x+tQfUuOwygx+t8YB V5t76PFE7xq4LKGSD1pLbS3cImlf8c60HpW2HR0DjcZbVeSp6Ny22m5a0HCToZyXHSQt fG2XShMep0D/MDeuh3E2dKupt0Ib4ah+S1bmP2kU14Y4Ur+kPZDxOOd/P0WeYVO34PJx 6JS7OGbR+aJXnQRbq5/GFZaVd/Nax8KzkcbtYqO4/6/vGJBNaBEMDB5pWbMxoAXwT8xT 0Bvw== X-Forwarded-Encrypted: i=1; AJvYcCU5Z/pCxURq3bg00Qxqd5sMGROTyeX5MJPrLOkTrNIUuYtYoaBSGFPfoibQsDp9CBTUOX1HopWFmow=@lists.freedesktop.org X-Gm-Message-State: AOJu0YyAKn0m2qhQuT5JMpLj8D2uADoy0p8l1aZgLrReboOfGuwGltGb oqyTYil4WwZLOSR38iI63ctY1xEu2XW/vAvahLNVm1pnxDla6NrcOFAdBLtWkwnLk4eOf7wTY71 KRhH9JJDRWKbghz0a5GWdbd115MTbSHdGPnxH9NIyqs/sIOM2UGOFOOUdy017GMmP2675pOU= X-Gm-Gg: ATEYQzxvpuAegJKPgUn1J9nhtjZyZu4JgT9MIr2Yc82JKwCxRWBMg5/8qWWICH+3eda LuOwSmfueeOYcWHdxU6gP1S2kUHVi176tPtOCTFi9ZtWpIJX77jLNGGkqkHOjx8TzLAEiXkKW34 w39PU93RcCIBaRAJNpaPhTvch9H0QbKfUuGXe4Sio2SbUxFhaFnuzJoNKQxi79KqXB00g06o7Zq aida62qknJlQOZAckN6gn11DK8sqWsGsoNjrQ+wSbMCVI+8udT+fSQimyxKj682DTgwGNz5ccV2 H9jfGOP0elKX9sLxvRs/CxYn/MHy5YUoQ2xP8XaBwMqQaJgo2fFp1E/2J7kl+hKoN+N/iD7XABG qNA4P3CgOn/nlLVi8l0Y5knRlLDAe4yvhL/3yr859BcOmKHBuzMRfl4ubLkW4u0LF+2SygcbN45 ROpTBbkn4ZCerPjE8FG3CwoT2vFykQtxbzjF8= X-Received: by 2002:a05:620a:31aa:b0:8cd:8f04:50f5 with SMTP id af79cd13be357-8cd8f045625mr600727985a.77.1773149634364; Tue, 10 Mar 2026 06:33:54 -0700 (PDT) X-Received: by 2002:a05:620a:31aa:b0:8cd:8f04:50f5 with SMTP id af79cd13be357-8cd8f045625mr600722485a.77.1773149633735; Tue, 10 Mar 2026 06:33:53 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13d01cbfasm2766397e87.14.2026.03.10.06.33.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 06:33:52 -0700 (PDT) Date: Tue, 10 Mar 2026 15:33:50 +0200 From: Dmitry Baryshkov To: Ben Dooks Cc: freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, simona@ffwll.ch, airlied@gmail.com, marijn.suijten@somainline.org, sean@poorly.run, jesszhan0024@gmail.com, abhinav.kumar@linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/msm/hdmi: make 'msm_hdmi_pm_ops' static Message-ID: <2ojzypkvxomlzfv4yb3l5scnkozxxknth2egkfl6ivmo24shju@gfa64pxrmnk6> References: <20260310132501.195954-1-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260310132501.195954-1-ben.dooks@codethink.co.uk> X-Proofpoint-ORIG-GUID: 4Glh17HE-UJxhks1rxs99w_E3SJtmnCf X-Proofpoint-GUID: 4Glh17HE-UJxhks1rxs99w_E3SJtmnCf X-Authority-Analysis: v=2.4 cv=YcmwJgRf c=1 sm=1 tr=0 ts=69b01dc3 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=1EsaE_6oAAAA:8 a=EUspDBNiAAAA:8 a=NChewM1GXYrQM836dJ4A:9 a=CjuIK1q_8ugA:10 a=dawVfQjAaf238kedN5IG:22 a=3ZumFrijQQ-2J9H5h8ct:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDExOCBTYWx0ZWRfX/NsuTjkXcAPU L94n4Bob1C8rkDyyXqilmaAfQ3qIjVeTZZE5uDxxPmFovFr3H6/LwZaVAXA8bmEXy0Vd9qoeqQl HKphPPhvPnRJwPrwtOwHtK/SvOhYy48/BHMg2rmZ1wcTfVCCV3Lv86tjjMrrbn5zCFCM0CDHWnI L/hrPki3GlAlVW0uiwj/y3iMarSWc4KPWNRm5Ne23+/HkeODJ2unx/QMWNFLR4BqtoI77rbjRMo XqqbYL12VSonMLTJuVQTYxl1wY9qncKawpXblIX5J4rItCD/VYgd4bH70cf4hb2xQ/S2hOXRjef U7YA09/TVz5hJpmu12N3P+8P0WKQKiZcUztnHB5ZbprRdRT5eH1SckTxIjUx0V9kq/APaduNJBW kFHzmqIPQh1uD9AFRM79fla8crDFmFD3nWE7eGFFIkAsoUDFh4qrmyAwuoAQ979E6Pm/HroJdFr WrNc9tRb4YF4Omkf5sw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 impostorscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100118 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Mar 10, 2026 at 01:25:01PM +0000, Ben Dooks wrote: > The struct 'msm_hdmi_pm_ops' is not used outside of the > file it is defined in, so make it static. > > Fixes the following sparse warning: > drivers/gpu/drm/msm/hdmi/hdmi.c:432:1: warning: symbol 'msm_hdmi_pm_ops' was not declared. Should it be static? > > Signed-off-by: Ben Dooks > --- > drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry