From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB1B9CD4F5B for ; Fri, 22 May 2026 06:29:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D49610E056; Fri, 22 May 2026 06:29:20 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=rock-chips.com header.i=@rock-chips.com header.b="Ge2Vi3wu"; dkim-atps=neutral Received: from mail-m60217.netease.com (mail-m60217.netease.com [210.79.60.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 12EEF10E056 for ; Fri, 22 May 2026 06:29:17 +0000 (UTC) Received: from [172.16.12.43] (unknown [61.154.14.86]) by smtp.qiye.163.com (Hmail) with ESMTP id 3f6a8ca63; Fri, 22 May 2026 14:29:13 +0800 (GMT+08:00) Message-ID: <32192c5f-cc25-4a2d-ada6-53f28edb6cbb@rock-chips.com> Date: Fri, 22 May 2026 14:29:12 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 01/10] dt-bindings: display: rockchip: analogix-dp: Fix hclk as third clock for RK3588 To: Krzysztof Kozlowski Cc: hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, nicolas.frattaroli@collabora.com, cristian.ciocaltea@collabora.com, sebastian.reichel@collabora.com, dmitry.baryshkov@oss.qualcomm.com, luca.ceresoli@bootlin.com, dianders@chromium.org, m.szyprowski@samsung.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260521080835.1362416-1-damon.ding@rock-chips.com> <20260521080835.1362416-2-damon.ding@rock-chips.com> <20260522-demonic-shaggy-wasp-a3f261@quoll> Content-Language: en-US From: Damon Ding In-Reply-To: <20260522-demonic-shaggy-wasp-a3f261@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Tid: 0a9e4e5fadf103a3kunmc160eef7c9158 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVkZSx0dVh0aQ0sYS00ZSk5IHlYVFA kWGhdVEwETFhoSFyQUDg9ZV1kYEgtZQVlNSlVKTk9VSk9VQ01ZV1kWGg8SFR0UWUFZT0tIVUpLSE pKQk1VSktLVUpCWQY+ DKIM-Signature: a=rsa-sha256; b=Ge2Vi3wu2ir9dKSljIze3RU0HI4ooU+nbjYYN4NtZj672UOwX4tXHZTNQBewK8gB1YpVxTOQiJbWg6hCG5TY5DkfojEbr4ySYSz6NS7/DhB3GUh9wi1h+ORTDA9wJNNjA9a563651C6YEN+H6GxyCjSRhiEP3Y5LAchPv2jlqA0=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=qMah8/jyNcPvAfqkwCIR/RWKyy2WqG3nOuBp+tSy2AA=; h=date:mime-version:subject:message-id:from; X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Krzysztof, On 5/22/2026 2:11 PM, Krzysztof Kozlowski wrote: > On Thu, May 21, 2026 at 04:08:26PM +0800, Damon Ding wrote: >> RK3588 eDP controller requires HCLK_VO1 to access the VO1 GRF >> registers and enable the video datapath. >> >> Previously, the clock was enabled implicitly via the 'rockchip,vo-grf' >> phandle reference, which allowed the eDP to work without explicitly >> managing the hclk_vo1 clock. However, this is not safe or explicit. >> >> To make the clock dependency explicit, enforce per-SoC clock-names >> requirements: >> - RK3288: 2 clocks (dp, pclk) >> - RK3399: 3 clocks (dp, pclk, grf) >> - RK3588: 3 clocks (dp, pclk, hclk) >> >> Do not reuse the 'grf' clock name for RK3588 because it represents >> a different clock with distinct control logic: >> - The 'grf' clock is only for GRF register access and is toggled >> dynamically during register access. >> - The 'hclk' clock controls both GRF access and video datapath >> gating, and must remain enabled during probe. >> >> Fixes: f855146263b1 ("dt-bindings: display: rockchip: analogix-dp: Add support for RK3588") >> Signed-off-by: Damon Ding >> >> --- >> >> Changes in v4: >> - Modify the commit msg. >> >> Changes in v5: >> - Enforce the correct third clock name on a per-compatible basis. >> - Modify the commit msg simultaneously. >> >> Changes in v6: >> - Expand more detail commit msg about using hclk instead of grf clock. >> --- >> .../rockchip/rockchip,analogix-dp.yaml | 37 +++++++++++++++++-- >> 1 file changed, 33 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml >> index d99b23b88cc5..8001c1facf98 100644 >> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml >> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml >> @@ -23,10 +23,7 @@ properties: >> >> clock-names: >> minItems: 2 >> - items: >> - - const: dp >> - - const: pclk >> - - const: grf >> + maxItems: 3 >> >> power-domains: >> maxItems: 1 >> @@ -60,6 +57,33 @@ required: >> allOf: >> - $ref: /schemas/display/bridge/analogix,dp.yaml# >> >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - rockchip,rk3288-dp >> + then: >> + properties: >> + clock-names: >> + items: >> + - const: dp >> + - const: pclk > > Why aren't there constraints for clocks? They always must come together. > > Please open any other binding and look how it is done there. > > Yes, as Conor's suggestion, the right way is to keep all valid clock names at the top level, and use only minItems/maxItems in allOf to differentiate clocks and clock-names of platforms. I will update this in next version. Best regards, Damon