public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: "Mukesh Kumar Chaurasiya (IBM)" <mkchauras@gmail.com>,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	airlied@gmail.com, simona@ffwll.ch, dakr@kernel.org,
	aliceryhl@google.com, ojeda@kernel.org, boqun@kernel.org,
	gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org,
	a.hindborg@kernel.org, tmgross@umich.edu,
	daniel.almeida@collabora.com, lina+kernel@asahilina.net,
	j@jananu.net, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH V1 0/2] Rust DRM build fix
Date: Mon, 27 Apr 2026 08:21:51 +0200	[thread overview]
Message-ID: <46b215b8-4b78-4a84-9474-ca5f852b2c95@suse.de> (raw)
In-Reply-To: <20260426082234.2026908-1-mkchauras@gmail.com>

Hi

Am 26.04.26 um 10:22 schrieb Mukesh Kumar Chaurasiya (IBM):
> rust drm gem shmem doesn't builds due to an import error of ARef from
> types instead of sync.
>
> This series fixes that and also makes CONFIG_RUST_DRM_GEM_SHMEM_HELPER
> dependent of RUST and making it selectable from menuconfig.

Memory managers are selected by drivers, not by users. You have to fix 
the driver rules instead.

Best regards
Thomas

>
> Mukesh Kumar Chaurasiya (IBM) (2):
>    rust/drm: import ARef from sync crate
>    drm: Make CONFIG_RUST_DRM_GEM_SHMEM_HELPER selectable from menuconfig
>
>   drivers/gpu/drm/Kconfig      | 4 ++--
>   rust/kernel/drm/gem/shmem.rs | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)



  parent reply	other threads:[~2026-04-27  6:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-26  8:22 [PATCH V1 0/2] Rust DRM build fix Mukesh Kumar Chaurasiya (IBM)
2026-04-26  8:22 ` [PATCH V1 1/2] rust/drm: import ARef from sync crate Mukesh Kumar Chaurasiya (IBM)
2026-04-28  5:21   ` Claude review: " Claude Code Review Bot
2026-04-26  8:22 ` [PATCH V1 2/2] drm: Make CONFIG_RUST_DRM_GEM_SHMEM_HELPER selectable from menuconfig Mukesh Kumar Chaurasiya (IBM)
2026-04-28  5:21   ` Claude review: " Claude Code Review Bot
2026-04-27  6:21 ` Thomas Zimmermann [this message]
2026-04-28  5:21 ` Claude review: Rust DRM build fix Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46b215b8-4b78-4a84-9474-ca5f852b2c95@suse.de \
    --to=tzimmermann@suse.de \
    --cc=a.hindborg@kernel.org \
    --cc=airlied@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gary@garyguo.net \
    --cc=j@jananu.net \
    --cc=lina+kernel@asahilina.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mkchauras@gmail.com \
    --cc=mripard@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox