public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Icenowy Zheng <zhengxingda@iscas.ac.cn>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard	 <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Jianmin Lv	 <lvjianmin@loongson.cn>,
	Qianhai Wu <wuqianhai@loongson.cn>,
	Huacai Chen	 <chenhuacai@kernel.org>,
	Mingcong Bai <jeffbai@aosc.io>, Xi Ruoyao	 <xry111@xry111.site>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/loongson: stop to set get_vblank_timestamp for LS7A1000 CRTC
Date: Sat, 21 Mar 2026 17:29:23 +0800	[thread overview]
Message-ID: <47337244ebd0ce4efd3e065183e863421925f99f.camel@iscas.ac.cn> (raw)
In-Reply-To: <20260321092804.3519447-1-zhengxingda@iscas.ac.cn>

在 2026-03-21六的 17:28 +0800,Icenowy Zheng写道:
> As there's no known hardware capability about querying vblank on the
> LS7A1000 display controller, setting get_vblank_timestamp will
> mislead the
> kernel about the support of DC-backed high precision vblank query.
> 
> Drop this function pointer in the CRTC function table for LS7A1000.
> 
> This solves a kernel warning when booting Linux 7.0-rc3 on a
> Loongson-3A4000+LS7A1000 Haier Boyue G51 laptop (with injected EDID
> for
> replicating the display timing set by the firmware).
> 
> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>

Oh forgot to attach when crafting v2:

```
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
```

> ---
> Changes in v2:
> - Re-formatted Loongson product model numbers per request from
> Huacai.
> 
>  drivers/gpu/drm/loongson/lsdc_crtc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/loongson/lsdc_crtc.c
> b/drivers/gpu/drm/loongson/lsdc_crtc.c
> index 587fbe285e9ef..b3af8e0cdb15f 100644
> --- a/drivers/gpu/drm/loongson/lsdc_crtc.c
> +++ b/drivers/gpu/drm/loongson/lsdc_crtc.c
> @@ -721,7 +721,6 @@ static const struct drm_crtc_funcs
> ls7a1000_crtc_funcs = {
>  	.late_register = lsdc_crtc_late_register,
>  	.enable_vblank = lsdc_crtc_enable_vblank,
>  	.disable_vblank = lsdc_crtc_disable_vblank,
> -	.get_vblank_timestamp =
> drm_crtc_vblank_helper_get_vblank_timestamp,
>  	.atomic_print_state = lsdc_crtc_atomic_print_state,
>  };
>  


  reply	other threads:[~2026-03-21  9:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-21  9:28 [PATCH v2] drm/loongson: stop to set get_vblank_timestamp for LS7A1000 CRTC Icenowy Zheng
2026-03-21  9:29 ` Icenowy Zheng [this message]
2026-03-21 17:09 ` Claude review: " Claude Code Review Bot
2026-03-21 17:09 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47337244ebd0ce4efd3e065183e863421925f99f.camel@iscas.ac.cn \
    --to=zhengxingda@iscas.ac.cn \
    --cc=airlied@gmail.com \
    --cc=chenhuacai@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jeffbai@aosc.io \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvjianmin@loongson.cn \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=wuqianhai@loongson.cn \
    --cc=xry111@xry111.site \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox