From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C3F8F364CA for ; Thu, 9 Apr 2026 22:09:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DD86210E08B; Thu, 9 Apr 2026 22:09:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="kNv/mPHE"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gCs2zZQ/"; dkim-atps=neutral Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 42A2B10E099 for ; Thu, 9 Apr 2026 22:09:06 +0000 (UTC) Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 639JIQin2866428 for ; Thu, 9 Apr 2026 22:09:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=0HMFaKZjpgyXaau/0X9Mxm/w GN/42VWp/aAAASGyGoc=; b=kNv/mPHEw/tFjVBnkayEOYmjoDA8xsri9s1Fx5AI j1rghVQSftnAm0tVvn+YyX5kR6NxS6O3dSqWEcQ/9lSZ+hrdwdG1+gilPhovXIoD gNr0mctsDpiBtOOepvYk2JQV1iPFChb/nlhXUGmm85iCETuMErjbBM/gwSw4nRtJ TuhcWuPxw7Wm3KU5go4mRE9Jh4bmK3YUSGd4dmcq9UXo52BVx7jxPFeFAqhdLoqA hqNgGZhxbOWpGXFD2ueRY9MHdyKwFe7ReAxa1BSeJFtvdMjnD+rEtIyQTkwTnTcs gX/v09P9lvNyi4ZmJgZQgtoEGgqdjnNr002UF6Z1Acb45A== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4decayhy1x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 09 Apr 2026 22:09:05 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8d3a8df9a52so280491985a.1 for ; Thu, 09 Apr 2026 15:09:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775772544; x=1776377344; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0HMFaKZjpgyXaau/0X9Mxm/wGN/42VWp/aAAASGyGoc=; b=gCs2zZQ/dKXGFc8GVlCZey88L827VSL0Bc9wr7Il6LJjhJ59Byvh6Vl6b4ChrkKsMa pVi0Djql+zbMt42DROSI1EED01QdJh0C9oABbTCpLkdmQkpwN2a/+bb40+O9QVKGux4W u47nexpPnZspdocH1hzJ6KRv13y43KA2tH2FdFssLtyvWdyzovuHS58zwLx8KYPYTrIk zMG4DcH/ZChGn8UvukEgUiyamsqVoGA9rH/0ZuaY/2r6rxArxWKIf0Vcvx8gtiQv3kY2 WJ7/I2woIEdq2HBijh80VBmokcVYflARBmrcglLp/KlBA8Cg+sUNiSv1mmMwEQqmZ3/5 Q63g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775772544; x=1776377344; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0HMFaKZjpgyXaau/0X9Mxm/wGN/42VWp/aAAASGyGoc=; b=UgPC3KEweMGbaMuU5qNdimKj+8bl4eqB48EPkrlbPsFLzMCqjQ/EZQdi7DctqC0Ncr 7JGSbGXc9ZBwkBanyVT9T0ynLovmbU+JbuG3xLzZhB+znFS72/vgz+gNnxIww3lcsrdz 3lPjDpnGBj9pGtL2y0cu8gFtN24rh2eSMfXGynwp1tCdrvPjtHf2YjQ18FqKd/knRVAR Kz/DnVTYgSjOuSyWEGBJ+GqbRmVQHH4YpQuPzk1ydyAwhtGc+kw7tq+ZYl0eDnskMQJu 05YzlMt82lYJNkYMKwtcYAIUUGyzrd1Db15Rw10e3U88WQ3zLxB8qKakGVoR63eTEbtN PU1Q== X-Forwarded-Encrypted: i=1; AJvYcCUwa4kaFYPw3PLxTMPKyjiL25JAp9//TsF63Lhxq+Av5IplSWkmpKUiZGnuOhn2dtH/k8Kb9OUG8sw=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yyg7nGOSG5HhTPWTweA/B3GfgzrGbTtx4bHIzhfC8D1GHvHzf2q S4SxDgLRQEPFNiRRuidapFmPJ8SclwtUXmxxYjQ1OdKjgAN3G8C4MAHC4Y1G9zpJ8BSl0lDoXMf 5i8d4SH8UxhLa0Bwg7fiJ5TWCZkdFxakDVUaoFVM6fn0ReQxduAzTwPlfviX9Qj6JbCwUI1Q= X-Gm-Gg: AeBDietjOFE5X0yE1BcVL4iZDENHSAkBP836rUsxLhH2HRFrRDSZjAZmwzUxwR3DD/S X8HUSHshfCU68Rhf/PvoaP03TETCqVwt0HZ8LntqR6hB6VMp4QOaScI7+qeYYuYl+URoFqxS9Ug c4WUvnge3gdeaJf6Ss8htADSARfqjsda8BXNsq7GaZj1vf660A9DbfYHuKU3pjnyEDSefuuGlpB mxQazW5/GUP4xzV26mIt4/0g6cB8ivoqLN1s8G4gKt8tyWN/3pBVemNn9bBt5ujjabXcsoTYq35 XVqMh9L7TvNWYUoh+gpKgSPoD53XmN0bgqR6kt36njJq85+qetXBec/O0slHZdmT07Wme5XPgaT rM8B6dp1YqsHGPdu5dZywpFqRjgs/rEfG903h6LA7/YJhkGeohcbA/97vTwaxaQFf6LSJKOEh65 4myfSd2s9IFQBsqyzTb+auKnBbniI15k8BWWM= X-Received: by 2002:a05:622a:2485:b0:50b:50bf:5bbe with SMTP id d75a77b69052e-50dd5adbf6fmr15604061cf.22.1775772544428; Thu, 09 Apr 2026 15:09:04 -0700 (PDT) X-Received: by 2002:a05:622a:2485:b0:50b:50bf:5bbe with SMTP id d75a77b69052e-50dd5adbf6fmr15603721cf.22.1775772543912; Thu, 09 Apr 2026 15:09:03 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a3eee864a2sm196421e87.2.2026.04.09.15.09.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 15:09:02 -0700 (PDT) Date: Fri, 10 Apr 2026 01:09:00 +0300 From: Dmitry Baryshkov To: Nicolas Frattaroli Cc: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Dmitry Baryshkov , Sascha Hauer , Rob Herring , Jonathan Corbet , Shuah Khan , kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v12 05/25] drm/atomic-helper: Add HDMI bridge output bus formats helper Message-ID: <47l6v3hxfnl75heek4o7fmhybafk44ewsrr66sdw55ahjv5oof@sku3nqbhg2tx> References: <20260409-color-format-v12-0-ce84e1817a27@collabora.com> <20260409-color-format-v12-5-ce84e1817a27@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260409-color-format-v12-5-ce84e1817a27@collabora.com> X-Authority-Analysis: v=2.4 cv=XtnK/1F9 c=1 sm=1 tr=0 ts=69d82381 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=QX4gbG5DAAAA:8 a=EUspDBNiAAAA:8 a=FnALt_FR2tA_ePdYDbsA:9 a=CjuIK1q_8ugA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=AbAUZ8qAyYyZVLSsDulk:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA5MDIwNCBTYWx0ZWRfX7EhFHHre6IXG H6CBTeaklQvvXsG/iRDpatBvRteT+HGVejpsm9a7J7sh99WdNfAetqaEMm7zv6HQYdpFTFIyx71 XltZ5RTVITGFnNIM1eJBrVTcMi8VvL4UW6y03CW+zuV/utaeGsEpYkZbgAWGqcW3ssRm2yqrAEE bHGT4WShGC4oQKnLJ0ztWjc0yyFsVYRWx+MRz1lHteTLvIfZXXpR8tB6elqBEJubJ5dA3JbB8A0 HvQim6ErTr2uixwWr5r2HAT52bH1H79AJsbkcb2YzVk41PVoCfzZhmMkTmUgis2OF8OtIq0qxkF 8VO7uV4WzOeSa2zmdHE77v2sYAqsrgTRFwvV5M+MgkbHOxwtZ9K4fFHaclmhTeMKKBPLDAEl/wK 3zcUb6IpPXIbdd68hr0Y8aPNmnJKCr7HXznvqWWeXnbtkreTIvJ0jrexNDug8QZcyOB4Eygb8KY TwdwHh6ed0aBz6GgiHw== X-Proofpoint-GUID: 41NmBgZqWrBr8mwjbpa9sRGKLwR9cusx X-Proofpoint-ORIG-GUID: 41NmBgZqWrBr8mwjbpa9sRGKLwR9cusx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-09_04,2026-04-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 bulkscore=0 phishscore=0 impostorscore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604090204 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Apr 09, 2026 at 05:44:55PM +0200, Nicolas Frattaroli wrote: > The drm_bridge_funcs atomic_get_output_bus_fmts operation should be the > same for likely every HDMI connector bridge, unless such an HDMI > connector bridge has some special hardware restrictions that I cannot > envision yet. > > To avoid code duplication and standardize on a set of media bus formats > that the HDMI output color formats translate to, add a common helper > function that implements this operation to the drm bridge helpers. > > The function returns a list of output bus formats based on the HDMI > bridge's current output bits-per-component, and its bitmask of supported > color formats. > > To guard against future expansion of DRM_OUTPUT_COLOR_FORMAT outgrowing > the hweight8 call, add a BUILD_BUG_ON statement where it's used that > checks for DRM_OUTPUT_COLOR_FORMAT_COUNT. The justification for not > using hweight32 in all cases is that not all ISAs have a popcount > instruction, and will benefit from a smaller/faster software > implementation that doesn't have to operate across all bits. > > The justification for not defining an hweight_color depending on the > value of DRM_OUTPUT_COLOR_FORMAT_COUNT is that this count enum value is > only known at compile time, not at preprocessor time. > > Signed-off-by: Nicolas Frattaroli > --- > drivers/gpu/drm/drm_atomic_helper.c | 81 +++++++++++++++++++++++++++++++++++++ > include/drm/drm_atomic_helper.h | 7 ++++ > 2 files changed, 88 insertions(+) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry