Claude review: arm64: dts: renesas: r9a09g047e57-smarc: Enable DU0 and DSI support

Claude Code Review Bot
2026-04-12T02:46:00Z

Patch Review

Board-level enablement connecting DU0 → DSI → ADV7535 → HDMI connector.

**Observation**: Only DU0's DSI output is connected. DU1 is not enabled. LVDS outputs are not connected. This matches a typical SMARC EVK configuration with HDMI output.

**The ADV7535 configuration looks correct**: Uses 4 DSI data lanes, proper supplies, CEC clock, I2C addresses for main/edid/cec/packet.

**Minor**: The `dsi_in0` and `dsi_out` endpoints are overridden here — `dsi_in0` gets `remote-endpoint = <&du0_out_dsi>` and `dsi_out` gets `remote-endpoint = <&adv7535_in>` plus `data-lanes`. This is the standard pattern for DT overlays/board files. The empty endpoints in the SoC DTSI (patch 20) serve as connection points.

No significant issues.

---

**Summary of actionable items**:

1. **Patch 13 (bug)**: Fix indentation of the `if (IS_ERR(dsi->vclk[0]))` block — currently at wrong indent level.
2. **Patch 13 (bug)**: Initialize `ep_enabled = false` in `rzg2l_mipi_dsi_get_input_port()` to prevent use of uninitialized variable when no endpoints exist.
3. **Patch 13 (bug)**: `of_device_is_available(remote_ep)` is checking an endpoint node, not a device node. Endpoint nodes don't have `status` properties — should check the port parent device instead.
4. **Patch 13 (bug)**: Missing `of_node_put(ep_node)` when breaking out of `for_each_endpoint_of_node` loop early.
5. **Patch 14 (minor)**: `rzg3e_mipi_dsi_info` should be `const` like the other hw_info structs.
6. **Patch 10 (question)**: Is requiring `port@3` (LVDS1) for all RZ/G3E DU nodes intentional? This seems overly restrictive.

---
Generated by Claude Code Patch Reviewer