From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 490FCFCE066 for ; Thu, 26 Feb 2026 12:48:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 988A410E922; Thu, 26 Feb 2026 12:48:49 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; secure) header.d=mailbox.org header.i=@mailbox.org header.b="xOCoDQgb"; dkim-atps=neutral Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6664810E922 for ; Thu, 26 Feb 2026 12:48:48 +0000 (UTC) Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4fMB8j0dcqz9trN; Thu, 26 Feb 2026 13:48:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1772110123; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eCbbfDV+XUbBeDTTzxN+zs2oC4DcICVSdVXKpDkIdZU=; b=xOCoDQgbfHkchJ4BfiohkVg3ZrExLuxeh+ioYqo4nJWZfmi6fsh15YDOUTq6Ugacu2f7uO EYnFWLMfQDNkkUrIEwjdEj1Ef32fgLnV6/XOMRn+XNjl8/2yQB+abJDUnBVa3vw1Nz1qzs c5K+dcxPoz0+U1pGu5vga+Duw/1izVGgP9zNgOyiyXemC85C+hoRU7W1ZkLz7R8lz+kXUZ YkfQu3XNSOEbS1FLny9eTlcCmnp2wEpxLHADyaJUlAKdRAfhZl1ny08TLqwOMNfDbzVCmC QOMgxbJPhBNDici4aN6IW0XQgTLQRtE/+umbeWgiICXghejZ8bGkKvrRc+NaKw== Message-ID: <595ce86b8a91f18ab8c73295a4a89c8f9353a794.camel@mailbox.org> Subject: Re: [PATCH] drm/tests: Mark slow tests as slow From: Philipp Stanner To: Tvrtko Ursulin , Maxime Ripard Cc: Matthew Brost , Danilo Krummrich , Philipp Stanner , Christian Koenig , Maarten Lankhorst , Thomas Zimmermann , Matthew Auld , Arun Pravin , Simona Vetter , David Airlie , dri-devel@lists.freedesktop.org Date: Thu, 26 Feb 2026 13:48:27 +0100 In-Reply-To: References: <20260224110310.1854608-1-mripard@kernel.org> <1c76b8d6-9394-4017-a18f-95ecc2c08175@ursulin.net> <20260226-certain-tuscan-caribou-ba4c5e@penduick> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MBO-RS-META: ufsykrqudz6pshtf5c51uwsssxyz1de9 X-MBO-RS-ID: 6b9f713a0bbd40daa39 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: phasta@kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 2026-02-26 at 12:42 +0000, Tvrtko Ursulin wrote: >=20 > On 26/02/2026 10:56, Maxime Ripard wrote: >=20 >=20 [=E2=80=A6] > > > > =C2=A0=C2=A0=C2=A0 {} > > > > =C2=A0=C2=A0 }; > > > > =C2=A0=C2=A0 static struct kunit_suite drm_sched_priority =3D { > > > > =C2=A0=C2=A0=C2=A0 .name =3D "drm_sched_basic_priority_tests", > > > > @@ -544,11 +544,11 @@ static void drm_sched_test_credits(struct kun= it *test) > > > > =C2=A0=C2=A0=C2=A0 drm_mock_sched_entity_free(entity); > > > > =C2=A0=C2=A0=C2=A0 drm_mock_sched_fini(sched); > > > > =C2=A0=C2=A0 } > > > > =C2=A0=C2=A0 static struct kunit_case drm_sched_credits_tests[] =3D= { > > > > - KUNIT_CASE(drm_sched_test_credits), > > > > + KUNIT_CASE_SLOW(drm_sched_test_credits), > > >=20 > > > Same really. > > >=20 > > > Anyway, the scheduler parts LGTM and I can follow up trying to optimi= se > > > these two later. > > >=20 > > > For the scheduler: > > >=20 > > > Reviewed-by: Tvrtko Ursulin > >=20 > > Thanks! >=20 > I have a patch already which makes those (and one more) test cases=20 > faster, but I will wait sending it until you merge this one. And why would we want to flag a test as slow just to immediately afterwards make it faster? Would it not be wiser to drop Maxime's change? P.