From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D52FFC590F for ; Thu, 26 Feb 2026 09:00:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A0D7F10E88C; Thu, 26 Feb 2026 09:00:14 +0000 (UTC) Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5057D10E88C for ; Thu, 26 Feb 2026 09:00:13 +0000 (UTC) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vvXDg-00073c-Bg; Thu, 26 Feb 2026 09:59:40 +0100 Received: from lupine.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::4e] helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vvXDd-002hWz-1F; Thu, 26 Feb 2026 09:59:38 +0100 Received: from pza by lupine with local (Exim 4.98.2) (envelope-from ) id 1vvXDe-000000004FT-2WQa; Thu, 26 Feb 2026 09:59:38 +0100 Message-ID: <62beeba182aa7e84c6cd02805a0e75094ad10a6e.camel@pengutronix.de> Subject: Re: [PATCH 09/14] drm/bridge: synopsys: dw-hdmi: Convert to drm_output_color_format From: Philipp Zabel To: Maxime Ripard , Nicolas Frattaroli , Jani Nikula , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?ISO-8859-1?Q?K=F6nig?= , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Andy Yan , Liviu Dudau , Chun-Kuang Hu , Matthias Brugger , AngeloGioacchino Del Regno , Sandy Huang , Heiko =?ISO-8859-1?Q?St=FCbner?= , Liu Ying , Chen-Yu Tsai , Samuel Holland , Dave Stevenson , =?ISO-8859-1?Q?Ma=EDra?= Canal , Raspberry Pi Kernel Maintenance Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev Date: Thu, 26 Feb 2026 09:59:38 +0100 In-Reply-To: <20260224-drm-rework-color-formats-v1-9-bebc76604ada@kernel.org> References: <20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org> <20260224-drm-rework-color-formats-v1-9-bebc76604ada@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Di, 2026-02-24 at 11:58 +0100, Maxime Ripard wrote: > Now that we introduced a new drm_output_color_format enum to represent > what DRM_COLOR_FORMAT_* bits were representing, we can switch to the new > enum. >=20 > The main different is that while DRM_COLOR_FORMAT_ was a bitmask, > drm_output_color_format is a proper enum. However, the enum was done is > such a way than DRM_COLOR_FORMAT_X =3D BIT(DRM_OUTPUT_COLOR_FORMAT_X) so > the transitition is easier. >=20 > The only thing we need to consider is if the original code meant to use > that value as a bitmask, in which case we do need to keep the bit shift, > or as a discriminant in which case we don't. >=20 > Signed-off-by: Maxime Ripard Reviewed-by: Philipp Zabel regards Philipp