From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C313CD4855 for ; Tue, 12 May 2026 08:59:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C71BA10E9CA; Tue, 12 May 2026 08:59:38 +0000 (UTC) Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) by gabe.freedesktop.org (Postfix) with ESMTPS id 594D210E9D4 for ; Tue, 12 May 2026 08:59:38 +0000 (UTC) Received: by mail-oo1-f69.google.com with SMTP id 006d021491bc7-698229e6b62so9105893eaf.3 for ; Tue, 12 May 2026 01:59:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778576377; x=1779181177; h=cc:to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Qry07HiLRpI4moE29vwWP3imXR+DsmNoqtYT3jSQb00=; b=jAorvpFvRqM1O1KKQ+6BXmXjt4kFyk7hfPGKDVgxtr4PSG7YTMIsefOVj5y78+wq2B XnPCnqxXS1Q4ULJGF0n38CPrTcIXBBML2XG7Fh+i8Yvw3ERhoJpeEaX8o6HDWgcT2cJP at3Fr4te4XfXBG/vxV+hU9zI/K0+TDSbQpDIde0OLuQ2CgX6QCaRlRLcaCOFCqoBco8j 8+s3gQkSBKAmdQRqxMIeOTU4WwlGAX258/rUwViUi/gPEovCPO48uvU5sgBipVAhtDhf 0OgeAvLFcGIRKypSOdKA4+oMIdkQCyfL+7JkApUyC7p+i79hA7cDveoeQ+q4RxcI7k41 Tbiw== X-Forwarded-Encrypted: i=1; AFNElJ8Hp4BijDnUxFbw64cnsy2K9O5q/H0ij+2bfJ+QjMIzhQ6kjvGCve9dbWoOmuKbC4/WjRg83n4dPxc=@lists.freedesktop.org X-Gm-Message-State: AOJu0YyyR9hSTNpC5ny3TPJNGaXluUvEotPFdYACWziTHUaqMIiPQLSj SN0sC+InEXW0GSfMX/JSjvmogVekxPISaXV0vT4gP8B7wgXlyzexnuSnag87AgYldWQ3LZo9f62 4au2Rz9/rKExFtUKU1FXoWx3yh0ZLwkx5AnqexG6gW5C53N4hRbRZwz5Eue4= MIME-Version: 1.0 X-Received: by 2002:a05:6820:190e:b0:67e:36e9:79ac with SMTP id 006d021491bc7-69998cc3719mr14591303eaf.27.1778576377620; Tue, 12 May 2026 01:59:37 -0700 (PDT) Date: Tue, 12 May 2026 01:59:37 -0700 In-Reply-To: <20260512-virtio-gpu_wait_event-v1-1-207eb4c1a69a@redhat.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <6a02ebf9.170a0220.7f9b3.000b.GAE@google.com> Subject: Re: [PATCH] drm/virtio: add timeout to virtqueue wait to avoid hung task From: syzbot To: ryasuoka@redhat.com Cc: airlied@redhat.com, dmitry.osipenko@collabora.com, dri-devel@lists.freedesktop.org, gurchetansingh@chromium.org, kraxel@redhat.com, linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, olvaffe@gmail.com, ryasuoka@redhat.com, simona@ffwll.ch, tzimmermann@suse.de, virtualization@lists.linux.dev Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > virtio_gpu_queue_ctrl_sgs() and virtio_gpu_queue_cursor() use > wait_event() without timeout when waiting for virtqueue space. If the > host device stops processing commands, these waits block indefinitely. > Since callers may hold DRM locks, this can make the entire system > unresponsive. > > Replace wait_event() with wait_event_timeout() using a 5-second timeout, > consistent with the existing timeout pattern in the driver. On timeout, > clean up and return -ENODEV, following the same error path as > drm_dev_enter() failure. > > Reported-by: syzbot+d6dd6f86d3aaf7eebe7406e45c1c6e549453f224@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?id=d6dd6f86d3aaf7eebe7406e45c1c6e549453f224 > Reported-by: syzbot+908bd910da5dd79b88de4cf7baf376cc873a922e@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?id=908bd910da5dd79b88de4cf7baf376cc873a922e > Signed-off-by: Ryosuke Yasuoka > --- > drivers/gpu/drm/virtio/virtgpu_vq.c | 20 ++++++++++++++++++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c > index 67865810a2e7..05e816a0ae0b 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_vq.c > +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c > @@ -396,7 +396,16 @@ static int virtio_gpu_queue_ctrl_sgs(struct virtio_gpu_device *vgdev, > if (vq->num_free < elemcnt) { > spin_unlock(&vgdev->ctrlq.qlock); > virtio_gpu_notify(vgdev); > - wait_event(vgdev->ctrlq.ack_queue, vq->num_free >= elemcnt); > + if (!wait_event_timeout(vgdev->ctrlq.ack_queue, > + vq->num_free >= elemcnt, > + 5 * HZ)) { > + /* The device did not respond */ > + if (fence && vbuf->objs) > + virtio_gpu_array_unlock_resv(vbuf->objs); > + free_vbuf(vgdev, vbuf); > + drm_dev_exit(idx); > + return -ENODEV; > + } > goto again; > } > > @@ -566,7 +575,14 @@ static void virtio_gpu_queue_cursor(struct virtio_gpu_device *vgdev, > ret = virtqueue_add_sgs(vq, sgs, outcnt, 0, vbuf, GFP_ATOMIC); > if (ret == -ENOSPC) { > spin_unlock(&vgdev->cursorq.qlock); > - wait_event(vgdev->cursorq.ack_queue, vq->num_free >= outcnt); > + if (!wait_event_timeout(vgdev->cursorq.ack_queue, > + vq->num_free >= outcnt, > + 5 * HZ)) { > + /* The device did not respond */ > + free_vbuf(vgdev, vbuf); > + drm_dev_exit(idx); > + return; > + } > spin_lock(&vgdev->cursorq.qlock); > goto retry; > } else { > > --- > base-commit: 5d6919055dec134de3c40167a490f33c74c12581 > change-id: 20260512-virtio-gpu_wait_event-e0cdf8675b7c > > Best regards, > -- > Ryosuke Yasuoka > I see the command but can't find the corresponding bug. The email is sent to syzbot+HASH@syzkaller.appspotmail.com address but the HASH does not correspond to any known bug. Please double check the address.