From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Maxime Ripard <mripard@kernel.org>
Cc: Jyri Sarha <jyri.sarha@iki.fi>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Sam Ravnborg <sam@ravnborg.org>,
Javier Martinez Canillas <javierm@redhat.com>,
Aradhya Bhatia <a-bhatia1@ti.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Devarsh Thakkar <devarsht@ti.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2] drm/tidss: Fix missing drm_bridge_attach() call
Date: Wed, 11 Mar 2026 11:15:58 +0200 [thread overview]
Message-ID: <70e2b0e4-0b27-4fad-8dc0-c28e10c959ad@ideasonboard.com> (raw)
In-Reply-To: <20260311-spirited-mighty-grouse-e0b1cb@houat>
Hi,
On 11/03/2026 11:08, Maxime Ripard wrote:
> On Wed, Mar 11, 2026 at 10:16:29AM +0200, Tomi Valkeinen wrote:
>> tidss encoder-bridge is not added with drm_bridge_add() call, which
>> leads to:
>>
>> [drm] Missing drm_bridge_add() before attach
>>
>> Add the missing call, using devm_drm_bridge_add() variant to get the
>> drm_bridge_remove() handled automatically.
>
> The patch itself is fine, but the commit title mentions a missing
> drm_bridge_attach() call when it should be drm_bridge_add()
>
> With that fixed
> Acked-by: Maxime Ripard <mripard@kernel.org>
Indeed. Fixed in v2. Thanks!
Tomi
next prev parent reply other threads:[~2026-03-11 9:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 8:16 [PATCH 0/2] drm/tidss: Two minor fixes Tomi Valkeinen
2026-03-11 8:16 ` [PATCH 1/2] drm/tidss: Drop extra drm_mode_config_reset() call Tomi Valkeinen
2026-03-11 9:09 ` Maxime Ripard
2026-03-11 21:12 ` Claude review: " Claude Code Review Bot
2026-03-11 8:16 ` [PATCH 2/2] drm/tidss: Fix missing drm_bridge_attach() call Tomi Valkeinen
2026-03-11 9:08 ` Maxime Ripard
2026-03-11 9:15 ` Tomi Valkeinen [this message]
2026-03-11 21:12 ` Claude review: " Claude Code Review Bot
2026-03-11 21:12 ` Claude review: drm/tidss: Two minor fixes Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70e2b0e4-0b27-4fad-8dc0-c28e10c959ad@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=a-bhatia1@ti.com \
--cc=airlied@gmail.com \
--cc=devarsht@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=jyri.sarha@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=sam@ravnborg.org \
--cc=simona@ffwll.ch \
--cc=stable@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox