From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66566EFCE41 for ; Wed, 4 Mar 2026 19:54:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C9FBF10EA63; Wed, 4 Mar 2026 19:54:51 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="sLuIKxvq"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A92310EA61 for ; Wed, 4 Mar 2026 19:54:50 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id CEFFC60053; Wed, 4 Mar 2026 19:54:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3C15C4CEF7; Wed, 4 Mar 2026 19:54:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772654089; bh=dkNS4T1xU2LpYvK8B+12e/GmRNn9DSoIVDixWCEFa4Q=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=sLuIKxvqdV7BfcpdmpIMJ9qBcb1tUSiMFS7M90rq3SLH6uZykkstxoouA1/77FB2v zgAR1UVoxxHzny3T6nPBir4VJ0ClHuHoQRWLcvr0ZX5mFk5wcT82Ubr3oNKCgOF8py uaI+qpdQAOj0XtOYnTTwKjFRl8Na4rI16OAZwsXRLGmFkGWetum81CwmUROiEhk+IJ 0kj8RPwBkBiS6ca48NEzFTE93oaQcm96WFQHcPu5Io8FkwvsT6J5Q7N/2LRPggQU2J +tu39N6gIeqtZXqkGYdzE6bk3ZPnE7MHhsV19ZHeeti975wLGZVFGs7paBUitIXQa/ aVoOjkGdrVeCg== Message-ID: <7595019c-2652-43e8-8597-4fc19d0019c7@kernel.org> Date: Wed, 4 Mar 2026 13:54:48 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1] accel/amdxdna: Fix major version check on NPU1 platform To: Lizhi Hou , ogabbay@kernel.org, quic_jhugo@quicinc.com, dri-devel@lists.freedesktop.org, maciej.falkowski@linux.intel.com Cc: linux-kernel@vger.kernel.org, max.zhen@amd.com, sonal.santan@amd.com References: <20260304195012.3616908-1-lizhi.hou@amd.com> Content-Language: en-US From: Mario Limonciello In-Reply-To: <20260304195012.3616908-1-lizhi.hou@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 3/4/26 1:50 PM, Lizhi Hou wrote: > Add the missing major number in npu1_fw_feature_table. > > Without the major version specified, the firmware feature check fails, > preventing new firmware commands from being enabled on the NPU1 > platform. > > With the correct major version populated, the driver properly detects > firmware support and enables the new command. > > Fixes: f1eac46fe5f7 ("accel/amdxdna: Update firmware version check for latest firmware") > Signed-off-by: Lizhi Hou Reviewed-by: Mario Limonciello (AMD) > --- > drivers/accel/amdxdna/npu1_regs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/accel/amdxdna/npu1_regs.c b/drivers/accel/amdxdna/npu1_regs.c > index 6e3d3ca69c04..1320e924e548 100644 > --- a/drivers/accel/amdxdna/npu1_regs.c > +++ b/drivers/accel/amdxdna/npu1_regs.c > @@ -67,7 +67,7 @@ const struct dpm_clk_freq npu1_dpm_clk_table[] = { > > static const struct aie2_fw_feature_tbl npu1_fw_feature_table[] = { > { .major = 5, .min_minor = 7 }, > - { .features = BIT_U64(AIE2_NPU_COMMAND), .min_minor = 8 }, > + { .features = BIT_U64(AIE2_NPU_COMMAND), .major = 5, .min_minor = 8 }, > { 0 } > }; >