From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5184FCC066 for ; Fri, 6 Mar 2026 19:50:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1CB1810E367; Fri, 6 Mar 2026 19:50:04 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.b="I/fEYVgb"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by gabe.freedesktop.org (Postfix) with ESMTPS id AC2EE10E367 for ; Fri, 6 Mar 2026 19:50:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=0qO9+QY++umfUmJGfFEVkr4r1pi/XXeRYwIJwqEAYoQ=; b=I/fEYVgbEogCcZuuWCTLQ5PMc7 i9pIR7xPwEF5nv2+y7U3q7WsPpRQjwGiiuK+pdSx07OScwZtxXyVTaPHPySpQrVF7RKdeUkaLZR6v 70jHUVL7P9AaJ2FHi9gWdaLZ0vIIgT5f07r3qQyHfcASOh5GRH1hNf3AYhdn0AQhQMw3sXp7EC3h5 8GQAKsgEvOPGrTIOmZBUkkMeLYWvlAlbrj9uBI3MFzMAyeGBHiI3noab4LMVhZHZdGm7zwWvtNwV8 YPsj2GbFXpbp8XiQSHx6VGipFCK/EIwMQRuFQsds9mQzDd2wa2DOurMLD/FWtZe5rEWSOPmGBb5aV NKatr0lw==; Received: from [50.53.43.113] (helo=[192.168.254.34]) by bombadil.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vybBK-00000004QLS-20Q4; Fri, 06 Mar 2026 19:49:54 +0000 Message-ID: <934ca1e6-dfee-411e-890a-083dcfc9f6b1@infradead.org> Date: Fri, 6 Mar 2026 11:49:53 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] serdev: add private data to serdev_device To: Markus Probst , Rob Herring , Greg Kroah-Hartman , Jiri Slaby , Miguel Ojeda , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Kari Argillander , "Rafael J. Wysocki" , Viresh Kumar , Boqun Feng , David Airlie , Simona Vetter Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-pm@vger.kernel.org, driver-core@lists.linux.dev, dri-devel@lists.freedesktop.org References: <20260306-rust_serdev-v2-0-e9b23b42b255@posteo.de> <20260306-rust_serdev-v2-2-e9b23b42b255@posteo.de> Content-Language: en-US From: Randy Dunlap In-Reply-To: <20260306-rust_serdev-v2-2-e9b23b42b255@posteo.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi-- On 3/6/26 11:35 AM, Markus Probst wrote: > Add private data to `struct serdev_device`, as it is required by the > rust abstraction added in the following commit > (rust: add basic serial device bus abstractions). > > Signed-off-by: Markus Probst > --- > include/linux/serdev.h | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/include/linux/serdev.h b/include/linux/serdev.h > index 5654c58eb73c..b591af23faf0 100644 > --- a/include/linux/serdev.h > +++ b/include/linux/serdev.h > @@ -33,12 +33,13 @@ struct serdev_device_ops { > > /** > * struct serdev_device - Basic representation of an serdev device > - * @dev: Driver model representation of the device. > - * @nr: Device number on serdev bus. > - * @ctrl: serdev controller managing this device. > - * @ops: Device operations. > - * @write_comp Completion used by serdev_device_write() internally > - * @write_lock Lock to serialize access when writing data > + * @dev: Driver model representation of the device. > + * @nr: Device number on serdev bus. > + * @ctrl: serdev controller managing this device. > + * @ops: Device operations. > + * @write_comp Completion used by serdev_device_write() internally > + * @write_lock Lock to serialize access when writing data > + * @private_data Private data for the device driver. > */ I don't quite get why each changed line has an extra tab added to it. ? Also, struct member names in kernel-doc should with a colon (':'), e.g., * @private_data: Private data for the device driver. Please correct that and the 2 lines above it also. And maybe test it to check for warnings. > struct serdev_device { > struct device dev; > @@ -47,6 +48,7 @@ struct serdev_device { > const struct serdev_device_ops *ops; > struct completion write_comp; > struct mutex write_lock; > + void *private_data; > }; > > static inline struct serdev_device *to_serdev_device(struct device *d) > thanks. -- ~Randy