From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2F38FCC065 for ; Fri, 6 Mar 2026 20:00:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6376810E3F4; Fri, 6 Mar 2026 20:00:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="iolXTHdg"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kGASjGUg"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB2F810E3F4 for ; Fri, 6 Mar 2026 20:00:38 +0000 (UTC) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626H1eFO238568 for ; Fri, 6 Mar 2026 20:00:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EiYJflmZS+8yawIrFdYuvTAy2GFP2luKLW8xrlAeVbY=; b=iolXTHdgTdjfeOyD ZD1CaIv9BfKoTip56GVafVAI2pWYzNyMQHZIxdjSM97kmc9JYu7asDOGkKqXqzrG D7A6EGYVAir86BPd0Fn5Q7raSMDJWV6EdF1O3A4hsajmSp3swGeGIcffEwCsft2n 6APlbK6ZVqMBM6cG+C7pk5Kyz9Fnh30veQDKzcgTG1qjkwGPUVXTxVRF9i+aiQDC 5JqWWkql44Xvn6k9P7HX6IFX1mIcJWe549u1vpndfMKiUifO7bDmCekNyqgD56xS T/BL//RE4mKtCpeGpFZaumI8aENVJTpmUafJihIs4uiLWyozER6TEuIr1RntP5wd ADUk7w== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqv98j147-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 20:00:37 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-2be21f89332so4665712eec.0 for ; Fri, 06 Mar 2026 12:00:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772827237; x=1773432037; darn=lists.freedesktop.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=EiYJflmZS+8yawIrFdYuvTAy2GFP2luKLW8xrlAeVbY=; b=kGASjGUgnAuaPafaM3HjCZooUGODU5MNaMN18kejP0118gBRsZyROo6EXxULNTELe7 bWLblDF20Ca18mMHgdLhn81gZMd/KUmb9+LWBkwVoNvkIQqT+6s4QWpPgUXpEoTzGkmL Mos40TImHodljl3lJ0BLEaqnFT6nwrELb1HkKIecFqfGzBgt4fYqBstUWKmybY9Xq3md Eo8UgQaX+c93gpomfXcfFeYZ66zUfAq0evZ7dKSZWHu8tShplawrfcz8hNvCeoLGWzYK 96hIIJLNtb8MnY7cIWA567tKsr02b+YI4TgES741mwlE+uRYWSHWkC5mqPQ6l0hPtOAP 1yTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772827237; x=1773432037; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EiYJflmZS+8yawIrFdYuvTAy2GFP2luKLW8xrlAeVbY=; b=u00XBf2uMGh5GT+wCR2pe4CNBuzHwgH33ULss0bpogrK1MoQxSx3pNgOJbRam+EzYL 3VmIdiQZsknp1fHbVGS31bYa5WhmtkbZ2rcMiF5EqP+PC1hYl0yRW0q3irhU/RovhoC5 CgBoar2s8S/6YQ1s3WSqPRFLnnPqLD07gy8fkUxLe7UDP4/fa0TB+Dh9oBcVVY2+SjCv GAOV+Bg57QjbNA0m0GvkK5c1JoDt391ItLD0yheFSXQ5/5xF5Jh2uQ5BlaCrvMfE1M1Q G60cWpX4s3lUCs6FHezMIM1y5hxUrXXxweHNwQtsTCIPeMso6px2yGPl5z+VVQAU57S7 lZiw== X-Forwarded-Encrypted: i=1; AJvYcCU+nKujXEBsNZg/i4G3tXJjkUpJyrv1BZ/ZS1xE2nHRpF1dW5RoUnqVsRPBCLbCSXpS0N092OQ3Cj0=@lists.freedesktop.org X-Gm-Message-State: AOJu0YySJKJz4aPRz5j8YMwp3Z+/xWI8GFE8wUBBFmIHxaz2lu0fgPt5 ORSWhU+5hRsrDHvmG0xzemnsBUQR9E25JPSkcY8WizZqR1+fjKJ+uBD90iTyJdXx6MbxB3waT13 Xi+o9Awh3jJsEfcr3NufYyoCS39u79LsxmaIeRxb4ozSXkSDWKRw9stQZXFs8pgYdro93eSA= X-Gm-Gg: ATEYQzzS/PwAg9YkoRJgz/b9OMHVesC3u5zdON2up++QjECaG/69d4eet0knbfVHwq2 +4kKA7IzGWpIrl39aYCsXIbG/RuSmul1tYOLnxkwlcI4FmMpNwTG20YS0+qdaZ1O4yvoqWaC8HP Qs4DIO/iS9fmpdW3OGByAkOY37PAh41sERiRKAo1EuHcrraGchbmrdJ/Z3ZyY55D+8r5Bz+EkGe dDC+Z8q0C40m+dMbkH/r93LR8gWpmhatV2kAYN/jKD3LRkOVYlfi9jH5mJ4dR5wgiYpyak0HK4n GnBe+foPzqpB2+2VnnbA94B6gw8PzVx/3cvyVaOtilMiR7QTxD80FNdA0bq/qfGsofVZRa1dPEO +htu067Tev/HWk4GNnyZ6oAfbWxqeEthF0CSB6yN4ekJIOtNCFUv8qqI= X-Received: by 2002:a05:7300:a887:b0:2ba:7069:686c with SMTP id 5a478bee46e88-2be4e01911emr1342872eec.17.1772827235502; Fri, 06 Mar 2026 12:00:35 -0800 (PST) X-Received: by 2002:a05:7300:a887:b0:2ba:7069:686c with SMTP id 5a478bee46e88-2be4e01911emr1342841eec.17.1772827234438; Fri, 06 Mar 2026 12:00:34 -0800 (PST) Received: from [192.168.86.165] ([76.176.48.107]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2be4f96aa3fsm1798784eec.24.2026.03.06.12.00.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Mar 2026 12:00:33 -0800 (PST) Message-ID: <973acaab-f2fa-4e2a-81ea-9d7fbebd1ca4@oss.qualcomm.com> Date: Fri, 6 Mar 2026 12:00:31 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/14] firmware: qcom: Add a generic PAS service From: Trilok Soni To: Sumit Garg , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robin.clark@oss.qualcomm.com, sean@poorly.run, akhilpo@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, jesszhan0024@gmail.com, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, vikash.garodia@oss.qualcomm.com, dikshita.agarwal@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, elder@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jjohnson@kernel.org, mathieu.poirier@linaro.org, mukesh.ojha@oss.qualcomm.com, pavan.kondeti@oss.qualcomm.com, jorge.ramirez@oss.qualcomm.com, tonyh@qti.qualcomm.com, vignesh.viswanathan@oss.qualcomm.com, srinivas.kandagatla@oss.qualcomm.com, amirreza.zarrabi@oss.qualcomm.com, jens.wiklander@linaro.org, op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com, skare@qti.qualcomm.com, Sumit Garg References: <20260306105027.290375-1-sumit.garg@kernel.org> <20260306105027.290375-3-sumit.garg@kernel.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: G8PHo8H_2Czs8-DcBvaX-mIsT-MUE1oE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE4OSBTYWx0ZWRfX2P7To6FrvkY1 ZxKeonS50EJMLoNq7xLB+pSTYornyeY4GwN/HQKK2rSbz6oXkN7at/XDxaUqTNTHq08GbXveros EKGZiTdOWpRpfxEV+hMEV/hXnKDmhr01VD4jfGdB/uvL4fqeNU9KDvga+clOJ5qVangQR1BRfsU bonIWwrQ3Wmi0hehPHWAEQNnaw02DwKsz8FARqIy6/ffiAkd18wQTLhrgfS0n1FEuk5fq8hqKES MzrtpxFrDw0kLgWfVmz6tbreF8YP0Wz62Hp/cs6KZ53sQ3YuHOzTIyZl8FW622+4Chyt7afswup hWfprC2SjrS9BQMTDItlmUtpvZ4/Jpnk1nIXmRdokQlkSaGgWrOgtPVZy4DPtNkIvnlEDNYOaVU l6nDM4N8OD0aQtOkLjxraQ9BSSB7YuqFOR1BIQFviwT+ZUIzvGrQG9YO5EjCywxTJoatEbQijnw 1LBr0e2kXtFg0VMWw3w== X-Authority-Analysis: v=2.4 cv=LbcxKzfi c=1 sm=1 tr=0 ts=69ab3265 cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=lsoD3MMNObdLvy1227ExmA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=Dui5BcQmNnZPeg-S7-oA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-ORIG-GUID: G8PHo8H_2Czs8-DcBvaX-mIsT-MUE1oE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 phishscore=0 adultscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060189 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 3/6/2026 11:47 AM, Trilok Soni wrote: >> diff --git a/drivers/firmware/qcom/qcom_pas.c b/drivers/firmware/qcom/qcom_pas.c >> new file mode 100644 >> index 000000000000..dc04ff1b6be0 >> --- /dev/null >> +++ b/drivers/firmware/qcom/qcom_pas.c >> @@ -0,0 +1,295 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include > are you sure you are using functionalities from these header files? > > I couldn't find slab.h usage quickly and also qcom_scm.h. Can you please confirm? I scrolled this patch too fast. I can see slab.h usage, but not sure about qcom_scm.h.