From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29AD9FCB619 for ; Fri, 6 Mar 2026 15:40:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8F6A010E315; Fri, 6 Mar 2026 15:40:12 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="W3mV1Ri4"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AChhY0Kr"; dkim-atps=neutral Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9D9DF10E315 for ; Fri, 6 Mar 2026 15:40:10 +0000 (UTC) Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626FT0mi3748105 for ; Fri, 6 Mar 2026 15:40:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wpH7c7MyE5oMPFius9rdgPXUx1Fgj3bT2b7iRgr/UYQ=; b=W3mV1Ri4C0Kr+8NY z48jIL/Lo5XCeSg8j7D2tMGiz+BixeS5WwAv+77z6Xtmt3pR8njgOFeAZk6HFWcR Oe0ZKlLov/jk7pnvYIKXwyH7MfJKbX0HuZ2GueDvAeOb6k9QaQmPqWmOKdAR59pn xQjhDSAc5fiGNCDUU7FsPAQh5WM+mj27lJKEClXszb72kWsUAoqrv4mtMbX+Efv/ m17Hp96OLfYiwK9tX1eSetYWiKUrZXXbobABTIeAuNZmIx4touC45LQCSaHPVUyp yRgXXe4KghrLLTAyBzGs+Hpwb/FHWFSoJ1U6gIwIWeqQFSbJtg7+w8atgfY78i8S x/xrPg== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqg09unf4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 15:40:10 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-2bdd327d970so4373486eec.1 for ; Fri, 06 Mar 2026 07:40:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772811609; x=1773416409; darn=lists.freedesktop.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wpH7c7MyE5oMPFius9rdgPXUx1Fgj3bT2b7iRgr/UYQ=; b=AChhY0KrwmjL+g2DFr3cAD1bKwc4+T7zOTwyn6uEidmN/Q1uzgr4zdbo9Eto6y/xz/ G+r3wrGq67w78fBlRuMObIAl/r09IHjn+6mEOlsPXHZJuueA42A1h+7/TlEhGzQ1OMWC DrAN8+KwRXITd2s3pZ0V+uPEqvjRl0RySIRm68mLv8Ym2gg1EGsSJjqyyLVZk6N1GJO7 BHyuFQZollK9fcSS2Uz6cVzmzhjeLC468KCC7f6HgZZdsE1LqdsJwPQ7zSFaYirAHTDl RTPuHBx24TICYqGiPExJnXQR/v/VBpE4IbfBWPsVbrn4mmqjoxQXseAXJgkyX1vRbzgF JYeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772811609; x=1773416409; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wpH7c7MyE5oMPFius9rdgPXUx1Fgj3bT2b7iRgr/UYQ=; b=i4mDGay2wJdLmHMIcqO4WtMCTZ9VjHWTpzWUj09BV1sWjGakkccAXdGg5HnbFhLJtM Mi6hRffwFNfHDWfWHumx/KvFsx9w7acic3dHYYdTAO3OUfr3iiPdkSg6DLQgorf36RY6 kO8tmSK9a3yumF8ZMs5Umnw3V5zEbp3kUN663bwFWW0+KKnrz7Io20QeuQEOLkeqjf3X 3jWSkM2iVzmxUXbeRN0c0L6GlM30TLWPzQ0ucAsmBLxxwr4WUloyKSFErD59JZ58KTmQ lsPMTVJTUnc8JCSTu6qznodL7EDycJivltiAfZxO6Ui7N+Qq5oLKqqvaT6tITH8yrxS8 P2lw== X-Forwarded-Encrypted: i=1; AJvYcCVQ1AGAizWG9T0BIcoR+91BnMoldFJ30dITQNY1tx2uJspFLgVTOQ/zo8hN6z+XOpxVP9HfSqj3OzQ=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yz96ycbvBOUVDRAVU6v+5+upzE9FnsIc1DSvKHD7qfeRtYns/Is VoZMdgWwVpPQCusJfK16CH9Wj37FIbfiiTGZUKp5387FvuglZAejAz9tbFcoYsY1UdqDFGaWYk9 +HTlmVzgJNRoLGjyORDwxIZKTUZjrSos2uIYwsCw8dD7S+26Z2I5cbQyp5xzaHDFZZi0KG8k= X-Gm-Gg: ATEYQzxrvWyEZI2MDix5ziTETnkb1TwjACT9SiyRq9uREebdANcSvlc5ygK+gIew/sr /tJCLlJJRB1qolPSwxz/ySjITk3AZJULfplYtN0wp+hbZ0DXXQ9DR1g12c1yE2Jxud9SfKwCIiA z9Gxvxkh1lTiAeqD4nDUyOEtsJnNuHaxzT2h0lv0AzoD9hRE8c09OoVfLlThSXkT26GCTZQUQyf u31cvuUVvFU/B7odmgfgrcrVEv2YgcR5ERXN2gRW3g7Xd3HpDSrWI+qFopfxIA5/MS8+MHnFvxd NsRuzUuAWPOqGK17+kwcHzrbzjt6p1FzHNMxnU4xdB4+kLyxgQEPeiTC7W8+A8rSsSSwj49rhcO DtHLwrPRVmyLAMJ/m/6gAOpyG1MSkbRc5/sr6l8Z9o3ubdkr8JgE4WZImnfSq/bZijPDMWZa4Qz s0AUv9uTvW5uPtig== X-Received: by 2002:a05:7300:ec07:b0:2a4:3593:ccba with SMTP id 5a478bee46e88-2be4e56f9f9mr928831eec.1.1772811609208; Fri, 06 Mar 2026 07:40:09 -0800 (PST) X-Received: by 2002:a05:7300:ec07:b0:2a4:3593:ccba with SMTP id 5a478bee46e88-2be4e56f9f9mr928768eec.1.1772811608557; Fri, 06 Mar 2026 07:40:08 -0800 (PST) Received: from [192.168.1.41] (c-24-130-122-79.hsd1.ca.comcast.net. [24.130.122.79]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2be4f94833bsm1356612eec.18.2026.03.06.07.40.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Mar 2026 07:40:08 -0800 (PST) Message-ID: <9741588f-e6a1-4749-970b-3ed814399a32@oss.qualcomm.com> Date: Fri, 6 Mar 2026 07:40:04 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/14] firmware: qcom: Add a generic PAS service To: Sumit Garg , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robin.clark@oss.qualcomm.com, sean@poorly.run, akhilpo@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, jesszhan0024@gmail.com, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, vikash.garodia@oss.qualcomm.com, dikshita.agarwal@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, elder@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jjohnson@kernel.org, mathieu.poirier@linaro.org, trilokkumar.soni@oss.qualcomm.com, mukesh.ojha@oss.qualcomm.com, pavan.kondeti@oss.qualcomm.com, jorge.ramirez@oss.qualcomm.com, tonyh@qti.qualcomm.com, vignesh.viswanathan@oss.qualcomm.com, srinivas.kandagatla@oss.qualcomm.com, amirreza.zarrabi@oss.qualcomm.com, jens.wiklander@linaro.org, op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com, skare@qti.qualcomm.com, Sumit Garg References: <20260306105027.290375-1-sumit.garg@kernel.org> <20260306105027.290375-3-sumit.garg@kernel.org> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20260306105027.290375-3-sumit.garg@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: JpU_qlcZYw58o1_3la6-rpbe4U9kMQv0 X-Authority-Analysis: v=2.4 cv=b/u/I9Gx c=1 sm=1 tr=0 ts=69aaf55a cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=Tg7Z00WN3eLgNEO9NLUKUQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=40pWYZonmZhD7659SdoA:9 a=QEXdDO2ut3YA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-GUID: JpU_qlcZYw58o1_3la6-rpbe4U9kMQv0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE0NiBTYWx0ZWRfX++IXmUP/3+Zn JilVoSym/BUgYf4KY2Cqdx2FmD+p4ExSOOurAi5W26vBHDASqEFSBJacMh01aOQf1vY/8zrPT4E IUDIdJ2jUUYjCmA0JejR3c+iwiujizkyau0CfwibSk4tjLlb3WaOt5xN69PIL+YN5eamY4r8fRr IwA84GQU/6cEhy7xD3GOyCAewigX5nZSEAFVsx7fPCcHoCh4ZcwK5xNYM4ketgDuVjTi5RI/5WG eu6CSiw2SsIJZUypddAm73Fwl9fkwfoQoTgi/HPEXSakPukXwM/3lLwEHFUWsM/5Qeim+lWAvtN qtp0yQ9d6kbA9ghmJV5doh01zkfPrca3WzPBc3R+o6Awwb086eLsN3Ivm+iiBa6DwI/W5GBLchr 9Or8XGNp+v10vMWW5GdgW+SduEj88kG4wO7TmBs5qEU34QEZYrhnfy8r/+CqsByuwgwdormpjBY YaK3R3v81JaZnDq13rw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_04,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 adultscore=0 clxscore=1011 phishscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060146 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 3/6/2026 2:50 AM, Sumit Garg wrote: > drivers/firmware/qcom/Kconfig | 8 + > drivers/firmware/qcom/Makefile | 1 + > drivers/firmware/qcom/qcom_pas.c | 295 +++++++++++++++++++++++++ kernel-doc is throwing some warnings in this file which I've listed below. kernel-doc is also throwing warnings in some of the other files touched by this series, but since those are presumably preexisting I didn't bother to mention them. Just want to avoid adding new warnings. > drivers/firmware/qcom/qcom_pas.h | 53 +++++ > include/linux/firmware/qcom/qcom_pas.h | 41 ++++ > 5 files changed, 398 insertions(+) > create mode 100644 drivers/firmware/qcom/qcom_pas.c > create mode 100644 drivers/firmware/qcom/qcom_pas.h > create mode 100644 include/linux/firmware/qcom/qcom_pas.h ... > +/** > + * qcom_pas_mem_setup() - Prepare the memory related to a given peripheral > + * for firmware loading > + * @pas_id: peripheral authentication service id > + * @addr: start address of memory area to prepare > + * @size: size of the memory area to prepare > + * > + * Returns 0 on success. kernel-doc complains: Warning: drivers/firmware/qcom/qcom_pas.c:103 No description found for return value of 'qcom_pas_mem_setup' should use the kernel-doc Return: tag * Return: 0 on success (Returns: is also accepted although not documented) > + */ ... > +/** > + * qcom_scm_pas_auth_and_reset() - Authenticate the given peripheral firmware > + * and reset the remote processor > + * @pas_id: peripheral authentication service id > + * > + * Return 0 on success. hmmm, kernel-doc didn't complain about this one so the script must accept 'Return' without the ":" (but not 'Returns' without the ":"). Suggest changing to Return: to be conformant with the actual documentation: > + */ > +int qcom_pas_auth_and_reset(u32 pas_id) > +{ > + if (ops_ptr) > + return ops_ptr->auth_and_reset(ops_ptr->dev, pas_id); > + > + return -ENODEV; > +} > +EXPORT_SYMBOL_GPL(qcom_pas_auth_and_reset); ... > +/** > + * qcom_pas_set_remote_state() - Set the remote processor state > + * @state: peripheral state > + * @pas_id: peripheral authentication service id > + * > + * Returns 0 on success. Warning: drivers/firmware/qcom/qcom_pas.c:217 No description found for return value of 'qcom_pas_set_remote_state' > + */ ... > +/** > + * qcom_pas_shutdown() - Shut down the remote processor > + * @pas_id: peripheral authentication service id > + * > + * Returns 0 on success. Warning: drivers/firmware/qcom/qcom_pas.c:232 No description found for return value of 'qcom_pas_shutdown' > + */ ... > +/** > + * qcom_pas_supported() - Check if the peripheral authentication service is > + * available for the given peripheral > + * @pas_id: peripheral authentication service id > + * > + * Returns true if PAS is supported for this peripheral, otherwise false. Warning: drivers/firmware/qcom/qcom_pas.c:248 No description found for return value of 'qcom_pas_supported' > + */ ... > +/** > + * qcom_pas_is_available() - Check for PAS service > + * > + * Returns true on success. Warning: drivers/firmware/qcom/qcom_pas.c:262 No description found for return value of 'qcom_pas_is_available' > + */