From: Neil Armstrong <neil.armstrong@linaro.org>
To: Arnd Bergmann <arnd@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Pengyu Luo <mitltlatltl@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Jessica Zhang <jesszhan0024@gmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Svyatoslav Ryhel <clamor95@gmail.com>,
David Heidelberg <david@ixit.cz>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/panel: hx83121a: select DRM_DISPLAY_DSC_HELPER
Date: Mon, 13 Apr 2026 10:02:56 +0200 [thread overview]
Message-ID: <97afc59f-0552-4faa-913f-592c09c31141@linaro.org> (raw)
In-Reply-To: <20260413071043.3829868-1-arnd@kernel.org>
On 4/13/26 09:10, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Like a number of other panel drivers, this newly merged driver
> needs DRM_DISPLAY_DSC_HELPER to be enabled:
>
> arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-himax-hx83121a.o: in function `himax_prepare':
> panel-himax-hx83121a.c:(.text+0x1024): undefined reference to `drm_dsc_pps_payload_pack'
>
> Fixes: a7c61963b727 ("drm/panel: Add Himax HX83121A panel driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/panel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index cc8c8a066bb9..ce6098c0343a 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -208,6 +208,7 @@ config DRM_PANEL_HIMAX_HX83121A
> depends on OF
> depends on DRM_MIPI_DSI
> depends on BACKLIGHT_CLASS_DEVICE
> + select DRM_DISPLAY_DSC_HELPER
> select DRM_KMS_HELPER
> help
> Say Y here if you want to enable support for Himax HX83121A-based
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks,
Neil
next prev parent reply other threads:[~2026-04-13 8:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 7:10 [PATCH] drm/panel: hx83121a: select DRM_DISPLAY_DSC_HELPER Arnd Bergmann
2026-04-13 8:02 ` Neil Armstrong [this message]
2026-04-13 8:17 ` David Heidelberg
2026-04-13 8:44 ` Claude review: " Claude Code Review Bot
2026-04-13 8:44 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97afc59f-0552-4faa-913f-592c09c31141@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=clamor95@gmail.com \
--cc=david@ixit.cz \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mitltlatltl@gmail.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox