From: Lizhi Hou <lizhi.hou@amd.com>
To: Mario Limonciello <superm1@kernel.org>, <ogabbay@kernel.org>,
<quic_jhugo@quicinc.com>, <dri-devel@lists.freedesktop.org>,
<maciej.falkowski@linux.intel.com>
Cc: <linux-kernel@vger.kernel.org>, <max.zhen@amd.com>,
<sonal.santan@amd.com>
Subject: Re: [PATCH V1] accel/amdxdna: Fix major version check on NPU1 platform
Date: Wed, 4 Mar 2026 12:09:02 -0800 [thread overview]
Message-ID: <9a8b3fef-3440-e316-8dfa-9d7b37fc38f2@amd.com> (raw)
In-Reply-To: <7595019c-2652-43e8-8597-4fc19d0019c7@kernel.org>
Applied to drm-misc-fixes
On 3/4/26 11:54, Mario Limonciello wrote:
> On 3/4/26 1:50 PM, Lizhi Hou wrote:
>> Add the missing major number in npu1_fw_feature_table.
>>
>> Without the major version specified, the firmware feature check fails,
>> preventing new firmware commands from being enabled on the NPU1
>> platform.
>>
>> With the correct major version populated, the driver properly detects
>> firmware support and enables the new command.
>>
>> Fixes: f1eac46fe5f7 ("accel/amdxdna: Update firmware version check
>> for latest firmware")
>> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
> Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
>> ---
>> drivers/accel/amdxdna/npu1_regs.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/accel/amdxdna/npu1_regs.c
>> b/drivers/accel/amdxdna/npu1_regs.c
>> index 6e3d3ca69c04..1320e924e548 100644
>> --- a/drivers/accel/amdxdna/npu1_regs.c
>> +++ b/drivers/accel/amdxdna/npu1_regs.c
>> @@ -67,7 +67,7 @@ const struct dpm_clk_freq npu1_dpm_clk_table[] = {
>> static const struct aie2_fw_feature_tbl npu1_fw_feature_table[] = {
>> { .major = 5, .min_minor = 7 },
>> - { .features = BIT_U64(AIE2_NPU_COMMAND), .min_minor = 8 },
>> + { .features = BIT_U64(AIE2_NPU_COMMAND), .major = 5, .min_minor
>> = 8 },
>> { 0 }
>> };
>
next prev parent reply other threads:[~2026-03-04 20:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 19:50 [PATCH V1] accel/amdxdna: Fix major version check on NPU1 platform Lizhi Hou
2026-03-04 19:54 ` Mario Limonciello
2026-03-04 20:09 ` Lizhi Hou [this message]
2026-03-05 3:17 ` Claude review: " Claude Code Review Bot
2026-03-05 3:17 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8b3fef-3440-e316-8dfa-9d7b37fc38f2@amd.com \
--to=lizhi.hou@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.falkowski@linux.intel.com \
--cc=max.zhen@amd.com \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
--cc=sonal.santan@amd.com \
--cc=superm1@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox