[PATCH V1] accel/amdxdna: Fix major version check on NPU1 platform

[PATCH V1] accel/amdxdna: Fix major version check on NPU1 platform

[Lizhi Hou]

Add the missing major number in npu1_fw_feature_table.

Without the major version specified, the firmware feature check fails,
preventing new firmware commands from being enabled on the NPU1
platform.

With the correct major version populated, the driver properly detects
firmware support and enables the new command.

Fixes: f1eac46fe5f7 ("accel/amdxdna: Update firmware version check for latest firmware")
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
---
 drivers/accel/amdxdna/npu1_regs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/accel/amdxdna/npu1_regs.c b/drivers/accel/amdxdna/npu1_regs.c
index 6e3d3ca69c04..1320e924e548 100644
--- a/drivers/accel/amdxdna/npu1_regs.c
+++ b/drivers/accel/amdxdna/npu1_regs.c
@@ -67,7 +67,7 @@ const struct dpm_clk_freq npu1_dpm_clk_table[] = {
 
 static const struct aie2_fw_feature_tbl npu1_fw_feature_table[] = {
 	{ .major = 5, .min_minor = 7 },
-	{ .features = BIT_U64(AIE2_NPU_COMMAND), .min_minor = 8 },
+	{ .features = BIT_U64(AIE2_NPU_COMMAND), .major = 5, .min_minor = 8 },
 	{ 0 }
 };
 
-- 
2.34.1

Re: [PATCH V1] accel/amdxdna: Fix major version check on NPU1 platform

[Mario Limonciello]

On 3/4/26 1:50 PM, Lizhi Hou wrote:
> Add the missing major number in npu1_fw_feature_table.
> 
> Without the major version specified, the firmware feature check fails,
> preventing new firmware commands from being enabled on the NPU1
> platform.
> 
> With the correct major version populated, the driver properly detects
> firmware support and enables the new command.
> 
> Fixes: f1eac46fe5f7 ("accel/amdxdna: Update firmware version check for latest firmware")
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
> ---
>   drivers/accel/amdxdna/npu1_regs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/accel/amdxdna/npu1_regs.c b/drivers/accel/amdxdna/npu1_regs.c
> index 6e3d3ca69c04..1320e924e548 100644
> --- a/drivers/accel/amdxdna/npu1_regs.c
> +++ b/drivers/accel/amdxdna/npu1_regs.c
> @@ -67,7 +67,7 @@ const struct dpm_clk_freq npu1_dpm_clk_table[] = {
>   
>   static const struct aie2_fw_feature_tbl npu1_fw_feature_table[] = {
>   	{ .major = 5, .min_minor = 7 },
> -	{ .features = BIT_U64(AIE2_NPU_COMMAND), .min_minor = 8 },
> +	{ .features = BIT_U64(AIE2_NPU_COMMAND), .major = 5, .min_minor = 8 },
>   	{ 0 }
>   };
>   

Re: [PATCH V1] accel/amdxdna: Fix major version check on NPU1 platform

[Lizhi Hou]

Applied to drm-misc-fixes

On 3/4/26 11:54, Mario Limonciello wrote:
> On 3/4/26 1:50 PM, Lizhi Hou wrote:
>> Add the missing major number in npu1_fw_feature_table.
>>
>> Without the major version specified, the firmware feature check fails,
>> preventing new firmware commands from being enabled on the NPU1
>> platform.
>>
>> With the correct major version populated, the driver properly detects
>> firmware support and enables the new command.
>>
>> Fixes: f1eac46fe5f7 ("accel/amdxdna: Update firmware version check 
>> for latest firmware")
>> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
> Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
>> ---
>>   drivers/accel/amdxdna/npu1_regs.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/accel/amdxdna/npu1_regs.c 
>> b/drivers/accel/amdxdna/npu1_regs.c
>> index 6e3d3ca69c04..1320e924e548 100644
>> --- a/drivers/accel/amdxdna/npu1_regs.c
>> +++ b/drivers/accel/amdxdna/npu1_regs.c
>> @@ -67,7 +67,7 @@ const struct dpm_clk_freq npu1_dpm_clk_table[] = {
>>     static const struct aie2_fw_feature_tbl npu1_fw_feature_table[] = {
>>       { .major = 5, .min_minor = 7 },
>> -    { .features = BIT_U64(AIE2_NPU_COMMAND), .min_minor = 8 },
>> +    { .features = BIT_U64(AIE2_NPU_COMMAND), .major = 5, .min_minor 
>> = 8 },
>>       { 0 }
>>   };
>

Claude review: accel/amdxdna: Fix major version check on NPU1 platform

[Claude Code Review Bot]

Patch Review

**The bug:** In `npu1_fw_feature_table[]`, the second entry is missing `.major = 5`:

```c
static const struct aie2_fw_feature_tbl npu1_fw_feature_table[] = {
	{ .major = 5, .min_minor = 7 },
	{ .features = BIT_U64(AIE2_NPU_COMMAND), .min_minor = 8 },  // .major defaults to 0
	{ 0 }
};
```

The iteration loop in `aie2_pci.c:67` uses `feature->major` as the loop continuation condition:
```c
for (feature = ndev->priv->fw_feature_tbl; feature->major; feature++) {
```

So the missing `.major` causes the entry to be treated as the sentinel/terminator (`{ 0 }`), meaning the `AIE2_NPU_COMMAND` feature is never detected on NPU1 platforms.

**The fix** adds `.major = 5` to match the first entry and be consistent with how `npu4_fw_feature_table` (in `npu4_regs.c:93`) correctly specifies `.major` on every entry:
```c
{ .features = BIT_U64(AIE2_NPU_COMMAND), .major = 6, .min_minor = 15 },
```

**No issues found.** The fix is a one-line data correction, straightforward and obviously correct.

Reviewed-by worthy.

---
Generated by Claude Code Patch Reviewer

Claude review: accel/amdxdna: Fix major version check on NPU1 platform

[Claude Code Review Bot]

Overall Series Review

Subject: accel/amdxdna: Fix major version check on NPU1 platform
Author: Lizhi Hou <lizhi.hou@amd.com>
Patches: 3
Reviewed: 2026-03-05T13:17:56.106918

---

This is a single-patch fix for a clear and obvious bug in the `accel/amdxdna` driver. The fix is correct, minimal, and well-justified. The commit message clearly explains the problem and the fix. The `Fixes:` tag correctly identifies the commit that introduced the regression.

**Verdict: This patch looks good and should be accepted.**

---
Generated by Claude Code Patch Reviewer