From: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
To: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
lijo.lazar@amd.com, Eric Huang <jinhuieric.huang@amd.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v6] drm/amdgpu: replace PASID IDR with XArray
Date: Tue, 31 Mar 2026 19:30:40 +0500 [thread overview]
Message-ID: <CABXGCsNcutmHieQR7bfw3c3+8ZhLVRHsgtA+EqbCG7xtEBn4Bw@mail.gmail.com> (raw)
In-Reply-To: <2fb67e0c-c7a2-46d6-af24-d67f704cac6d@amd.com>
On Tue, Mar 31, 2026 at 5:28 PM Christian König
<christian.koenig@amd.com> wrote:
>
> That should be unecessary. We already replaced GFP_KERNEL with GFP_ATOMIC in Alex fixes pull.
>
> I would turn that around, e.g. if (r < 0) return r;
>
> Apart from that looks good to me.
Hi Christian,
Thanks for the review. I've sent v7 rebased on amd-staging-drm-next
(on top of dccd79bb1c7f) with the inverted error check as you
suggested.
The Fixes: tag now points to e6d765de3d6b which introduced the
plain spin_lock() for the PASID IDR. The sleeping-under-spinlock
is already fixed by dccd79bb1c7f, but the IRQ safety issue remains —
amdgpu_pasid_free() is reachable from hardirq via the fence callback
path while the lock is taken without irqsave in process context.
I hit this lockdep WARNING on an RX 7900 XTX when exiting a Vulkan
game under Proton. The xarray conversion with XA_FLAGS_LOCK_IRQ
fixes this.
https://lore.kernel.org/all/20260331142127.52796-1-mikhail.v.gavrilov@gmail.com/
--
Thanks,
Mike Gavrilov.
next prev parent reply other threads:[~2026-03-31 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 11:17 [PATCH v6] drm/amdgpu: replace PASID IDR with XArray Mikhail Gavrilov
2026-03-31 12:28 ` Christian König
2026-03-31 14:30 ` Mikhail Gavrilov [this message]
2026-03-31 21:48 ` Claude review: " Claude Code Review Bot
2026-03-31 21:48 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABXGCsNcutmHieQR7bfw3c3+8ZhLVRHsgtA+EqbCG7xtEBn4Bw@mail.gmail.com \
--to=mikhail.v.gavrilov@gmail.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jinhuieric.huang@amd.com \
--cc=lijo.lazar@amd.com \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox