[PATCH v1] dma-buf: Include ioctl.h in UAPI header

[PATCH v1] dma-buf: Include ioctl.h in UAPI header

[Isaac J. Manjarres]

include/uapi/linux/dma-buf.h uses several macros from ioctl.h to define
its ioctl commands. However, it does not include ioctl.h itself. So,
if userspace source code tries to include the dma-buf.h file without
including ioctl.h, it can result in build failures.

Therefore, include ioctl.h in the dma-buf UAPI header.

Signed-off-by: Isaac J. Manjarres <isaacmanjarres@google.com>
---
 include/uapi/linux/dma-buf.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/uapi/linux/dma-buf.h b/include/uapi/linux/dma-buf.h
index 5a6fda66d9ad..e827c9d20c5d 100644
--- a/include/uapi/linux/dma-buf.h
+++ b/include/uapi/linux/dma-buf.h
@@ -20,6 +20,7 @@
 #ifndef _DMA_BUF_UAPI_H_
 #define _DMA_BUF_UAPI_H_
 
+#include <linux/ioctl.h>
 #include <linux/types.h>
 
 /**
-- 
2.53.0.473.g4a7958ca14-goog

Re: [PATCH v1] dma-buf: Include ioctl.h in UAPI header

[T.J. Mercier]

On Mon, Mar 2, 2026 at 4:23 PM Isaac J. Manjarres
<isaacmanjarres@google.com> wrote:
>
> include/uapi/linux/dma-buf.h uses several macros from ioctl.h to define
> its ioctl commands. However, it does not include ioctl.h itself. So,
> if userspace source code tries to include the dma-buf.h file without
> including ioctl.h, it can result in build failures.
>
> Therefore, include ioctl.h in the dma-buf UAPI header.
>
> Signed-off-by: Isaac J. Manjarres <isaacmanjarres@google.com>

Reviewed-by: T.J. Mercier <tjmercier@google.com>

Claude review: dma-buf: Include ioctl.h in UAPI header

[Claude Code Review Bot]

Overall Series Review

Subject: dma-buf: Include ioctl.h in UAPI header
Author: "Isaac J. Manjarres" <isaacmanjarres@google.com>
Patches: 2
Reviewed: 2026-03-03T12:44:01.978349

---

This is a single, straightforward patch that adds a missing `#include <linux/ioctl.h>` to the `include/uapi/linux/dma-buf.h` UAPI header. The fix is correct and well-motivated. The header uses `_IOW()` and `_IOWR()` macros (lines 171, 176-180 in the current tree) which are defined through `<linux/ioctl.h>`, but never includes that header. This means userspace programs that include `<linux/dma-buf.h>` without separately including `<linux/ioctl.h>` will get build failures due to undefined macros.

UAPI headers should be self-contained so that userspace can include them independently. This is a well-established kernel convention. The fix is minimal, correct, and low-risk.

**Verdict: Looks good. No issues found.**

---
Generated by Claude Code Patch Reviewer

Claude review: dma-buf: Include ioctl.h in UAPI header

[Claude Code Review Bot]

Patch Review

**Correctness:** The patch is correct. The file uses `_IOW` and `_IOWR` macros:

```c
#define DMA_BUF_IOCTL_SYNC	_IOW(DMA_BUF_BASE, 0, struct dma_buf_sync)
#define DMA_BUF_SET_NAME	_IOW(DMA_BUF_BASE, 1, const char *)
#define DMA_BUF_SET_NAME_A	_IOW(DMA_BUF_BASE, 1, __u32)
#define DMA_BUF_SET_NAME_B	_IOW(DMA_BUF_BASE, 1, __u64)
#define DMA_BUF_IOCTL_EXPORT_SYNC_FILE	_IOWR(DMA_BUF_BASE, 2, struct dma_buf_export_sync_file)
#define DMA_BUF_IOCTL_IMPORT_SYNC_FILE	_IOW(DMA_BUF_BASE, 3, struct dma_buf_import_sync_file)
```

These macros are provided by `<linux/ioctl.h>`, which is not currently included.

**Placement:** The new include is added before the existing `#include <linux/types.h>`, maintaining alphabetical order. Good.

```c
+#include <linux/ioctl.h>
 #include <linux/types.h>
```

**Commit message:** Clear and concise. Accurately describes the problem and the fix.

**Risk:** Essentially zero. Adding a missing include to a UAPI header cannot break existing users (they must have been including `<linux/ioctl.h>` themselves, either directly or transitively). It only fixes the case where they weren't.

**Reviewed-by worthy:** Yes. No concerns.

---
Generated by Claude Code Patch Reviewer