From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0355BEF8FFA for ; Wed, 4 Mar 2026 15:57:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4F85C10EA0E; Wed, 4 Mar 2026 15:57:48 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="WolelZa6"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SSVAFGOa"; dkim-atps=neutral Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id AEB1E10EA45 for ; Wed, 4 Mar 2026 15:57:47 +0000 (UTC) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 624E0xUJ030127 for ; Wed, 4 Mar 2026 15:57:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:reply-to:subject:to; s= qcppdkim1; bh=Kv3iTQKYCHQ+PN2YjozMkKoEokJkDuu8sR+APkn97Tc=; b=Wo lelZa6NHmrLWe/wDpEDNupeRnANERRGJDc/H2YoEXAY8R1ORt8z/9dyasJf1rWCA VR/xIh0ZVm5el/KDv/ugOuq6cD8iCupthIsnPqpYhbv5OWTGvqYzyJ1pW8XDSNZr LgRbJQPFK+6fXQUm2HSk2Y7XPdujash8aHzeF087rc9bkODdrz2J6BLUar0oPfFp K3EPO7bZV2YDarbsCVGO7NAnhFg+e9mzV27CryJUwSZUbBBtSniA5hHUfQnQ7hTx eWyRc1+2gbJgAqu2T3bbZvUf2fqFVUKE4kxwYe5jcGw2w/ebfKYyDTaPKHiNPKw9 A1WDOyzw6NzGretySFyQ== Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cpp4fgdnj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Mar 2026 15:57:47 +0000 (GMT) Received: by mail-oo1-f71.google.com with SMTP id 006d021491bc7-679c6ef1538so119871878eaf.3 for ; Wed, 04 Mar 2026 07:57:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1772639866; cv=none; d=google.com; s=arc-20240605; b=bc3fa5jtmc05gNOzQwHyQsWDUobJam8IlgPARrOF3B9ukvjDc7fvxkKrb75jye7e7s U53hRCUXh7WBzh6i7Hshakx6iFlZe9GwPYfYR0BExO6kfmw60VeRQQ/YQGC7KtlYb67L o1EFNK5lm6nivrkxouoU4r4VzKU9bXaXnvcS7hU7t/Br9gfsjXDdC9pQfSoyZDQ3U5Gd rZG5ipYm+VVI1tsGboAFTuR+ifTyXC0alhU76xfsbGk2mV7b8/bOjkXd13esV/9sjBr/ RLm3knwn13m3ISLNah5KUNOrNMIm54h59GwpzULL3FXrrQ2N4RFqvzTOrUIkbvommJpo oFig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :reply-to:in-reply-to:references:mime-version:dkim-signature; bh=Kv3iTQKYCHQ+PN2YjozMkKoEokJkDuu8sR+APkn97Tc=; fh=Z3zk/9EXtjVButUE4lhuYbOqzG1pm+nKw2tVH0ZsbZ0=; b=C5o8dE42qBC2v6jhBXFrPjWK3lXWenm18qOaZo2i3gQPlIWWTcGuv5DZa89bWG+QZo 4ShK7ex4DqHBDFlq5wtqgLLdEqFYBTkcKr6oM2y7t1c7+vrJe4qmJxodlj9EF6q4k/u/ IqgA3stM1/1qsNuZSjLhU7m/F+Hdn2HHGu0am4LzxWNhLx2o1TL2UgfNRopiY14AIFLK SgtZjrs7VUY2yURWs0PBzWfAsvVRolHz2TgVEMR9q5F5dA80wxwKNpOCgNe+xey283zT wVqf9QgFKqk/r36WSB2GLV6zNA44S+Hv+zqK4TPKisW44i8UPSnWBIJ1chmM4juf680a P8CA==; darn=lists.freedesktop.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772639866; x=1773244666; darn=lists.freedesktop.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :reply-to:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=Kv3iTQKYCHQ+PN2YjozMkKoEokJkDuu8sR+APkn97Tc=; b=SSVAFGOagAJcTnXxAaLW2G5VSgtXYyNr1kasra2YDOmbC7jZas9IGsUMmqRt4bNpTo 8nh5fHGS/gd69sbtZ5DICBW9zwcdJlMc/XX8gt8BkAF2nYpOC2Ajx/1LsSeU7NuDG5+9 qoObHx7lWdHx57KZui0Dcg0opvlC+NyUmtKWt7KCmt9rGaGiHxKS9FNvh9QFjFpTvfNg EOvWjUD7gEsVwaECidBqIpukS7VOr/zm32sRB+cimDDWpPrKyug57QhxfNl4RGR+hNYG 6T4C1Rr69myD4f6cwSZe7s2qLiqI8KYAYm/rUKtvyBPAGr1yrVUruJh9u0sV+kkL+YaE Yh3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772639866; x=1773244666; h=content-transfer-encoding:cc:to:subject:message-id:date:from :reply-to:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Kv3iTQKYCHQ+PN2YjozMkKoEokJkDuu8sR+APkn97Tc=; b=tS8zT7tfYCqtAGoADe2I4Tig6so9fXFK8hMGet+DPWPNDnd4IrcPwUVW2jJAjL2vHL lisigp2FXOqea7aIsZeYdiKt73uo1BaC5acf2quibIJKLI2Fqh3F2k1wQhuobbmvM9Ds mndgSa2fzljDH1/JnBo5rLSj3NzDxGUPDU/WY2uwPewAykMksU2Gwr05ihqrYyQzkHIx SZ2MWDgF98STgZ2FRAWA5CoIKPYBazu+EAe2iMd9J2c8D8gTt6RynXwPqnzJ46COTJwu F5085vHD+Nk1+gnbiB+4WC30mEN0eIBREKK2ra/eNrf18J1938DSQ+XHO0++BW99ym6/ L1eg== X-Forwarded-Encrypted: i=1; AJvYcCV4gVIq7s2ZlBNNxJpG62b794orzVMO8aLRN/DT46FQC8VtJCkljZqDil+XOIzZENZyZwNaG6+kC5s=@lists.freedesktop.org X-Gm-Message-State: AOJu0YyU12OJD/TTYze/ZfO786uKRt4hJHmNtw1zKb2WKyL32oIVkYlW eyU4u+DCiRmsp2R5hZeE04chT5+KrcuCkoREZjBERmkpgADG+pUatsQAus766wUP5vPRMUbSXGE OlMkOpyT2wA4+X8x98K6J0YDMUXYt2xiRUZnwRy0hbsD0Ky7TrcLPQ8k7XtltS8l59BhCKD/cF5 l3LkvOjJaR7TnjBzr0ei6qZ9lHwo3lSUfs70HVHmEZp/D4iw== X-Gm-Gg: ATEYQzzCXPVBO0GpXJIwi7OZ+eeex3wkHPGeF8TDCf1UGd3vghYj/F0R8v4uzzGS2i7 XS49vbS5iQ9xLibssX7uor7FzjkUJ956iy8u6Lrlbi2LAoARL4GJHjv9xQNHlGFPLCdHSgi5y++ 318tZSCC47Y7OuKK/NUBP9t7HBSl4p/WwZyYTXsGYj3VxsWQGCZw1UPIMvkKSfb960M/tfBjn8L KccYIQ4DxcMDy4W35FlZ7WF54iKvUAuNHLmNA== X-Received: by 2002:a05:6820:4dc8:b0:662:f61e:75a8 with SMTP id 006d021491bc7-67b1e900656mr1373734eaf.65.1772639866322; Wed, 04 Mar 2026 07:57:46 -0800 (PST) X-Received: by 2002:a05:6820:4dc8:b0:662:f61e:75a8 with SMTP id 006d021491bc7-67b1e900656mr1373716eaf.65.1772639865944; Wed, 04 Mar 2026 07:57:45 -0800 (PST) MIME-Version: 1.0 References: <20260304-msm-restore-ioctls-v1-1-b28f9231fcd2@oss.qualcomm.com> In-Reply-To: <20260304-msm-restore-ioctls-v1-1-b28f9231fcd2@oss.qualcomm.com> From: Rob Clark Date: Wed, 4 Mar 2026 07:57:34 -0800 X-Gm-Features: AaiRm52LqeFp_ZlAVTlgSy7x2OER3B-eQnSoEBsoKCq6ARMGFzZBztG4DTaj6iM Message-ID: Subject: Re: [PATCH] drm/msm: restore GEM-related IOCTLs for KMS devices To: Dmitry Baryshkov Cc: Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: gijhff4T08Ke-OqBRICLutEcpYGmEOzV X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA0MDEyOSBTYWx0ZWRfX9Od+14rpG0Xc OU0K643YHl/nijulO/P/2rO+/mEx0SaQG9Y/kc/+gpxHBSH+C8Y0++IaqdSNvcfVyLgzCAchWu6 3NTcJv0u7DwZXPSUqKyZHYf0h5xgQ9/CJayDQQ9aoX8T3F+mF0B5gQAGoNe+wfD1AEjrwEAOdi/ +ykLEO1oKSMwKy+rMADIdWcZ4zoEKjunPcZMSkUp5seVnwyWrDAEYduFwOO36O2YY0ZtfzzrxS+ p1IWyxI8XayXorRGqtU7xpBK0mH9gHEdoX2V8XDDO+yEtkUsUhnqnUjv2OgtElBWSOab/oYB+0q oYMENqaPO9ZqdZqTqvbynR3b6vvlfvHadzqhAacItUviK6chluNiQeVTGvw9dHJ/crS19nekYah 4EUJgdell74OZSBxQVgX/i6akD5oLqsxwePyr04Kl4+Y9H5oZ1f9G85gUD6vxwgZOBp5J8xqZ0x VpfR/TmiW9IIfRU2JYg== X-Authority-Analysis: v=2.4 cv=CdMFJbrl c=1 sm=1 tr=0 ts=69a8567b cx=c_pps a=V4L7fE8DliODT/OoDI2WOg==:117 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=Ad23g6fO8UNhwhZctZsA:9 a=QEXdDO2ut3YA:10 a=WZGXeFmKUf7gPmL3hEjn:22 X-Proofpoint-GUID: gijhff4T08Ke-OqBRICLutEcpYGmEOzV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-04_07,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 adultscore=0 impostorscore=0 bulkscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603040129 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rob.clark@oss.qualcomm.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Mar 4, 2026 at 5:34=E2=80=AFAM Dmitry Baryshkov wrote: > > The MSM GBM backend uses MSM_GEM_NEW to allocate GEM buffers from the > KMS driver, imports them into the GPU driver (msm or kgsl) and then > uses them for rendering / blending. Commit 98f11fd1cf92 ("drm/msm: Take > the ioctls away from the KMS-only driver") dropped all IOCTLs from the > MSM KMS devices, pointing out the need to use dumb buffers, however dumb > buffers should not be used by the GPU for rendering. Restore GEM-related > IOCTLs for the KMS devices. We shouldn't be exposing DRIVER_RENDER on KMS-only nodes. If msm gbm is allocating from a primary node, that is problematic, since there is no guarantee that anything but the compositor has access to the primary node. BR, -R > > Fixes: 98f11fd1cf92 ("drm/msm: Take the ioctls away from the KMS-only dri= ver") > Signed-off-by: Dmitry Baryshkov > --- > Note, here I assume that dumb buffers generally should not be used for > rendering. That doesn't seem to be complete truth as Mesa kmsro on MSM > devices uses DRM_IOCTL_MODE_CREATE_DUMB to create buffers for resources. > --- > drivers/gpu/drm/msm/msm_drv.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.= c > index ed2a61c66ac9..f82c9a36a166 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -799,6 +799,14 @@ static const struct drm_ioctl_desc msm_ioctls[] =3D = { > DRM_IOCTL_DEF_DRV(MSM_VM_BIND, msm_ioctl_vm_bind, DRM_R= ENDER_ALLOW), > }; > > +static const struct drm_ioctl_desc msm_kms_ioctls[] =3D { > + DRM_IOCTL_DEF_DRV(MSM_GEM_NEW, msm_ioctl_gem_new, DRM_R= ENDER_ALLOW), > + DRM_IOCTL_DEF_DRV(MSM_GEM_INFO, msm_ioctl_gem_info, DRM_R= ENDER_ALLOW), > + DRM_IOCTL_DEF_DRV(MSM_GEM_CPU_PREP, msm_ioctl_gem_cpu_prep, DRM_R= ENDER_ALLOW), > + DRM_IOCTL_DEF_DRV(MSM_GEM_CPU_FINI, msm_ioctl_gem_cpu_fini, DRM_R= ENDER_ALLOW), > + DRM_IOCTL_DEF_DRV(MSM_GEM_MADVISE, msm_ioctl_gem_madvise, DRM_R= ENDER_ALLOW), > +}; > + > static void msm_show_fdinfo(struct drm_printer *p, struct drm_file *file= ) > { > struct drm_device *dev =3D file->minor->dev; > @@ -868,6 +876,8 @@ static const struct drm_driver msm_kms_driver =3D { > #endif > MSM_FBDEV_DRIVER_OPS, > .show_fdinfo =3D msm_show_fdinfo, > + .ioctls =3D msm_kms_ioctls, > + .num_ioctls =3D ARRAY_SIZE(msm_kms_ioctls), > .fops =3D &fops, > .name =3D "msm-kms", > .desc =3D "MSM Snapdragon DRM", > > --- > base-commit: ac47870fd795549f03d57e0879fc730c79119f4b > change-id: 20260304-msm-restore-ioctls-2a1792311a09 > > Best regards, > -- > With best wishes > Dmitry >