public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Alvin1 Chen <alvin1.chen@lcfc.corp-partner.google.com>
Cc: neil.armstrong@linaro.org, jesszhan0024@gmail.com,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] drm/panel-edp: Add BOE NV153WUM-N42, CMN N153JCA-ELK, CSW MNF307QS3-2
Date: Thu, 19 Mar 2026 18:04:55 -0700	[thread overview]
Message-ID: <CAD=FV=V0H17cgjbEBXkv6PG4mxycCgrCtduXrw1kEk--t5NFtg@mail.gmail.com> (raw)
In-Reply-To: <20260319050938.556235-1-alvin1.chen@lcfc.corp-partner.google.com>

Hi,

On Wed, Mar 18, 2026 at 10:09 PM Alvin1 Chen
<alvin1.chen@lcfc.corp-partner.google.com> wrote:
>
> The raw EDIDs for each panel:
>
> BOE: NV153WUM-N42
> 00 ff ff ff ff ff ff 00 09 e5 b3 0d 00 00 00 00
> 11 23 01 04 a5 21 15 78 03 af e5 97 5e 58 92 28
> 1f 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 9c 3e 80 c8 70 b0 3c 40 30 20
> 36 00 49 ce 10 00 00 1a 00 00 00 fd 00 28 3c 4c
> 4c 10 01 0a 20 20 20 20 20 20 00 00 00 fe 00 42
> 4f 45 20 43 51 0a 20 20 20 20 20 20 00 00 00 fc
> 00 4e 56 31 35 33 57 55 4d 2d 4e 34 32 0a 01 92
>
> 70 20 79 02 00 81 00 15 74 1a 00 00 03 01 28 3c
> 00 00 60 49 60 49 3c 00 00 00 00 80 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 cb 90
>
> CMN: N153JCA-ELK
> 00 ff ff ff ff ff ff 00 0d ae 6b 15 00 00 00 00
> 16 23 01 04 a5 21 15 78 03 08 82 93 59 53 8e 27
> 1e 4f 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 42 3c 80 a0 70 b0 24 40 30 20
> a6 00 49 cd 10 00 00 1a 00 00 00 fd 00 28 3c 4a
> 4a 10 01 0a 20 20 20 20 20 20 00 00 00 fe 00 43
> 4d 4e 0a 20 20 20 20 20 20 20 20 20 00 00 00 fc
> 00 4e 31 35 33 4a 43 41 2d 45 4c 4b 0a 20 01 d5
>
> 70 20 79 02 00 25 01 09 94 5a 02 94 5a 02 28 3c
> 80 81 00 13 72 1a 00 00 03 01 28 3c 00 00 00 00
> 00 00 3c 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ae 90
>
> CSW: MNF307QS3-2
> 00 ff ff ff ff ff ff 00 0e 77 29 15 00 00 00 00
> 13 23 01 04 a5 21 15 78 03 9c 81 96 5d 5a 94 28
> 1e 51 56 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 1a 3f 80 04 71 b0 23 40 30 20
> 36 00 49 cd 10 00 00 18 00 00 00 fd 00 28 3c 4a
> 4a 10 01 0a 20 20 20 20 20 20 00 00 00 fe 00 43
> 4f 53 54 20 54 39 0a 20 20 20 20 20 00 00 00 fc
> 00 4d 4e 46 33 30 37 51 53 33 2d 32 0a 20 01 5c
>
> 70 20 79 02 00 81 00 15 74 1a 00 00 03 01 28 3c
> 00 00 60 46 60 46 3c 00 00 00 00 8d 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 c4 90
>
> Signed-off-by: Alvin1 Chen <alvin1.chen@lcfc.corp-partner.google.com>
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index 679f4af5246d..775bc4474916 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -1991,6 +1991,7 @@ static const struct edp_panel_entry edp_panels[] = {
>         EDP_PANEL_ENTRY('B', 'O', 'E', 0x0cfa, &delay_200_500_e50, "NV116WHM-A4D"),
>         EDP_PANEL_ENTRY('B', 'O', 'E', 0x0d45, &delay_200_500_e80, "NV116WHM-N4B"),
>         EDP_PANEL_ENTRY('B', 'O', 'E', 0x0d73, &delay_200_500_e80, "NE140WUM-N6S"),
> ++      EDP_PANEL_ENTRY('B', 'O', 'E', 0x0db3, &delay_200_500_e80, "NV153WUM-N42"),

There are two "+" symbols above, which means that you're actually
putting a "+" in the source code. That's not right. I've fixed it for
you this time while applying, but please be more careful.

Reviewed-by: Douglas Anderson <dianders@chromium.org>

Pushed to drm-misc-next.

[1/1] drm/panel-edp: Add BOE NV153WUM-N42, CMN N153JCA-ELK, CSW MNF307QS3-2
      commit: d51f217957ca1fa3a151000e86a192231284595b

  reply	other threads:[~2026-03-20  1:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19  5:09 [PATCH v3] drm/panel-edp: Add BOE NV153WUM-N42, CMN N153JCA-ELK, CSW MNF307QS3-2 Alvin1 Chen
2026-03-20  1:04 ` Doug Anderson [this message]
2026-03-21 14:03 ` kernel test robot
2026-03-21 16:38   ` Doug Anderson
2026-03-21 16:15 ` kernel test robot
2026-03-21 17:52 ` kernel test robot
2026-03-21 18:49 ` Claude review: " Claude Code Review Bot
2026-03-21 18:49 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=FV=V0H17cgjbEBXkv6PG4mxycCgrCtduXrw1kEk--t5NFtg@mail.gmail.com' \
    --to=dianders@chromium.org \
    --cc=alvin1.chen@lcfc.corp-partner.google.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox