From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0AE3FD8FD3 for ; Thu, 26 Feb 2026 16:54:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1293110E9D4; Thu, 26 Feb 2026 16:54:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="bsecA1zQ"; dkim-atps=neutral Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3182D10E9D4 for ; Thu, 26 Feb 2026 16:54:39 +0000 (UTC) Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-2bd801b40dbso84822eec.0 for ; Thu, 26 Feb 2026 08:54:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1772124878; cv=none; d=google.com; s=arc-20240605; b=LKlisZhIVqjC3rf5MTE+Ns8YmlluWOWj6ii6r3A1bgQ2GfcggnbQPe6qao52Uv3PUm EXvbksMhth/tU9hhjizefi6lC/eVGF+sGPJuPxN6DmAxLGJtemtWSliWEg86djtbv4yS Ce15+/DIfsYERReAzQ1yymKicV7Erw3nDSct2KlwzT4lOiR04sRneHdB5k/0VxdDuFgv 2e5y7SPGup9PdYUKiFQmKnNKkdXVQDit/n1GEihqFbzsscfhtjk1R35XrdL6yaHlLIS6 WwpYmfyKOAC72LbGs8sTn5lAXvj4A6vSRnoqmEgQNqHq0DA7gzF1wRd0tXf0org+j2l2 X/tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Up3sT8qjuR5kM0SPkhMO2u8EAJVJK4TECaFQv8JLTOM=; fh=Au8kAT8cPhqrjplqZDDVqAy4U35S9xiFYxDOSuj0vdU=; b=HNRGLLI0vZIYdm1qoKgk+d0PJoWo6gzHYfka9sOHu3GpcefST6ix7EFkDIxAHvphiq XwA//UDpfhrEzpQb5f+S7EYoOfrTIbYM3vm6Bbgsb7EKjl4yLs7+JjR7kiWeeYEujv22 79U2iXpmjlY/Bqvdr16PJgGgMqmSCWAlG8jxYyxvYtZyEGjVm78ZvJMWfiU/7SBRvkkn jSj/YxVY5tw8ISoEZfILNiBC3iVJFsWggZb+uufAVyUDMrUKM2bHI3s+gNkHEehDp7iB 5V2OXKG+kql41fD16w0quRFQ3In42YDmJxXX8nmEr7jnQ3I1yFwzLB2CmgaGad4d9z9w 5ZiQ==; darn=lists.freedesktop.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772124878; x=1772729678; darn=lists.freedesktop.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Up3sT8qjuR5kM0SPkhMO2u8EAJVJK4TECaFQv8JLTOM=; b=bsecA1zQKJaORF7opFUhwDHK8/F5CmhDrs4cMTf8kCB/Qd9A7IO3ubFjBuRBOk+0IE ETXIJ7lumShjWf0huZt4fzbO2tHzY47qsoiOXMcSWqV8LBikPRGIsqsnoRAS5koi1QcH onPd7O5VOlch3YfSjmt6/BZjlH7Sq711fOgeXsvueGaiYsXDOB+FTQucZGY/ITlzeihK M0/xlWEjJ6idR4Ecx0HDt4RQ2CDm9/QC1R4KFDVjBdJu3/dLNfNhtC3/feu+LwXwE3us AB/A3VIayIWQmSAYxE/SsiDLJ01DQeFcW8+3YgPOcjhWpXbhIHRIOPKer0dLB3kzITPz FhRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772124878; x=1772729678; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Up3sT8qjuR5kM0SPkhMO2u8EAJVJK4TECaFQv8JLTOM=; b=Y/IK+mEtH+VJBIB+sKywSDH2Gjsa0iOe079AfiGrSmNi8MSEIRKIV5QKdRysdlbVfX oWpbEYjGtoacTjyxpYs4aB1R/lEHJo8p9PBZ9144M3842xD98fvMM0nxcyTTTG7stxia 5Y8yLpVt29e/KgqrVsmHLYx+VEAVpgPw+Y/L5ECazxUK5OT5i9atzncCBPcEIQEKSaa1 tlSrlvpjQ5CxXo2tFc76ipusYwtpnVUwH6O/iIOclZ43z/avB1dCTE3Mmx9s80rtULpI tT0SXOPA6meAjIyU42wBzaioMi+a4nMgkQxma8mCRwUBWZP5ZfUCTDEbcTP/psvK5JgE CBXg== X-Forwarded-Encrypted: i=1; AJvYcCXgngxodrwf2ix3oV5f5aleKnHcUryKPCIYPMmETI0fmvnpyn4UApgON8zbDvS/oPVPx5E09vIBpN4=@lists.freedesktop.org X-Gm-Message-State: AOJu0YyqipuXyckEKzS25bT+wWIi8f7q+OOAdorb60EY1ayOXUYTZ0ra BgJ5hmcYeF7NsNlgu1gXHVcXXgg6oGCM20+ZqzbsUmU2hB5bQDLoqbTsZTsxZ3G47RM3tbHOJ57 RrCAsJ33VfGJmQW1HyYZnqn1nwbZSUE4= X-Gm-Gg: ATEYQzzwvBcDfSuNV0JjhTTwRuyfiGMEgm1ybKUCoRmygGLOHSBMjg/6tJabAOB4hnj jEF0ddhC8+kSbrhX9TyoUO/U4Gsgx8Lr8oJ4QapKqYXmjcBxxUABqiNVnhNfNepSKLaYXLZvdCX qgsIn6f+jq4xEX3x9t+S8QWVMCcUvezaLSfxW1Bw8C1St+q8Zsq/FLnNoB5QVRN+H+2a6XoB2Bk pZSDsKxizH08cCEyp/DC1MxCu/ODahqDFMR5c9xxKV7Qg4g5JIOZ0ieAmY8TC9cX8lJJvc3GQfs yYHDfboK8z+VICBBT6jZJHjzhAIBre9KYNp4ifaGGTPasPRABA8i6LmNLziCSPk2f3hE8g== X-Received: by 2002:a05:7022:f005:b0:11a:43fb:58dd with SMTP id a92af1059eb24-1276ad3bcd8mr3975440c88.5.1772124878272; Thu, 26 Feb 2026 08:54:38 -0800 (PST) MIME-Version: 1.0 References: <20260226030038.1182961-1-yujie.liu@intel.com> <20260226030038.1182961-7-yujie.liu@intel.com> In-Reply-To: <20260226030038.1182961-7-yujie.liu@intel.com> From: Alex Deucher Date: Thu, 26 Feb 2026 11:54:26 -0500 X-Gm-Features: AaiRm50FIm7gW9ftKbXM9mUDFZF-JB2g7m56NgkO01zsGUV36mqPkWnCPIpQdvQ Message-ID: Subject: Re: [PATCH 6/7] drm/amd/pm: fix kernel-doc warning for smu_msg_v1_send_msg() To: Yujie Liu Cc: Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Kenneth Feng , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Patrik Jakobsson , Matthew Brost , Danilo Krummrich , Philipp Stanner , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Pierre-Eric Pelloux-Prayer , Srinivasan Shanmugam , Tvrtko Ursulin , Sunil Khatri , Lijo Lazar , Asad Kamal , Yang Wang , Hawking Zhang , Tao Zhou , Gangliang Xie , Candice Li , YiPeng Chai , Matthew Auld , Luben Tuikov , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , =?UTF-8?Q?Micha=C5=82_Winiarski?= , Michal Wajdeczko , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Applied. Thanks! On Wed, Feb 25, 2026 at 10:19=E2=80=AFPM Yujie Liu wr= ote: > > Warning: drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:415 expecting p= rototype for smu_msg_proto_v1_send_msg(). Prototype was for smu_msg_v1_send= _msg() instead > > Fixes: 4f379370a49c ("drm/amd/pm: Add smu message control block") > Signed-off-by: Yujie Liu > --- > drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd= /pm/swsmu/smu_cmn.c > index 6fd50c2fd20e..c471c0e2cbd1 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c > @@ -405,7 +405,7 @@ static int __smu_msg_v1_ras_filter(struct smu_msg_ctl= *ctl, > } > > /** > - * smu_msg_proto_v1_send_msg - Complete V1 protocol with all filtering > + * smu_msg_v1_send_msg - Complete V1 protocol with all filtering > * @ctl: Message control block > * @args: Message arguments > * > -- > 2.43.0 >