From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25185FD88DC for ; Wed, 11 Mar 2026 02:07:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E796010E1F8; Wed, 11 Mar 2026 02:07:35 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="nd7k/8xX"; dkim-atps=neutral Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7D01B10E1F8 for ; Wed, 11 Mar 2026 02:07:34 +0000 (UTC) Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5a0fc5e2c59so9992843e87.1 for ; Tue, 10 Mar 2026 19:07:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1773194852; cv=none; d=google.com; s=arc-20240605; b=RdRMSI7o25UW2flY6cOybUb9Yia8CGFmiOiC4ZJApzfTC6Ua4wgH/E3ijMa6kD4/6X 372wluGJAyzDqqK+S61rlTjChjUQzidxuGriuD6+0DLzP8A0/zCv+gIR8TDub6AEU4CQ 0enUSe1ChWGv3SQqIoEfGD3qPV5bvonyp1LNsgsYPsGJ8Fv4gyAh4d9puN2bNPTpmQX0 Wx0/DkusoHxsY0vnVz2z3zHNes1L4E+C67NFmORkU0i/wuGHAbQSb1hPfe+QNccqgVSe /m905C0FL/7WNmGI/HiwJFh4qAOJK2rEJJ5KAWxGprF2CtWN/klYAKfHzSQSvVuxT2dS 05Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=+zLBLQzKjcztDlxJqoLP6w+B6xnZmfHibV4jlBQCebA=; fh=6QjyRXywKzR5zmAsYQ5jdcw9Q5lmmFVntTKZpeeO9jY=; b=Zpvf/kUjOOrCOSYRS+CmzI30k9ft1oah0EAE61qHr9Y6YvWVwLGeD7MuykfVSz9svj 0Am+s6ECMvlUINE7RSZhsHCpruwwwEytTW79WgzZGUXvuLHUjukHOkf1rvVPG08mazF5 pIa/a4YH0hZUK2IoM3oJ3j2rUWjoG6U1zS1PkiZBhA6YmRG0SHIMhaZnO7cptbMkP6m0 3xToA/WZZXAaqq+JX0Q6/Imu4cF+NJtu1QdqX+KPwIhkMGroEla6YQvbDtS0uLaZ1O6i tCKIeb2uyN8O80eIK182TWvNacnIIINbwrACUeoj927EKYAglkl4jstc4x6i9GAvz6pk xZPw==; darn=lists.freedesktop.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1773194852; x=1773799652; darn=lists.freedesktop.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+zLBLQzKjcztDlxJqoLP6w+B6xnZmfHibV4jlBQCebA=; b=nd7k/8xX4jYoots8KkbfkyPyDpGU+k9ydIKKC55qRoaqMjU864KI25IQNw1cw83xcU MN05V2yxwI7AV8sAHbEvs4phnlx1ZuezEZUNsu1KbKh+rjIuKOQPHccG7HkXkdCN/AzY Z/Y+1SmBbMXBBNVWAuu/jAClbL7mde3NiWUwQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773194852; x=1773799652; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+zLBLQzKjcztDlxJqoLP6w+B6xnZmfHibV4jlBQCebA=; b=LpquBMbfnw5aTihU744HQZZIMFXqWxja/wCK3NjMQ3q2ipz1MgrdilSgvU2ZszWgEj M1Uc2GdXdmzvUAJf4qCudkAPQDks/Q/c8x79iEytWMditiEmYyAvf7zeZuj6N/LDuW9Z CfQldeaWWs2ZWZNPq2XEmcAKEE1FCvEGhqaCSxQyqs5tQVNZ53raHY6qjH5uSj3//J65 ykgbttoL5FSO46fzsmtPKmgg4FCVX1ye8Y8es5BRhukbRJxPvLEXWAZMBoR6+Ii65WHp ssBmqssjVyx44JMc8C5YuEHFrX+nu76E2vWcm0INIc9TQP49XllfK7j9dSOiHL1r1J+p 3P5w== X-Forwarded-Encrypted: i=1; AJvYcCXo1oTESoGu4RDZTWw4Y2whhscCai4RWJUHjtwwOYRXBz4MoixnDZiSdTnIlQToAhz4vHQcQcMLYpI=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yyn8bSL9xq1Eogt/tUds6UnFAIq//oBzT3pY5tpQSX0FiTEB7Km lcoxy+PFYs7AnDXRHU6IiCytnV+Dkzl+ApGCG/Zupbh89RXiG/t/5rs9SNKrEz3zVvVo755s+PS isU0nGJeQJoB3twc97ItU1baBgOXwM1YcFUR67/Q9 X-Gm-Gg: ATEYQzymtIYzwnRyKtrX7bXHUSgt+6WE/mV/S4LTDHKRSuU/DsY/M2HuuEd2hzhV4ye fb7O86fX0bcQYXEJQqsTamt36a9SzYAa4SnPUE3j29W3F7Fi67Xg7Th+OD5ebpWgITUbToerAf0 TreDZLqR4/39XqaARk9bAZnJHPuMYzT1JpUEg9yfMOzz5aIMqRh18WL/6xcC2bRJAEN/7rStF6s NlRbpXZf/qZXMDWo/Gv/jkhBDbeFVlClkzOJE+i8bvGPv7/TkL8wj4XyLgp2JahHiSvNJc9+HXE F0EVAQgoAA== X-Received: by 2002:ac2:4427:0:b0:5a1:3134:9bac with SMTP id 2adb3069b0e04-5a156cbd1bbmr169453e87.28.1773194852284; Tue, 10 Mar 2026 19:07:32 -0700 (PDT) MIME-Version: 1.0 References: <20260310-b4-is_err_or_null-v1-0-bd63b656022d@avm.de> <20260310-b4-is_err_or_null-v1-56-bd63b656022d@avm.de> In-Reply-To: <20260310-b4-is_err_or_null-v1-56-bd63b656022d@avm.de> From: Chen-Yu Tsai Date: Wed, 11 Mar 2026 11:07:21 +0900 X-Gm-Features: AaiRm5028PWt8n-JnveiRgn8oYMksdR_-_nk4JOkvxMfplWs-GDr7RRk-OxICyw Message-ID: Subject: Re: [PATCH 56/61] clk: Prefer IS_ERR_OR_NULL over manual NULL check To: Philipp Hahn Cc: amd-gfx@lists.freedesktop.org, apparmor@lists.ubuntu.com, bpf@vger.kernel.org, ceph-devel@vger.kernel.org, cocci@inria.fr, dm-devel@lists.linux.dev, dri-devel@lists.freedesktop.org, gfs2@lists.linux.dev, intel-gfx@lists.freedesktop.org, intel-wired-lan@lists.osuosl.org, iommu@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-clk@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-omap@vger.kernel.org, linux-phy@lists.infradead.org, linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sctp@vger.kernel.org, linux-security-module@vger.kernel.org, linux-sh@vger.kernel.org, linux-sound@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-trace-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, ntfs3@lists.linux.dev, samba-technical@lists.samba.org, sched-ext@lists.linux.dev, target-devel@vger.kernel.org, tipc-discussion@lists.sourceforge.net, v9fs@lists.linux.dev, Michael Turquette , Stephen Boyd , Daniel Lezcano , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Mar 10, 2026 at 9:57=E2=80=AFPM Philipp Hahn wro= te: > > Prefer using IS_ERR_OR_NULL() over using IS_ERR() and a manual NULL > check. > > Semantich change: Previously the code only printed the warning on error, > but not when the pointer was NULL. Now the warning is printed in both > cases! > > Change found with coccinelle. > > To: Michael Turquette > To: Stephen Boyd > To: Daniel Lezcano > To: Thomas Gleixner > Cc: linux-clk@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Philipp Hahn > --- > drivers/clk/clk.c | 4 ++-- > drivers/clocksource/timer-pxa.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > index 47093cda9df32223c1120c3710261296027c4cd3..35146e3869a7dd93741d10b72= 23d4488a9216ed1 100644 > --- a/drivers/clk/clk.c > +++ b/drivers/clk/clk.c > @@ -4558,7 +4558,7 @@ void clk_unregister(struct clk *clk) > unsigned long flags; > const struct clk_ops *ops; > > - if (!clk || WARN_ON_ONCE(IS_ERR(clk))) > + if (WARN_ON_ONCE(IS_ERR_OR_NULL(clk))) > return; > > clk_debug_unregister(clk->core); > @@ -4744,7 +4744,7 @@ void __clk_put(struct clk *clk) > { > struct module *owner; > > - if (!clk || WARN_ON_ONCE(IS_ERR(clk))) > + if (WARN_ON_ONCE(IS_ERR_OR_NULL(clk))) clk_get_optional() returns NULL if the clk isn't present. Drivers would just pass this to clk_put(). Your change here would cause this pattern to emit a very big warning. I don't think this change should be landed. ChenYu > return; > > clk_prepare_lock(); > diff --git a/drivers/clocksource/timer-pxa.c b/drivers/clocksource/timer-= pxa.c > index 7ad0e5adb2ffac4125c34710fc67f4b45f30331d..f65fb0b7fc318b766227e5e7a= 4c0fb08ba11c8f9 100644 > --- a/drivers/clocksource/timer-pxa.c > +++ b/drivers/clocksource/timer-pxa.c > @@ -218,7 +218,7 @@ void __init pxa_timer_nodt_init(int irq, void __iomem= *base) > > timer_base =3D base; > clk =3D clk_get(NULL, "OSTIMER0"); > - if (clk && !IS_ERR(clk)) { > + if (!IS_ERR_OR_NULL(clk)) { > clk_prepare_enable(clk); > pxa_timer_common_init(irq, clk_get_rate(clk)); > } else { > > -- > 2.43.0 > >