From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 094EFFC9ED9 for ; Sat, 7 Mar 2026 06:48:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B90210E419; Sat, 7 Mar 2026 06:48:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="dzMTdFEs"; dkim-atps=neutral Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com [209.85.217.44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 58E8610E419 for ; Sat, 7 Mar 2026 06:48:21 +0000 (UTC) Received: by mail-vs1-f44.google.com with SMTP id ada2fe7eead31-5ffdd9a6155so1526392137.1 for ; Fri, 06 Mar 2026 22:48:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1772866100; cv=none; d=google.com; s=arc-20240605; b=k2JVhiH9nOE++JAzCN1B1u/1nkmug+clzLXZREFE8amBbpBKw8QfHDWjtEODoBArOC TYqmpFZ/NcQYS7ehkXzT7jCKz1o2o/YpT/kG5IGNnf8ueriLhIH17C4d9/B8OAHpQz+g wKQytU8BHB5wfH+JE0aimSONTDRA5YnSntC4XY93jnwQpOm3GJIAEdhTXuVv/L78qrUN YEUXqW1a1kI9AyHKDHgSebxLZ88BTMvpIvq+IaYgi8HdC0aSUbsFZvWHUWqRBmKeRJFz ucURFzyM5RFRYthGamoF7TYLjyn1RaGm2aLxjhrRv3kmNelZYEUHpKEQmIWAzynhTtLW WFXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=hRmLXS/lUmRTfDQsR0+X9BfBWlcLxAvlkJqbJwNWd/w=; fh=zTFRlG6K0TwUrKGaR6qMJ+KjF4t6CzXjrsC27+5/kNA=; b=ODkBoLpt7W74Va7tJWl8SAE1AJdyB0x/jh5ekuTwicGS6j1xZjCWO0iRHMPlJAj7ND DchESSjeVC3mAs9kbsOOtFIV2IDdv1VhEd2yu38umVbpfdNHhinv9t4a3RAuDRgInrt4 iI4jfXEKXTMCYW2YOmLglpLpvterO2tMa/eeDBphvx/FExHNAWDJSxg+rXoo3Rg7tfB1 kYD01VkjV9tnhqAAcnRf31lpF6Y24UZKPbsza0c5/2bf99MCB0kBe5twJJCHJePkBI99 vxJoexNfwV7jPgKr+x87wgvbY3cwkglhDBILmumlW1eiWJWkVS2crMSYA+8hAIbLmzIB Y27g==; darn=lists.freedesktop.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772866100; x=1773470900; darn=lists.freedesktop.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hRmLXS/lUmRTfDQsR0+X9BfBWlcLxAvlkJqbJwNWd/w=; b=dzMTdFEsm9uGJgOHXUrR9bS1lsbpIKnwAfFVSQnbuUV+zgk70w7eCtwbFlheRyDmba s11gp9jIXtL2LglNgS/ItBWV2kUBS5POjC36/mLl5nBepI0Hy8J+/x9ozw/yBHkvgkLO GflUHqnF4TqOWJfXQ6qplHkEDvDCv5cdv3YEe/s+g43qXgHY3GGeNCvnChawFvj8rcFu RuJALUCR0WwB68pHE992cPlDj+UCJuktOs5sIKz6syma5/6w9KxOPD8fhO74itOoexC+ xrPqau2oWiVps/+wTFeeF1bDCgGsbf/sizmGrZ0Wx1QUqNDKdI0+I4RdTbt7mry/jm3r B9XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772866100; x=1773470900; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hRmLXS/lUmRTfDQsR0+X9BfBWlcLxAvlkJqbJwNWd/w=; b=vmG+gFbmZhX8IKrsxfnzanNBXtCZu72cMZqX91OF7d7Cpblu+CVbLflSh8SKJOWIEU t63S6RsJ6p6YoIE8MlHYFKiRnc/0iWGzulUfWdoUEeW49GeXqLWZyGzFLV+nGNpB3swt oRgqFebfGlCO8RE6QtboIYtOszCU6s52OqDegRx7sU3blx3lqqqoH2zIuKEUmcgaknN3 C0rHR7Y4jfeYH6k/nnlqpw1SAopNMc+YFSTeucfr4k3zSgVg5ypcZOyyqzT0P1l/bWvz PMW0KmS02d/GzG1wYdqZZYLcFEdEz6q/gVtmr9f2r6e3gfF1X4FgQMtzHil8nHjX9S6N PBQw== X-Forwarded-Encrypted: i=1; AJvYcCXdklpvo6B0QEKAiOKnrdlRHTnRCRRk5B+uaqRd9V1EMrb+QHwZ3hnd1pYqVs35k/XNUKbmQV+afRI=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yy5filBDvf9YvZ4Ff+7H/XJaiBVPEnecd1ESDxiC1YisApQQsrU jx+fHbkmGbeMKXEqFdhld8Ht4DPuspLQfxSdgmrz2yWPDXxHWMRr9+MbPXHvoSJANrpWmq6F0Pm lb9rmn99lF4NZGWW+ArbMz4gq4+JW4cw= X-Gm-Gg: ATEYQzw8nAcLz5tEQbS1Fqvp7dvUhlWuPgMM99/mUD1+OO3Fw7rhmcVeQ4Xou1JG0vy kXLhClDWGP7fwl/B5dUbXPT5fviVqqMCYtlXQ9pE63OFGPvU+PwUd+Vdo/LtSNvO7OjFe7kc74Y +BRWO95g/yIhcyv6Wfo5baxZUvn5y/6bJUq59/cMYDKZEXm5L0HcU9clQtW8lvoehePd0jyIIAJ Vn6G9/XQAVJ51Ehs0p4rQO6QvlmQR0wa4K0/4tFMFLlcnuRA1uoFgCsr6+u1nPOMHa/qE6EwEtq T1X8i6sq X-Received: by 2002:a05:6102:c10:b0:5fd:ea47:d317 with SMTP id ada2fe7eead31-5ffc8edc536mr3588422137.15.1772866100236; Fri, 06 Mar 2026 22:48:20 -0800 (PST) MIME-Version: 1.0 References: <20260306092553.37973-1-mitltlatltl@gmail.com> In-Reply-To: From: Pengyu Luo Date: Sat, 7 Mar 2026 14:47:59 +0800 X-Gm-Features: AaiRm502i_G8lNln1FvqaR8RKnFFtJwjyfIVaHU8Qf-bf8HfTg4sZ9nSgY3iuS4 Message-ID: Subject: Re: [PATCH] drm/msm/dsi: setup RC model properly To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, Mar 7, 2026 at 2:44=E2=80=AFAM Dmitry Baryshkov wrote: > > On Fri, Mar 06, 2026 at 05:25:53PM +0800, Pengyu Luo wrote: > > Using incorrect parameters does not seem to affect the display, but we > > should use the correct in accordance with the DSC 1.1 or 1.2. > > > > Signed-off-by: Pengyu Luo > > --- > > drivers/gpu/drm/msm/dsi/dsi_host.c | 31 +++++++++++++++++++++++++++--- > > 1 file changed, 28 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/d= si/dsi_host.c > > index b60b26ddb0..276c63d2ac 100644 > > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > > @@ -1843,10 +1843,35 @@ static int dsi_populate_dsc_params(struct msm_d= si_host *msm_host, struct drm_dsc > > drm_dsc_set_const_params(dsc); > > drm_dsc_set_rc_buf_thresh(dsc); > > > > - /* DPU supports only pre-SCR panels */ > > - ret =3D drm_dsc_setup_rc_params(dsc, DRM_DSC_1_1_PRE_SCR); > > + if (dsc->dsc_version_major !=3D 1) { > > + DRM_DEV_ERROR(&msm_host->pdev->dev, "Unsupported DSC vers= ion: %x.%x\n", > > + dsc->dsc_version_major, dsc->dsc_version_mi= nor); > > + return -EOPNOTSUPP; > > + } > > + > > + switch (dsc->dsc_version_minor) { > > + case 1: > > + /* > > + * For DSC1.1. the upstream lacks SCR parameters, the dow= nstream > > + * parameters are unverified here, we support pre-SCR onl= y. > > It doesn't. It's the same as DRM_DSC_1_2_444. Please send a patch adding > the comment. > Indeed, I didn't remember this correctly, and I recheck it now > > + */ > > + ret =3D drm_dsc_setup_rc_params(dsc, DRM_DSC_1_1_PRE_SCR)= ; > > + break; > > + case 2: > > + if (dsc->native_422) > > + ret =3D drm_dsc_setup_rc_params(dsc, DRM_DSC_1_2_= 422); > > + else if (dsc->native_420) > > + ret =3D drm_dsc_setup_rc_params(dsc, DRM_DSC_1_2_= 420); > > + else > > It's not that we support 422/420 output... But yes, it's easier to fix > it now. > Yes, this will fallback to 444 unconditionally now , since I noticed dsc programming takes 422/420 into account, I added it here too. But calculations don't take them into account, like we use scr_bpc * 3 in dsi_adjust_pclk_for_compression(). Should I remove them and add a comment? Best wishes, Pengyu > > + ret =3D drm_dsc_setup_rc_params(dsc, DRM_DSC_1_2_= 444); > > + break; > > + default: > > + ret =3D -EOPNOTSUPP; > > + } > > + > > if (ret) { > > - DRM_DEV_ERROR(&msm_host->pdev->dev, "could not find DSC R= C parameters\n"); > > + DRM_DEV_ERROR(&msm_host->pdev->dev, "could not find DSC R= C parameters for DSC version: %x.%x\n", > > + dsc->dsc_version_major, dsc->dsc_version_mi= nor); > > return ret; > > } > > > > -- > > 2.53.0 > > > > -- > With best wishes > Dmitry