From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9DE20C55197 for ; Fri, 20 Feb 2026 10:50:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 12BFE10E221; Fri, 20 Feb 2026 10:50:12 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="EyRMYhJL"; dkim-atps=neutral Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2373110E221 for ; Fri, 20 Feb 2026 10:50:11 +0000 (UTC) Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-43638a33157so1805130f8f.1 for ; Fri, 20 Feb 2026 02:50:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771584609; cv=none; d=google.com; s=arc-20240605; b=AGnVOQ1coMagITh3RAsFt9Q2Xx5/JLH4tA1SlHd/IfnEvfGkvoUlhrxtvcBCfxFwCK Gode8U/5XmSN8uWiFFQ24U2wJbVjSATQLP/ckPtXoDwPLqXYpdq8XcM3j4ynjHySQRLr IUDqGgy7vfYeRULMybpoAIq8azyEKEJJmLKWAv5KXxFW91H937jSC9ki+5+bzG4py/Ly 4JybTjxINFAE06X9dPwomei2c9Uw8ZsZQ/fr4IJBQr5N35RBJCKaus5y7dHdV28M22OU gmksDWt4+Eg4gtc5fF4MPtqjGeVKWI+oiJxqwAbVLBTsX5HtaPKUwaA7ZeRrybt7AYcT MdCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=UAf0+WPiEFSXz/CCPkkC3DmUlSyhmOoTBssum21ipoU=; fh=KW5LONcyrclHegWxvMjM+2ml9TPFyBdY2IlHw7HkDZ4=; b=KNN6wZAOSdTeYkGs4aLGdD1qayBHImL+EsqDC5+sgvqqBHYJIo59d1M+uYAT7kM1pQ cd0/jgaO1ue5e5vrVI4Q9RZx80mzdaYI1NyjrIRHzfWXGBPdIUODKasUvPjDEdKXXd8v mFM7olzYmgkJ8iWyPCLdP/RujBFVWy+TpMJO0rJlpSwzpJF0LWnkb6IOL99NyHgJlyMn svqBst7FYAW0TqYOztuxy6RP40TF0I4ySNLqDxV0lAz7KWrY4rbkgMK3+pNAX/2WCH/k yyT0SgERf/qD4JfECamfgKCspID6TT2G1qj6IPXTn0OzFRBFZrqW/f6856MZatqxEmfC 0ixA==; darn=lists.freedesktop.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1771584609; x=1772189409; darn=lists.freedesktop.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UAf0+WPiEFSXz/CCPkkC3DmUlSyhmOoTBssum21ipoU=; b=EyRMYhJLlT3FLYecXx5D0iCH3kNExPYQ/0ciVK3s2uEkqlhnrKnoMQkCMGzwgJYHVK j1brVnmIq/nQXRPUJ+XCvxTLgHFjqNz/n10OVk9Kn5zJMpdFc7Y0FWnO0FMbpAuaSWAk BUEv+yGjiWfTli8re5rV+jldU9H3CTELSF6ctJZ+9lIC6vzOM3xHA9YmWTsd/F43KN5K moSSXahJMiQnggmD2tD0oF0veknzij41zSEf6gHenK292F+mKMH6JfWdVcr/CSnp5MAz XFRb8qSprDQTYSO0cUbq6uY9FSYAirB++AiWm54OCuOrlmmwToWXeiVaMZ90e4uToipW laDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771584609; x=1772189409; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UAf0+WPiEFSXz/CCPkkC3DmUlSyhmOoTBssum21ipoU=; b=nIXZ6mBYY6UGucvFs7AUzSV9YAbgfhBkcZP+Ss1nAbSlTogn9TczKKVXGTKRekbmyB 5J8Up3WGYbnYNFheBu9jPT4/pYPPiqjTiilwwzvYsUtGOYUDm46itpfHv+kDIiZCnp4b PB+FRicf+Jzl1EWcRuaZcREzZAS78adGxtGFM8sk3SrwUcsdzLadewXSHhCEJvePB7w7 LFHVXJPQyuX3VYoaUbQS3cx7/3EKCrkTLmJprQgt+8+2YMz5jz2R/YID6TKSZKtkap7v jjVVuVBAhw8Xyl8441vvJQfiTCQGD5DwFWg9cqv6sBwuCdQb7Q+6PtRXcGC19zvGJKTx UTjA== X-Forwarded-Encrypted: i=1; AJvYcCVmY2SwYxfVI8DaRSYmfOG5fJmrxP7Zwr7LUBfCc/AHvTl/yU/jlJW4n0hHSv5P82mDzqsFv52q0+s=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzUsEjlrjnW4UGcvJ+IpECgfCPZ2aHDrHtKQtZ+1PDpAmSExqcI kifyr3tf1OyVD/JhYBpVe/gN7EDWMXWTNDBr1q65fKeUI6Xyx143gH+tvRjvJjR7Ol5U5dAftTg 48bS5I4iR7hjbFDoKZvRPD+P5NkaCr7KsboFGJWJA X-Gm-Gg: AZuq6aKEytnDMkdoVpwMGJJ68lV3RwLqPQncMi7S6AvDe+w4IerCQUAsl9GiYKzlNGV bd1D2dSmYI4fHPvO81WBuuSEpnWxyY4qziIGI5SZ1Z7h9WSgw0Q7w013Ba1UGgBZP5ml0ZfrrtR 8/Klf6FZ82VKda0d7K8jnM7Zp1zTPz5GgFcvFXNShmiOgj9rFxFhouFBRADnA6Bt3zxf/wWgzxF qJMdSZmlfmwVwEwRx8bdHI5gMyguJ8UkLodgObTm8Oo4MW10YhVHiVpOT33mUcshLP2Ow1XhPa0 EYSpD+yYJAqt99G4nQ5nT9blT/jbDTWEHJ6UAA== X-Received: by 2002:a05:6000:2409:b0:435:95c9:6895 with SMTP id ffacd0b85a97d-43958e00ce5mr15101201f8f.18.1771584608836; Fri, 20 Feb 2026 02:50:08 -0800 (PST) MIME-Version: 1.0 References: <20260220-unique-ref-v15-0-893ed86b06cc@kernel.org> <20260220-unique-ref-v15-3-893ed86b06cc@kernel.org> In-Reply-To: <20260220-unique-ref-v15-3-893ed86b06cc@kernel.org> From: Alice Ryhl Date: Fri, 20 Feb 2026 11:49:57 +0100 X-Gm-Features: AaiRm525n9TXR47KvplRQPUHuuUwgU5iN4_ng3kUHWK8LN9TrQcHulfhA1IhjZ4 Message-ID: Subject: Re: [PATCH v15 3/9] rust: Add missing SAFETY documentation for `ARef` example To: Andreas Hindborg Cc: Miguel Ojeda , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , Dave Ertman , Ira Weiny , Leon Romanovsky , Paul Moore , Serge Hallyn , "Rafael J. Wysocki" , David Airlie , Simona Vetter , Alexander Viro , Christian Brauner , Jan Kara , Igor Korotin , Daniel Almeida , Lorenzo Stoakes , "Liam R. Howlett" , Viresh Kumar , Nishanth Menon , Stephen Boyd , Bjorn Helgaas , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Boqun Feng , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-security-module@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, Oliver Mangold Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Feb 20, 2026 at 10:52=E2=80=AFAM Andreas Hindborg wrote: > > From: Oliver Mangold > > SAFETY comment in rustdoc example was just 'TODO'. Fixed. > > Signed-off-by: Oliver Mangold > Reviewed-by: Daniel Almeida > Co-developed-by: Andreas Hindborg > Signed-off-by: Andreas Hindborg > --- > rust/kernel/sync/aref.rs | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/rust/kernel/sync/aref.rs b/rust/kernel/sync/aref.rs > index 61caddfd89619..efe16a7fdfa5d 100644 > --- a/rust/kernel/sync/aref.rs > +++ b/rust/kernel/sync/aref.rs > @@ -129,12 +129,14 @@ pub unsafe fn from_raw(ptr: NonNull) -> Self { > /// # Examples > /// > /// ``` > - /// use core::ptr::NonNull; > - /// use kernel::sync::aref::{ARef, RefCounted}; > + /// # use core::ptr::NonNull; > + /// # use kernel::sync::aref::{ARef, RefCounted}; > /// Either keep the imports visible or delete this empty line. And either way, it doesn't really fit in this commit. > /// struct Empty {} > /// > - /// # // SAFETY: TODO. > + /// // SAFETY: The `RefCounted` implementation for `Empty` does not = count references and never > + /// // frees the underlying object. Thus we can act as owning an inc= rement on the refcount for > + /// // the object that we pass to the newly created `ARef`. > /// unsafe impl RefCounted for Empty { > /// fn inc_ref(&self) {} > /// unsafe fn dec_ref(_obj: NonNull) {} > @@ -142,7 +144,7 @@ pub unsafe fn from_raw(ptr: NonNull) -> Self { > /// > /// let mut data =3D Empty {}; > /// let ptr =3D NonNull::::new(&mut data).unwrap(); > - /// # // SAFETY: TODO. > + /// // SAFETY: We keep `data` around longer than the `ARef`. > /// let data_ref: ARef =3D unsafe { ARef::from_raw(ptr) }; > /// let raw_ptr: NonNull =3D ARef::into_raw(data_ref); > /// > > -- > 2.51.2 > >