From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7178FE67A9D for ; Tue, 3 Mar 2026 08:54:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8F69510E6D2; Tue, 3 Mar 2026 08:53:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=paul-moore.com header.i=@paul-moore.com header.b="ZF9uE3b+"; dkim-atps=neutral Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by gabe.freedesktop.org (Postfix) with ESMTPS id 832ED10E602 for ; Mon, 2 Mar 2026 23:45:03 +0000 (UTC) Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-358e3cc5e7eso2209665a91.0 for ; Mon, 02 Mar 2026 15:45:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1772495103; cv=none; d=google.com; s=arc-20240605; b=FYOeTangQ3PFawiOsEsmzCdvAUgkOk1nxeEDNmCviCQ2Ialn/mD8a0Rp1hUbNzFNTO vtHoWuGJKYGDtAK/P97p13cELq7xghR+5IC+uiYnHgTsfhhDQl4eirZVmPo7VsdsBPlU bteFAIfR1Gqaui8NYMoGZLAbQFGzT34k+DN+iSy696ngExLQ6YiMXyJP546RYh25OtUe vQZaPTCppR9CH/cqaTcF130bLPO52xQmfArg4pt8YvuCxcrtTp6ywvkEpe6Hu8tjg+3+ GIpbTIl2cua4s9+KWbchuudtN/ohjS5V/nCBiT/JqVylxvdTtPW3CVKERtIemkk+Tp9Z pr9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=u082M2vpZx7MrZkmV/F7ZdAH+CJQSjxHglDjea1+awA=; fh=W3pm8gu71Y1tBV6la5DfPT2jqK6jWmPI45JcPf4p+ao=; b=jfvmOHjDSZgFksGW5oVNixBwlZoLx8T5TwUnL3DIbvvZHOmo5QesltaIiG8TvZgn+C Nv1c9zXcFZtW+jU4Pf+pszOzX4M9DPldkPKUEkT6SpQp/znvFDAqCjPMEfDWTU2Hvjdg gmjb6DmkbDyOXMIiKYaTkzmRqyz1RMgR4ZckBbpQGhsUGvt7bVv6zGBhUKUAN5Z4trgB ecqfeVl20t8d35ddlusRYW+aAASfLlKTRZizDaDM7UiJHOXJvz+RDQF0mE3kK6uJq1HK CATaR6GjuE4zs2tZLGJNOVdvPWiQJHlXVdgIWCCXcvQp1Foj+8o+JOHReCJVrg3SV8vr qBog==; darn=lists.freedesktop.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1772495103; x=1773099903; darn=lists.freedesktop.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=u082M2vpZx7MrZkmV/F7ZdAH+CJQSjxHglDjea1+awA=; b=ZF9uE3b+i8TEEEcNTBWi6oOg+hF61QG0E1wCdPG9jIu85YIvGduRA4G4ZspZu8t5wV I+ixSimt+RQtF0v2grfp+os48BuyF7Fp9WLfdJTzn53XIoT2JAz5aurxmic2ZyujiLVt UgU3wBHK2BNvklmPI0DBRlQJVyucoaAJ+TRtAkaqSr90oGnqqge5YJLd7JQNLi7XzP+i RaBSYcjYRQ0M8zVaG423s+1v/tOyB4AM/rISN5sjsTw79CWkwUwJE631iR5YlRuDXQnx 4eaWR9ZvnMeZnmDpVYrgV3nAeQPCrF2FrzARqchMC7kNH/O11ScWHUYSKkAG6DIvuBYw QMxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772495103; x=1773099903; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=u082M2vpZx7MrZkmV/F7ZdAH+CJQSjxHglDjea1+awA=; b=R6nZyyEisOWIa8ZJ34d0SZ7ephEg7wNLKHKaLC2WvD/keHl+UMx3AfipGH5hGOxkuO 4jXah+6TvSTZaSc89nBWsE/SykjmVmw4+xVkEsDlLAMwZwzfIzxbEXxURC6+rx1k6SpL r1C95JPLx1wpHtRRetP6y54Dfjdllfe6v99NP361gUnP0Ds+QwQYsQ6sZ2g5TkM9+XMi 3P9U6HziTXTNbdkW/eKgYjbYE0rNjcFc7Oc7rwWlB9DDsw+K+LiMw8sUfXEa0WM0Pxmh 51BUyJPfnS1rHURPf5j+IqIDQX+nWH9mKhD5MY9QxrMUvDrEBTvugGzYI/1o6zg8Jmap ZuFg== X-Forwarded-Encrypted: i=1; AJvYcCWFU2eBx2JDK2Enb77J/kY2QMaqQB3Quzarz+eUK6A+u30SDQcguwmE/wihXDns9Squ+51slB+w6so=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzPb/WzwZ9ReS5wh7oWOnDL//c/8e/IEM7zDBxiBMONqcWG8v8q BwY1oPKxH4E9vxM2kzNS3Rvuh+ctolHuxKkAHDDr+Jy0lCMGwplHFQUt9YNSvtr0zaMgi4Whwbg J4AQQDS3LSQvhX2dkS0KeJj2bOSBsT2RLFkE3H6iC X-Gm-Gg: ATEYQzzGDCnoQTzcUognQNx8ZNeM73RPW1d25KkZTLAPtnL2Nx+Pj14G4f0TUwnDMpu xTs9fBOWKJEuSb2xBTN8413Z/Dx4t/ghiJ2QqCe7hxEgElR/0M6gRacOMtIP5nqKMYtV1jeGgHk gcuEwTRySNrUQmZgjcJWV8srf3hFkDchNvds4sqNmpSGLP8IMf0VAVv5e+lxCUm96XGyHGF0iEK sKvlqCjRupr5vfsfE1R9LKW2MR+D0eKEs+3gP6zczEPLDCiZxEJN9aljzGWsANkFJioVhFqFz71 yNJzfaQ= X-Received: by 2002:a17:90b:578e:b0:356:2eff:df05 with SMTP id 98e67ed59e1d1-35965c9d15dmr12730172a91.16.1772495102745; Mon, 02 Mar 2026 15:45:02 -0800 (PST) MIME-Version: 1.0 References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <20260302-iino-u64-v2-3-e5388800dae0@kernel.org> In-Reply-To: <20260302-iino-u64-v2-3-e5388800dae0@kernel.org> From: Paul Moore Date: Mon, 2 Mar 2026 18:44:51 -0500 X-Gm-Features: AaiRm51Sffi2V1GbWbKQK3xjBHaGrjaqO3h4_HvI_INFaL56ZEFyr07E1_3tePs Message-ID: Subject: Re: [PATCH v2 003/110] audit: widen ino fields to u64 To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Dan Williams , Matthew Wilcox , Eric Biggers , "Theodore Y. Ts'o" , Muchun Song , Oscar Salvador , David Hildenbrand , David Howells , Paulo Alcantara , Andreas Dilger , Jan Kara , Jaegeuk Kim , Chao Yu , Trond Myklebust , Anna Schumaker , Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Steve French , Ronnie Sahlberg , Shyam Prasad N , Bharath SM , Alexander Aring , Ryusuke Konishi , Viacheslav Dubeyko , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , Marc Dionne , Ian Kent , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Ilya Dryomov , Alex Markuze , Jan Harkes , coda@cs.cmu.edu, Nicolas Pitre , Tyler Hicks , Amir Goldstein , Christoph Hellwig , John Paul Adrian Glaubitz , Yangtao Li , Mikulas Patocka , David Woodhouse , Richard Weinberger , Dave Kleikamp , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Miklos Szeredi , Anders Larsen , Zhihao Cheng , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , John Johansen , James Morris , "Serge E. Hallyn" , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Fan Wu , Stephen Smalley , Ondrej Mosnacek , Casey Schaufler , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Sumit Semwal , Eric Dumazet , Kuniyuki Iwashima , Paolo Abeni , Willem de Bruijn , "David S. Miller" , Jakub Kicinski , Simon Horman , Oleg Nesterov , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , "Darrick J. Wong" , Martin Schiller , Eric Paris , Joerg Reuter , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Oliver Hartkopp , Marc Kleine-Budde , David Ahern , Neal Cardwell , Steffen Klassert , Herbert Xu , Remi Denis-Courmont , Marcelo Ricardo Leitner , Xin Long , Magnus Karlsson , Maciej Fijalkowski , Stanislav Fomichev , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, nvdimm@lists.linux.dev, fsverity@lists.linux.dev, linux-mm@kvack.org, netfs@lists.linux.dev, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-nilfs@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, autofs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, netdev@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-xfs@vger.kernel.org, linux-hams@vger.kernel.org, linux-x25@vger.kernel.org, audit@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-can@vger.kernel.org, linux-sctp@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Tue, 03 Mar 2026 08:53:16 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Mar 2, 2026 at 3:25=E2=80=AFPM Jeff Layton wro= te: > > inode->i_ino is being widened from unsigned long to u64. The audit > subsystem uses unsigned long ino in struct fields, function parameters, > and local variables that store inode numbers from arbitrary filesystems. > On 32-bit platforms this truncates inode numbers that exceed 32 bits, > which will cause incorrect audit log entries and broken watch/mark > comparisons. > > Widen all audit ino fields, parameters, and locals to u64, and update > the inode format string from %lu to %llu to match. > > Signed-off-by: Jeff Layton > --- > include/linux/audit.h | 2 +- > kernel/audit.h | 9 ++++----- > kernel/audit_fsnotify.c | 4 ++-- > kernel/audit_watch.c | 8 ++++---- > kernel/auditsc.c | 2 +- > 5 files changed, 12 insertions(+), 13 deletions(-) We should also update audit_hash_ino() in kernel/audit.h. It is a *very* basic hash function, so I think leaving the function as-is and just changing the inode parameter from u32 to u64 should be fine. --=20 paul-moore.com