From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BAB3FEDA698 for ; Tue, 3 Mar 2026 17:00:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7BDA310E86E; Tue, 3 Mar 2026 17:00:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=paul-moore.com header.i=@paul-moore.com header.b="XM1eQFEy"; dkim-atps=neutral Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by gabe.freedesktop.org (Postfix) with ESMTPS id 833F410E842 for ; Tue, 3 Mar 2026 16:17:48 +0000 (UTC) Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-35982fd8910so1275403a91.1 for ; Tue, 03 Mar 2026 08:17:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1772554668; cv=none; d=google.com; s=arc-20240605; b=ZFwQT2jeu1TBJOb0kP7e0K3NDHshcm00u3I3nom5F+ayKWW2utC8A0m0BdyXchNYqw wJO883XNgJDxumNCEIkOUl//kpkH6qTzyTajhq7j3sDDUImzKKFx2baphdFYm595A7JM LKI88Jm5V08MlDlLDF75tfuyxErPzsZxmi86WTk4tQB1w3Al6fQV18ciA636CFxwZYni rLbSKDxmPiTZC1Yix+Udk6N3/sIelmhh4Onoxh9QBsYedhpbtZ6rnf/9UFkzYhC3vt7A Ng4JjOTUMQfIvN0/V+sJQe5XSmzPyuf6ZbApBFEfWVYxgmTmMWZYD6BxPA+Kst6/5Vm8 iCkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=vlM0HTuT+/Lu8GovscjfA3KZuqms5GnXWRMciKBvDhQ=; fh=JniTznyT+BjzR18HUhV5JxkuMn9S86/HxFbR7WY4wU8=; b=bpR9GyW3A2Dbk9aA7KpbdQOULWGpSKdIQsADwWtrrDaF6pMzKZ6buHIlz2ejVyvywK VJlkU5ru3FEGM03N04gFaJngQ03zQyzrSCd+0IPmVFj8mZzgCa+2oPpuU6igxcWBCKm9 w+7gzHetgVac5czTW+aqKVwuJkveDXLROtng1Cr35MYoyA43nxZ/1X9BSSFD+1KQHa2N d09bKHzz4cUPiJdBJCJN3WwLtVZuUv4DguIgkQhPmGOilHswc8fiLPpC8FuCqzypQ81p jUFmftMEaBEIqEVIo+m229xBK0fMExokDvrKRGFygb75/WQf1TFE1WdIgMi1JWPPiGu6 uDMw==; darn=lists.freedesktop.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1772554668; x=1773159468; darn=lists.freedesktop.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vlM0HTuT+/Lu8GovscjfA3KZuqms5GnXWRMciKBvDhQ=; b=XM1eQFEywMqysfGSCA1xKkvxUL0ijCtPeBNPPMJO+VhInGCuV1hXcdq6kTpJy5EwYc ba+ckqW/ebDKbLqP3qUfhSdrO9355jdBaQ4lyCQ9zGr3ty1kjaWry5lDHtxM5MQtuxPw mA7QhV9WJiPdOBar1yCHliuSI+T7Neucl3aDZaDsML0fgweFgS4u4i5H9H70fwmnmbrN +7RbOdIlNu+Ae4S57W1Vd6ikevGdTV3NRa/X4YbcTs47I3h3ouRNL75bF3RZPVOrg6Y3 qrGDeOP0yVhwjJMHKNl7dhXofXw0gi5v1kQbkUKDrdbfIL3qwoNqJFxZnEN53MId8mRg Cafw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772554668; x=1773159468; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vlM0HTuT+/Lu8GovscjfA3KZuqms5GnXWRMciKBvDhQ=; b=Ue4PD+nff2ofWEo9s0GPh3jlBpgFOS81QYsVhidTqPSyFX9rE1UQOQzQ0RGIk1yEXp d0aN874+m3sHJx1rBrd9WMDRUKom84dQd3jPD8dl5GaX3pDrfozWGqGPdFojsbV+RtEs U0ujkieAbpol5R1l+UUvyuWkcStGMCtG/AMsP8iOlrjGqPbhG3/f191uR+pCbUygNXhC KEzuWWMZdU5zu/ECs4mXj6RDPMYDjetrbTylLraY304d7Um74qCqZ0Tz4Ar9XYp/z0i9 6xmf6uHTw6ZLzsMXDjtj3nCQ8eWswaWZAJwHA7eH5VZMZtdSmZ10++l+i8yi7PCy1e+d jesQ== X-Forwarded-Encrypted: i=1; AJvYcCVCx0wWbxcL/CEJoGs/defAlSV4+kfeIH62nCLYCXHnZW91jnVgcVLmE6mlSYSPGQ9FrGAPhJgd1+o=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yzf6/HywWTadCLOe1fq0wcUz5MTrVrJH7s0QICWuu+GV1aNNZZt pkrklvtqO8s/UcmLCv854+XzpaqlAdtODCYUbccTA9Hh2LDmbag4Q63827hATY98oNRNQU2bSr6 /L/WAhdRJD0JEAkc5tuAjLmMEPV1wmxkp9XTSfEfi X-Gm-Gg: ATEYQzzjy4tTqyk98iBG019kiEHUKn9zuG+pTdWd84y+YhEl3BJQJZ5D8RoWeLiy5rZ 9PWt7nPyY6JIZ8BlxIq5IOrvDQEHPGslhlz8ywZVbc7ygMlAp8C36CFp/MgJujYD16TnhzcDnij DN4TLWjwinKdfSdzL/7UHfF75QjNcvK4M2ZYuh4sYtqtfzuaORNvVZV809HIqaxHiS7XjcHCqFL vt3NF/z/lT+Lypwp2DG6S+aWHAVQ/3spX+5GPesmohJKGxqc50wEY0lmCzkAa+ht9XPaks84lH3 0yb9+A8= X-Received: by 2002:a17:90b:4c12:b0:359:8d70:c4e6 with SMTP id 98e67ed59e1d1-3598d70c5admr5344309a91.1.1772554667658; Tue, 03 Mar 2026 08:17:47 -0800 (PST) MIME-Version: 1.0 References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <20260302-iino-u64-v2-3-e5388800dae0@kernel.org> <7a0165fe39e82a1effd8cce5c2c4e82d6a42cb3a.camel@kernel.org> In-Reply-To: From: Paul Moore Date: Tue, 3 Mar 2026 11:17:34 -0500 X-Gm-Features: AaiRm503AvilRZsmzje3hsLVwZQN2UeIDoaYrT0wwtgoCj-_LcRzyWRvZdGrFAo Message-ID: Subject: Re: [PATCH v2 003/110] audit: widen ino fields to u64 To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Dan Williams , Matthew Wilcox , Eric Biggers , "Theodore Y. Ts'o" , Muchun Song , Oscar Salvador , David Hildenbrand , David Howells , Paulo Alcantara , Andreas Dilger , Jan Kara , Jaegeuk Kim , Chao Yu , Trond Myklebust , Anna Schumaker , Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Steve French , Ronnie Sahlberg , Shyam Prasad N , Bharath SM , Alexander Aring , Ryusuke Konishi , Viacheslav Dubeyko , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , Marc Dionne , Ian Kent , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Ilya Dryomov , Alex Markuze , Jan Harkes , coda@cs.cmu.edu, Nicolas Pitre , Tyler Hicks , Amir Goldstein , Christoph Hellwig , John Paul Adrian Glaubitz , Yangtao Li , Mikulas Patocka , David Woodhouse , Richard Weinberger , Dave Kleikamp , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Miklos Szeredi , Anders Larsen , Zhihao Cheng , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , John Johansen , James Morris , "Serge E. Hallyn" , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Fan Wu , Stephen Smalley , Ondrej Mosnacek , Casey Schaufler , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Sumit Semwal , Eric Dumazet , Kuniyuki Iwashima , Paolo Abeni , Willem de Bruijn , "David S. Miller" , Jakub Kicinski , Simon Horman , Oleg Nesterov , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , "Darrick J. Wong" , Martin Schiller , Eric Paris , Joerg Reuter , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Oliver Hartkopp , Marc Kleine-Budde , David Ahern , Neal Cardwell , Steffen Klassert , Herbert Xu , Remi Denis-Courmont , Marcelo Ricardo Leitner , Xin Long , Magnus Karlsson , Maciej Fijalkowski , Stanislav Fomichev , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, nvdimm@lists.linux.dev, fsverity@lists.linux.dev, linux-mm@kvack.org, netfs@lists.linux.dev, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-nilfs@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, autofs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, netdev@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-xfs@vger.kernel.org, linux-hams@vger.kernel.org, linux-x25@vger.kernel.org, audit@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-can@vger.kernel.org, linux-sctp@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Tue, 03 Mar 2026 17:00:21 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Mar 3, 2026 at 11:12=E2=80=AFAM Jeff Layton wr= ote: > On Tue, 2026-03-03 at 11:03 -0500, Paul Moore wrote: > > On Tue, Mar 3, 2026 at 6:05=E2=80=AFAM Jeff Layton = wrote: > > > On Mon, 2026-03-02 at 18:44 -0500, Paul Moore wrote: > > > > On Mon, Mar 2, 2026 at 3:25=E2=80=AFPM Jeff Layton wrote: > > > > > > > > > > inode->i_ino is being widened from unsigned long to u64. The audi= t > > > > > subsystem uses unsigned long ino in struct fields, function param= eters, > > > > > and local variables that store inode numbers from arbitrary files= ystems. > > > > > On 32-bit platforms this truncates inode numbers that exceed 32 b= its, > > > > > which will cause incorrect audit log entries and broken watch/mar= k > > > > > comparisons. > > > > > > > > > > Widen all audit ino fields, parameters, and locals to u64, and up= date > > > > > the inode format string from %lu to %llu to match. > > > > > > > > > > Signed-off-by: Jeff Layton > > > > > --- > > > > > include/linux/audit.h | 2 +- > > > > > kernel/audit.h | 9 ++++----- > > > > > kernel/audit_fsnotify.c | 4 ++-- > > > > > kernel/audit_watch.c | 8 ++++---- > > > > > kernel/auditsc.c | 2 +- > > > > > 5 files changed, 12 insertions(+), 13 deletions(-) > > > > > > > > We should also update audit_hash_ino() in kernel/audit.h. It is a > > > > *very* basic hash function, so I think leaving the function as-is a= nd > > > > just changing the inode parameter from u32 to u64 should be fine. > > > > ... > > > > > It doesn't look like changing the argument type will make any materia= l > > > difference. Given that it should still work without that change, can = we > > > leave this cleanup for you to do in a follow-on patchset? > > > > I would prefer if you made the change as part of the patch, mainly to > > keep a patch record of this being related. > > Ok, I'll see about factoring that in. Thanks. > > Ideally I'd really like to see kino_t used in the audit code instead > > of u64, but perhaps that is done in a later patch that I didn't see. > > I think I didn't make this clear enough in the cover letter, but kino_t > is removed at the end of the series. It's just there to support the > change during the interim. Ah, gotcha, thanks for the education :) > If HCH gets his way to do the changes as one big patch, it'll go away > entirely. --=20 paul-moore.com