From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91F0DEDA6B4 for ; Tue, 3 Mar 2026 17:00:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 307B110E872; Tue, 3 Mar 2026 17:00:23 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=paul-moore.com header.i=@paul-moore.com header.b="Xjxx8lpY"; dkim-atps=neutral Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by gabe.freedesktop.org (Postfix) with ESMTPS id DB51210E844 for ; Tue, 3 Mar 2026 16:03:33 +0000 (UTC) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2ad9f316d68so26411995ad.2 for ; Tue, 03 Mar 2026 08:03:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1772553813; cv=none; d=google.com; s=arc-20240605; b=dPSpbFwsV3pbU+yW1tfAV2dQ+BggUGdKLRSA8JIWRe2lte+vd+aPpIo7gKt+869A3z w0j9fbaQxF+WstrPz01PKlCLqRe3lxrcGxtYw8A3z85LIVXtdk/Kl55uMipE7e8m2KwT whV6w7Y8pTvcIKrzpX1PYDR5qXNn3VDoADNvEJRcnfxwWvgSvV6Kn22eLjxhLNL7GZ3d a0Gj6cxq4NS01CdBiywOONF0LjJiwPuEXhks6zpoKkRAB6kv6efIE8e6L8xHqKIs7xgO qr8S5yaQChR61GXoBKTk4GakvxyInHu4qz8DZXVa14mwxGSorvz6ecJ44yh3L4jKXiW6 pOZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=HCKOB8v5PMk665Bqff0+UwFdzmHKS9yVAUuIB18V7V4=; fh=9lUGbi71lH3n8ru9CI94dXDsVNUj9OZqxz7gXHuAjFU=; b=bVY2UKRmTvhhEi5+5IAQgJH08HU12kkIYIV7UKq537u3wrrfTQFmGwidnDy7Bm+ui2 fxQ9tCIbd2v/cRi/7UNZCTBKwlPdkZisqa2DnUJ1Sb1RGnBqqvm7sPLpcx86KoM0KxjI xDraVpZkikizwi3A5DVWSHML91R70jH5G6zaB+wW0xvUuTZALqdPJZc79XBOCW2vaUlB xFliw5VepMe0EB5TCbUsD4SM/L7t8rokp6cgeWCEBhI5v1WoWu7aTZJARCUqyHe7mes3 SuRc0onJAP91Y5vLDquEt/JWqAK1A951aCS3KYjx+waUeQgB92kITY6cMlHs2O9s8SJO +bzA==; darn=lists.freedesktop.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1772553813; x=1773158613; darn=lists.freedesktop.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HCKOB8v5PMk665Bqff0+UwFdzmHKS9yVAUuIB18V7V4=; b=Xjxx8lpYjLy7FC7cDsI7J1gp0XBEwjGwRuzvhY5RnLZti1p2PgUeJcPztr3A8sJQU8 L76lYsya3xDxscdRM/R36CFqVGivL63Q3Jsv90WQweml4/XT1smDgqnM3r6nMa3ByJ4C NHjPZYfQ7LS7TCjz6OZPbTmCTTOPcgw3dTJount82D66OFFrz1hO/zXgr6vjCUw23Gmq byRpCbHP3vvc/pwtZd6jAiXKjzxmYlandt4a5pYLNKJNP14eCP68yEpqFILW8Xa9F47m sUg776X8eZFmY6u/ILn7Y9ZPGen4G6hFMu/COT+roQU7AeS//rrFHXNGf+8kADHesYvr kAPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772553813; x=1773158613; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HCKOB8v5PMk665Bqff0+UwFdzmHKS9yVAUuIB18V7V4=; b=rx9lHJqUIxVG4FKVBIw97Z1wB2jhZ2gp5Yj1ut+sORhuXnWspXZ6ZVrh6ErzgEzq0H TJNx20DBfKnXEAMTfiFEFCTfbEVr8s85oqUtJPfTBjF5K5FhKVkduGON4SU4h8j5IhfW YBjxJxyqQC1tZnK//cgaWVv5kfu/blwI6okqN4u1lLy/iu6ou6gTM1AGRGkRbcUuRXtI n3cIkWYitXUwvJ0gF1UoCeyfUA6Y2McLxWk67LTofyq+jZdu2Jr+Cm5DJmCTDJJAglqb KEpaUFkT7AQYlAFSJnwXo9LTchgPcWROxSA8m0F3zbQp+Ik4CLodWFUFIkRsdzEeB5bY CiyA== X-Forwarded-Encrypted: i=1; AJvYcCUJ37er/DcV8QqoxOqcP/vyyo/iSsEEuLaLioaXaIr9EkDd3M7SfRloe+b+TRbP7qf/dcoPCOydTww=@lists.freedesktop.org X-Gm-Message-State: AOJu0YxTRc+Rp2dvtbaJujcZFKDBSWALoif5PL51R3+LD9wWhZZMZzEG EEAFNlRKF8xFqPl7PTgflbmOaNo5iiR9uM3q64tXEodckcBZfGEk919XRKdEvexn9NuoAFzhM4P 1GPE6z8VuF7BFHYUiHDniVhDHiRAWJP9cNDZoPhsk X-Gm-Gg: ATEYQzz7VjV8YMqGqY7DtPQ2DoWnrTQbxFgE+1+fXAOJpJX/ewIC2HeBcvHRnkREGna 56WKeK1ejDthm0rNtQJJc5V+n9MDqcFYyx3aDqx6rM9pz4XDm1+tZikf5aqxpc93gFTwCBdwa/t 32uJ51w9qCYg7Ji8V12S8WjZQgtkGXz//7dhi+caZBzHR1ibvQU3EEv44DfJxQ/CiHrPoWwqFxV bB9zoeUmLZzkf0NFlUvE7Ik7tspM8aMymNgc8rtKCZoAf1nlZpMusyTd5fNAOvGclnCo3HYrbe7 YqlrKqg= X-Received: by 2002:a17:902:f60d:b0:2ae:6457:30b4 with SMTP id d9443c01a7336-2ae645735cdmr15498765ad.36.1772553812817; Tue, 03 Mar 2026 08:03:32 -0800 (PST) MIME-Version: 1.0 References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <20260302-iino-u64-v2-3-e5388800dae0@kernel.org> <7a0165fe39e82a1effd8cce5c2c4e82d6a42cb3a.camel@kernel.org> In-Reply-To: <7a0165fe39e82a1effd8cce5c2c4e82d6a42cb3a.camel@kernel.org> From: Paul Moore Date: Tue, 3 Mar 2026 11:03:20 -0500 X-Gm-Features: AaiRm51FwCY5Sd0470l_ykVC0rIb7qnpGdc7B1bNvF1bAK1vXw1y1CZQ64VgwhQ Message-ID: Subject: Re: [PATCH v2 003/110] audit: widen ino fields to u64 To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Dan Williams , Matthew Wilcox , Eric Biggers , "Theodore Y. Ts'o" , Muchun Song , Oscar Salvador , David Hildenbrand , David Howells , Paulo Alcantara , Andreas Dilger , Jan Kara , Jaegeuk Kim , Chao Yu , Trond Myklebust , Anna Schumaker , Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Steve French , Ronnie Sahlberg , Shyam Prasad N , Bharath SM , Alexander Aring , Ryusuke Konishi , Viacheslav Dubeyko , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , Marc Dionne , Ian Kent , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Ilya Dryomov , Alex Markuze , Jan Harkes , coda@cs.cmu.edu, Nicolas Pitre , Tyler Hicks , Amir Goldstein , Christoph Hellwig , John Paul Adrian Glaubitz , Yangtao Li , Mikulas Patocka , David Woodhouse , Richard Weinberger , Dave Kleikamp , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Miklos Szeredi , Anders Larsen , Zhihao Cheng , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , John Johansen , James Morris , "Serge E. Hallyn" , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Fan Wu , Stephen Smalley , Ondrej Mosnacek , Casey Schaufler , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Sumit Semwal , Eric Dumazet , Kuniyuki Iwashima , Paolo Abeni , Willem de Bruijn , "David S. Miller" , Jakub Kicinski , Simon Horman , Oleg Nesterov , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , "Darrick J. Wong" , Martin Schiller , Eric Paris , Joerg Reuter , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Oliver Hartkopp , Marc Kleine-Budde , David Ahern , Neal Cardwell , Steffen Klassert , Herbert Xu , Remi Denis-Courmont , Marcelo Ricardo Leitner , Xin Long , Magnus Karlsson , Maciej Fijalkowski , Stanislav Fomichev , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, nvdimm@lists.linux.dev, fsverity@lists.linux.dev, linux-mm@kvack.org, netfs@lists.linux.dev, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-nilfs@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, autofs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, netdev@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-xfs@vger.kernel.org, linux-hams@vger.kernel.org, linux-x25@vger.kernel.org, audit@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-can@vger.kernel.org, linux-sctp@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Tue, 03 Mar 2026 17:00:21 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Mar 3, 2026 at 6:05=E2=80=AFAM Jeff Layton wro= te: > On Mon, 2026-03-02 at 18:44 -0500, Paul Moore wrote: > > On Mon, Mar 2, 2026 at 3:25=E2=80=AFPM Jeff Layton = wrote: > > > > > > inode->i_ino is being widened from unsigned long to u64. The audit > > > subsystem uses unsigned long ino in struct fields, function parameter= s, > > > and local variables that store inode numbers from arbitrary filesyste= ms. > > > On 32-bit platforms this truncates inode numbers that exceed 32 bits, > > > which will cause incorrect audit log entries and broken watch/mark > > > comparisons. > > > > > > Widen all audit ino fields, parameters, and locals to u64, and update > > > the inode format string from %lu to %llu to match. > > > > > > Signed-off-by: Jeff Layton > > > --- > > > include/linux/audit.h | 2 +- > > > kernel/audit.h | 9 ++++----- > > > kernel/audit_fsnotify.c | 4 ++-- > > > kernel/audit_watch.c | 8 ++++---- > > > kernel/auditsc.c | 2 +- > > > 5 files changed, 12 insertions(+), 13 deletions(-) > > > > We should also update audit_hash_ino() in kernel/audit.h. It is a > > *very* basic hash function, so I think leaving the function as-is and > > just changing the inode parameter from u32 to u64 should be fine. ... > It doesn't look like changing the argument type will make any material > difference. Given that it should still work without that change, can we > leave this cleanup for you to do in a follow-on patchset? I would prefer if you made the change as part of the patch, mainly to keep a patch record of this being related. Ideally I'd really like to see kino_t used in the audit code instead of u64, but perhaps that is done in a later patch that I didn't see. --=20 paul-moore.com