From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F5761125825 for ; Wed, 11 Mar 2026 14:06:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 48E3910E17E; Wed, 11 Mar 2026 14:06:31 +0000 (UTC) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by gabe.freedesktop.org (Postfix) with ESMTPS id E370D10E17E for ; Wed, 11 Mar 2026 14:06:29 +0000 (UTC) Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-b9423d62cbbso150096966b.1 for ; Wed, 11 Mar 2026 07:06:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773237988; x=1773842788; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wIz9Fr5w5J45ZN4rxwvT/0kjXMGfLP1VpB2aKPOax7k=; b=S0ePYdFpJHSPTcAXR7/a4wKJJnlPT4ZpsNwWkd3S0Lb3TFjIDCnrzrSDpJzmr9vqtS Y2Ds/4o86VC6n3bQKB1Z9Tvh0kbc8VuFSE39xaaf59VTqd75Y5SLrrqQajz5V4DS1Ag3 pbTCIp++fJSozn8H26gZ6B87Vh03Sfv5glu2OCBuvoI7lEkpa8+R+a18mKlkLZkpgqpu jnrZiMlepcrQYGV5mQ4HloOC+I+QiI8jfpBLpmmQsmmlMqmtXBotyJAB5JrBBBxAQYcA 2hiJtp0w/hyWFQoO8Ern8hwKLRke12OvRdr/KPbCTMwTmgLbegDQIzODQrew2+XB6Z6s /P7w== X-Forwarded-Encrypted: i=1; AJvYcCXGU23kg9rFqIZMl9wlah/AnB8Gows1Za+yz2LA6kb2U5+Q1lhwuCrMITTzY9ADcU5U9fUJ5Kd4v3A=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yx08SqSZxKJD/4xKHcn4x6NNyXeSyCjT6a2FplYkc2BFTtTguJN hcQq9GB7/FIhGCKtRr2MXnb1r/yTC6VwOeddiQ5WScvIOqa4iWNE/vC2F1geIrkptkRhEw== X-Gm-Gg: ATEYQzymkDLLosdGzwGL8oxatOvLD9Sj6qrSK/ddN49P+f8/L16hCyesKRvww7//qr2 9fZgFiQIzPGQmd8RrxayP79LBMFuV760WdRkjExgd4SrsONQvNh+8L+EBEqlV/+wpPRJ6ElfA40 6GWIU+WwNgwevS9kjG+XCXj9Www9kMCP314HEzqA6QlHfOpzWwSRUUPlnYXp7TnB5DcSMUtHHWK i1EHlRXb4BQz4pgAb+UxfB28ocvbaRNRyIyCmBpybFASa0QL9+j+2sgwKIaNzWBOOTT2We2ntT8 UrH1C+enOdA0KpPBOet5wzeDGQl18318klhNHJTZLdk0gId+dkeQfMhb1e2t1+Bp26mRx2gHQmG c061X5sTA4G6x1k3V57qfTpQ+zbnHUxySJhlV73hINPxxwUUSJNdv+OxcqySH4Pn0grQ6G2a65x uwkctAlxiviWBY6E0w+0M0UCGBfJVRzG12arJsJFnc9fJ5quwCTFtoO78qjkSl X-Received: by 2002:a17:907:7b95:b0:b93:cbc9:85d6 with SMTP id a640c23a62f3a-b972d526189mr160747966b.11.1773237987988; Wed, 11 Mar 2026 07:06:27 -0700 (PDT) Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com. [209.85.218.50]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b972e14ab67sm58615566b.44.2026.03.11.07.06.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Mar 2026 07:06:23 -0700 (PDT) Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-b93698bb57aso169022166b.0 for ; Wed, 11 Mar 2026 07:06:21 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCX6MG6TnkO8Y7OQU/CwDonVRYjc11LwnxLkHB0LAY/MPXR5eVoL/WlyX/UoIyymcop2z+AWtqYzoAY=@lists.freedesktop.org X-Received: by 2002:a17:907:6d16:b0:b88:4f25:81da with SMTP id a640c23a62f3a-b97113ff0b9mr462021166b.0.1773237981235; Wed, 11 Mar 2026 07:06:21 -0700 (PDT) MIME-Version: 1.0 References: <20260310-b4-is_err_or_null-v1-0-bd63b656022d@avm.de> <20260310-b4-is_err_or_null-v1-15-bd63b656022d@avm.de> <20260310100750.303af303@gandalf.local.home> <20260311141332.b611237d36b61b2409e66cb3@kernel.org> <20260311100332.6a2ce4b1@gandalf.local.home> In-Reply-To: <20260311100332.6a2ce4b1@gandalf.local.home> From: Geert Uytterhoeven Date: Wed, 11 Mar 2026 15:06:07 +0100 X-Gmail-Original-Message-ID: X-Gm-Features: AaiRm53WEGMMLW4z34e7P-lM1qFvsCJGZ_o4JNL5NPWbhJPKmcqz6k9bJcyL--8 Message-ID: Subject: Re: [PATCH 15/61] trace: Prefer IS_ERR_OR_NULL over manual NULL check To: Steven Rostedt Cc: "Masami Hiramatsu (Google)" , Philipp Hahn , amd-gfx@lists.freedesktop.org, apparmor@lists.ubuntu.com, bpf@vger.kernel.org, ceph-devel@vger.kernel.org, cocci@inria.fr, dm-devel@lists.linux.dev, dri-devel@lists.freedesktop.org, gfs2@lists.linux.dev, intel-gfx@lists.freedesktop.org, intel-wired-lan@lists.osuosl.org, iommu@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-clk@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-omap@vger.kernel.org, linux-phy@lists.infradead.org, linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sctp@vger.kernel.org, linux-security-module@vger.kernel.org, linux-sh@vger.kernel.org, linux-sound@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-trace-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, ntfs3@lists.linux.dev, samba-technical@lists.samba.org, sched-ext@lists.linux.dev, target-devel@vger.kernel.org, tipc-discussion@lists.sourceforge.net, v9fs@lists.linux.dev, Mathieu Desnoyers Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Steven, On Wed, 11 Mar 2026 at 15:03, Steven Rostedt wrote: > On Wed, 11 Mar 2026 14:13:32 +0900 > Masami Hiramatsu (Google) wrote: > > > Hmm, now IS_ERR_OR_NULL() is an inline function, so it is safe. > > But if you want to use IS_ERR_OR_NULL() here, it will be better something like > > > > node = rhashtable_walk_next(&iter); > > while (!IS_ERR_OR_NULL(node)) { > > fprobe_remove_node_in_module(mod, node, &alist); > > node = rhashtable_walk_next(&iter); > > } > > But now you need to have a duplicate code in order to acquire "node" > > I think the patch just makes the code worse. Obviously we need a new for_each_*() helper hiding all the gory internals? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds