From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C20BF106ACD1 for ; Thu, 12 Mar 2026 16:48:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2DE4910EA7B; Thu, 12 Mar 2026 16:48:50 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; secure) header.d=bitbyteword.org header.i=@bitbyteword.org header.b="r3v6YNRB"; dkim-atps=neutral Received: from mail-yx1-f51.google.com (mail-yx1-f51.google.com [74.125.224.51]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6A31C10EA53 for ; Thu, 12 Mar 2026 15:39:19 +0000 (UTC) Received: by mail-yx1-f51.google.com with SMTP id 956f58d0204a3-64ca4dfdd88so1351829d50.0 for ; Thu, 12 Mar 2026 08:39:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1773329958; cv=none; d=google.com; s=arc-20240605; b=KpesYxVAVazfEorRlJe6DZhLTio18PtCTaoTyVnEOAeOZa4bHgIshElKDj3C/0WIeU pX4KsLL0k7BS1W7qqfR/7BeujB9cOXl51Ijy3D7uHDmrV/O+lNGx8e0x7nws8Klf2ZuF 61C6HifQdOyljS6qKmB0lTjNiCvWpMtG7ImM+s84NliUSB0U3Lu5G1c7tdouTeIOWCOl KPj+UWHwwd7a1G5QuJMPIdGUIfm1bNRWI3awFprjBFgajssgCvU4e1wtUILX3qjWIaW0 ZQLmVWqiI56lrUoUk50O+zjk9geCFZzZeBJZR1OmOROH4tOpLesvrUJzyHpGi9BfffYS mV9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=xV1lSatIeQOkkUeHEjEALGO2gUG7BopBUXrJE33ZDos=; fh=a+oPLc0x3hlHy3xcZjnB31RqTEmpZDZhJwWmyIwkH5o=; b=WvJMkiOM57dihEROLDRG4F68tILGgSJb7DLSHF3en9IbaBNzEwrnPwWdiqlBbqfyDY ZrRTkfHF/hN+07SS5sF4kEx/hAKg6OWKRSh+U97L5kK82MzSSJ+UY62rYXRV/SFcmVsW +lQTcqXO72A8yWwu0cqR4BT0pNYYKjMSJ2PSyEK+V7Axp+yE+TquWG6a7lsYIpXcEYPL JZi2Cr8whdGQryZruJ/L/PTWbXk7WUo7fMMCuDWrN2CG05vTNyHfNzM0Cwxf3FAfbihu JGGvJ41jwq8awJOClexlE4EUdbQ1JEL3qHijFdrrow356XE2GcbFOA86q8dMu3VibL/G DHug==; darn=lists.freedesktop.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bitbyteword.org; s=google; t=1773329958; x=1773934758; darn=lists.freedesktop.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xV1lSatIeQOkkUeHEjEALGO2gUG7BopBUXrJE33ZDos=; b=r3v6YNRBKV8ljpLvUdr6W9yLDlB4cBBWnG1Kdnq5eWYbo/iOO6hDzMn8abQGTF0uCn VDZUwQokG7APZTqVdshB1v+SiZzFgXZMrA8CS2HXxoDoP8UMtQK0588YCFi58ZntaLF5 o/UO0bI+oVEUYzErYQ8Fnl8qY+Edk338xCQ+Ovhd+0QopGQtLyYgmcvf3EgE31Cz3ZL+ uJ1siD/78TkpGte1orgqlg/hVOU+wqfZYEE71wNKodjAyu+J6U2pUugqfdn1TCe9IfB7 FZFAT3khfOjZ7UBbxTA3LrUpqSfYJlxIGbBrvfHMtxYI+GyAebxi1qJSn96D/qa7Yggt BZyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773329958; x=1773934758; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xV1lSatIeQOkkUeHEjEALGO2gUG7BopBUXrJE33ZDos=; b=orcASi76RZ3srgdiBMt9QkHYVXjQEGBfPUMQypaRXSmybc+UbG0XOii86r+aP33zbT kvj0rzc/oalR4kFlZa1fDRQngJD5A4YBXnqSJ0twh+3mmlBNMaNHYtEcoIQGNYyXlAVx 2GIAjQsLDqfruNu4XK4elspnSoQeOx+WVLwFwrYp3QGkBieEn6epVeX+fANW0+Mo56mI i6n7svnahTER3jCk4dQNY20+fLkrOT81ZlFfPs4lQ5BndEpLaVBC2x7y/cPyztrj74An TGZ1jjddUhTfdFGB4vunfFq1eDHtScsXifk1cHmeMT0Sg9pGhaT2P4uwQz4FAgk5/Q33 moFw== X-Forwarded-Encrypted: i=1; AJvYcCVQ6yOFPqaLOEeljCVQAuabEtYZvjcd1+F8c0XIFM3jSdETNJAKD29QbZ6LCW+vhpTJJ79rhGUWBBk=@lists.freedesktop.org X-Gm-Message-State: AOJu0YyCEHw6/2LqwCq0hDK9grDqzkpO+2ZCC+XDZti/LAosQxnTra4b eiCxRWk1fUSIMb5otp1TnAaivv6m5SSsjiIWkIlN2kI6MkdRJR6dQnebspwijcazzU8B4IwVpiz jzqiwiWmWw/YXFnrKyTttoKLGdsA7QKW9C9Gy449oqw== X-Gm-Gg: ATEYQzy2kswuoMOg3Znh/8esi9dzVNdLgCj8fvngDhosGWhTd/wWnYeFEyv8ZZT/hqP pyBqWGqE69IubyOWh0Wq8rOFYekJGdUIj887DFOcvIb9yvkjuKK19GwbOkXgxZAi7+642ZDd5pd wc/tCbS2iJLO9S6QBECTF4leXU42n92Mueq1wLPoPaXt/wTlchzNVGK1PUQOmRhS/GmntBIcKPZ v1hKxDasF54Ib5WEFcrxuqGB2poCsoBh8raGA4Wyz+ONUlv/d3wOhPiwTYOEIY/3x4lZQVIP8EA 5pdptTX8pWxLJSWrwg== X-Received: by 2002:a53:bb8d:0:b0:64d:5742:5ab0 with SMTP id 956f58d0204a3-64d6577eb37mr4463263d50.43.1773329958142; Thu, 12 Mar 2026 08:39:18 -0700 (PDT) MIME-Version: 1.0 References: <20260312150523.2054552-1-vineeth@bitbyteword.org> <20260312150523.2054552-2-vineeth@bitbyteword.org> <20260312111255.7925b4e2@gandalf.local.home> In-Reply-To: <20260312111255.7925b4e2@gandalf.local.home> From: Vineeth Remanan Pillai Date: Thu, 12 Mar 2026 11:39:06 -0400 X-Gm-Features: AaiRm53MQsKCFNMcydaZ5MLANW9ImopAkQThe-DUzJ0WQT8Ah4MCG48E4vTQfog Message-ID: Subject: Re: [PATCH 01/15] tracepoint: Add trace_invoke_##name() API To: Steven Rostedt Cc: Peter Zijlstra , Dmitry Ilvokhin , Masami Hiramatsu , Mathieu Desnoyers , Ingo Molnar , Jens Axboe , io-uring@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Marcelo Ricardo Leitner , Xin Long , Jon Maloy , Aaron Conole , Eelco Chaudron , Ilya Maximets , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-sctp@vger.kernel.org, tipc-discussion@lists.sourceforge.net, dev@openvswitch.org, Oded Gabbay , Koby Elbaz , dri-devel@lists.freedesktop.org, "Rafael J. Wysocki" , Viresh Kumar , "Gautham R. Shenoy" , Huang Rui , Mario Limonciello , Len Brown , Srinivas Pandruvada , linux-pm@vger.kernel.org, MyungJoo Ham , Kyungmin Park , Chanwoo Choi , =?UTF-8?Q?Christian_K=C3=B6nig?= , Sumit Semwal , linaro-mm-sig@lists.linaro.org, Eddie James , Andrew Jeffery , Joel Stanley , linux-fsi@lists.ozlabs.org, David Airlie , Simona Vetter , Alex Deucher , Danilo Krummrich , Matthew Brost , Philipp Stanner , Harry Wentland , Leo Li , amd-gfx@lists.freedesktop.org, Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, Wolfram Sang , linux-i2c@vger.kernel.org, Mark Brown , Michael Hennerich , =?UTF-8?B?TnVubyBTw6E=?= , linux-spi@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, Chris Mason , David Sterba , linux-btrfs@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Thu, 12 Mar 2026 16:48:06 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Mar 12, 2026 at 11:13=E2=80=AFAM Steven Rostedt wrote: > > On Thu, 12 Mar 2026 11:04:56 -0400 > "Vineeth Pillai (Google)" wrote: > > > Add trace_invoke_##name() as a companion to trace_##name(). When a > > caller already guards a tracepoint with an explicit enabled check: > > > > if (trace_foo_enabled() && cond) > > trace_foo(args); > > > > trace_foo() internally repeats the static_branch_unlikely() test, which > > the compiler cannot fold since static branches are patched binary > > instructions. This results in two static-branch evaluations for every > > guarded call site. > > > > trace_invoke_##name() calls __do_trace_##name() directly, skipping the > > redundant static-branch re-check. This avoids leaking the internal > > __do_trace_##name() symbol into call sites while still eliminating the > > double evaluation: > > > > if (trace_foo_enabled() && cond) > > trace_invoke_foo(args); /* calls __do_trace_foo() directly */ > > > > Three locations are updated: > > - __DECLARE_TRACE: invoke form omits static_branch_unlikely, retains > > the LOCKDEP RCU-watching assertion. > > - __DECLARE_TRACE_SYSCALL: same, plus retains might_fault(). > > - !TRACEPOINTS_ENABLED stub: empty no-op so callers compile cleanly > > when tracepoints are compiled out. > > > > Suggested-by: Steven Rostedt > > Suggested-by: Peter Zijlstra > > Signed-off-by: Vineeth Pillai (Google) > > Assisted-by: Claude:claude-sonnet-4-6 > > I'm guessing Claude helped with the other patches. Did it really help wit= h this one? > Claude wrote and build tested the whole series based on my guidance and prompt :-). I verified the series before sending it out, but claude did the initial work. Thanks, Vineeth