From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 854EF106ACD2 for ; Thu, 12 Mar 2026 16:48:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DF96F10EA6C; Thu, 12 Mar 2026 16:48:11 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; secure) header.d=bitbyteword.org header.i=@bitbyteword.org header.b="djt0k3hV"; dkim-atps=neutral Received: from mail-yx1-f51.google.com (mail-yx1-f51.google.com [74.125.224.51]) by gabe.freedesktop.org (Postfix) with ESMTPS id 77C9510EA5E for ; Thu, 12 Mar 2026 16:09:02 +0000 (UTC) Received: by mail-yx1-f51.google.com with SMTP id 956f58d0204a3-64c9f7576d4so1041825d50.0 for ; Thu, 12 Mar 2026 09:09:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1773331741; cv=none; d=google.com; s=arc-20240605; b=QJPvT/tGyOc6PSyOXQ6JpMe1e/5c+8o6i+bj2aStAKUn0jvfGYUCyAPkjrkKB1vXxU 0BJoj8DO2HGErxG6bEZaFebOoyGkCY2VSY3nanCqT/0WeQK9C9IdIeZGm0hKkdQqWz2b Lxik535R9b4WE+UDc2anOIXc1jGPUQf8wmIG9Vdos8ADr94SQNk2SO4dbeXOCQkOgVuP Re5oB7mqcAJOLnV/HhBO05JYQmmCl/9yORj0b3SJPgyXi9WMReqkrYUucNAVqEVu8Y3s dbnAh5B9k2VMJWp1jtuKus7gOT8TY6B5dnfqxUKzbcMYk2cZSocmuBqrTf57cYrrKeY7 U9Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=kI5PTFr09piXXwe+dHgxbmefu5uh1N96l8rxcGpDT20=; fh=XKJKCrrya9GBLLpC0sD3R2EgGBn7E/pz2jOtfKWLXY0=; b=PIcTKuRc7hrCMdrD6ORUynddZYNZicwodXJkO6Q5+cV3wLvWgj0vRqwaAAXKGJMuru IrEEFNMlA6r9/gxDUSqMWgFOVL31r50Ti/41puiWKTWqezcvfZ4aPISJKsHBp41SG/GO EB9H+TftI6x7B21wnFSsQaPMd0RmHDeUt7lz73Nmox47JBLiuKBaTPX7F9I0foLAyV5G LZXnF10qnge3NHsLnoWp7dVmnQW5yTykxhygdJGWQDSDMXYWcoqkwzUy7wUjVFLlux2g 6d5LV97dRzmiMnkyiXPs0rvLSkNEQ1t09kvHRSSLp5CB1iIPpPYWSVtHMCDYD1PenYzD jZDg==; darn=lists.freedesktop.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bitbyteword.org; s=google; t=1773331741; x=1773936541; darn=lists.freedesktop.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kI5PTFr09piXXwe+dHgxbmefu5uh1N96l8rxcGpDT20=; b=djt0k3hVDFJGreJ12+f86xeUGd8Whif7lOAhQ73hsr+DWs5WvKnpXLwJ5/4A1aPvdT UNAwotzKkDEV91p4vZBhWHcL6LfvRuXGTg6xnU70+QpWO4S2yWvt8awhB3NXfMgM5o3L u8pylWxHVnA9gRkRsG3C2eRmAD+GAt007PF14TqZWYE9UdrhkaRLM7TFkok72LFlvmgr 7aIE2cEDvZIw0xsuEpdqLUOoMRuyBKQfP91G0xytXw1dtp8xiD5e28YC8kwLoB++6ji/ RCnLkxQU3FZVY+2GEggWnzMx1QcPvE0aE9IF2SnpSUR8QdJo2ZGW/OPV4DxvPa7CUP+C 40Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773331741; x=1773936541; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kI5PTFr09piXXwe+dHgxbmefu5uh1N96l8rxcGpDT20=; b=R/BSE+q6JgF0ZMOkQ2YS8FMU7p9KLOnTyuA/275OH3H/D9cYk+wOkoedb1+dsaNwNZ JmeWdZ03Ebjy4cwBLQ3iKlvptbQQjlhOP2my+YP27eQcxZ7vfXsAa/kxs7gthV5epLWf 6fxIYFoyYzahwEuDSe5Uu1guzlwyBR/Zi8oAp4Dh4ZKIW3kAI/uKj9SEK7wa41KIaaE3 aTTBbnG3cd7+Ehzbrc4l8ZhXFLH3rIOkmmdO/AH4xF3T40yF1w9BPJu3PeBLQqD9E3Sp fqrebsE/DDIUP2a95vQgxnASBKpO128e4bNL6ITO96BFungzaiAy6dtW81p4+ohvMSXv BKYA== X-Forwarded-Encrypted: i=1; AJvYcCVU3UU1Mh1lKXBR/vqXY5CP5FL48wWwAGwBAsgCtbjr697j4PykJhRadHPobcvhTViRnInFnkfA+04=@lists.freedesktop.org X-Gm-Message-State: AOJu0YxAw3ag32N1kCnozKaWHQycmtFWcag7vtU1saCrffDbEAYZwg6i 2jWt4LHd2MdbIuxr1HZm9RFnHS6MUM2ySj1+2zINaKUCylKFwjYYcnIM9Slsjxgt3vJ7i6PALS6 o3uBcBExuP3otsUDLQRHSmexyqpmuIlXiDGcAnsY5Xg== X-Gm-Gg: ATEYQzxkVdcyAgEjnJzYbAll/p/+SoupU0WmKv2ooTN0D0K02X9oj4wbocGhfD5D5lp yOV8vWYxSmPD4zo4wi2bkTajsx1xKsYpGwnZRpf45eqHXrb6MglJeSkdXjlohId7RifyuIlXths Uv+7Ge/hQ4JQ7x3YcXcpthpYhac0axN7EpxWaJ7PgvFtrSEwiDIdjH+cQlRqmjdRTSUPJFTvy5v vI+RCLe1s84JZ75UsaUa1K57NtAsk3Uold/wiRqPTwsBA5BuuElZh5gzWiqvBW53mw1u44OPrZJ FJvB1nQ= X-Received: by 2002:a05:690e:448d:b0:64a:e799:1d9c with SMTP id 956f58d0204a3-64e63079bb0mr62693d50.60.1773331741406; Thu, 12 Mar 2026 09:09:01 -0700 (PDT) MIME-Version: 1.0 References: <20260312150523.2054552-1-vineeth@bitbyteword.org> <1e3c2830-765e-4271-89f7-0b6784b37597@efficios.com> <20260312112354.3dd99e36@gandalf.local.home> <219d015d-076b-4c80-8f63-88569115fdad@efficios.com> <20260312114041.5193c729@gandalf.local.home> <1becdbce-2c01-468a-bbab-42b5dea9fdf8@efficios.com> In-Reply-To: <1becdbce-2c01-468a-bbab-42b5dea9fdf8@efficios.com> From: Vineeth Remanan Pillai Date: Thu, 12 Mar 2026 12:08:49 -0400 X-Gm-Features: AaiRm50l09G2avZYKQas6kLTqrDst8ZjnHTnngudy3h6MyVa79lzABXaRh3Trz0 Message-ID: Subject: Re: [PATCH 00/15] tracepoint: Avoid double static_branch evaluation at guarded call sites To: Mathieu Desnoyers Cc: Steven Rostedt , Peter Zijlstra , Dmitry Ilvokhin , Masami Hiramatsu , Ingo Molnar , Jens Axboe , io-uring@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Marcelo Ricardo Leitner , Xin Long , Jon Maloy , Aaron Conole , Eelco Chaudron , Ilya Maximets , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-sctp@vger.kernel.org, tipc-discussion@lists.sourceforge.net, dev@openvswitch.org, Oded Gabbay , Koby Elbaz , dri-devel@lists.freedesktop.org, "Rafael J. Wysocki" , Viresh Kumar , "Gautham R. Shenoy" , Huang Rui , Mario Limonciello , Len Brown , Srinivas Pandruvada , linux-pm@vger.kernel.org, MyungJoo Ham , Kyungmin Park , Chanwoo Choi , =?UTF-8?Q?Christian_K=C3=B6nig?= , Sumit Semwal , linaro-mm-sig@lists.linaro.org, Eddie James , Andrew Jeffery , Joel Stanley , linux-fsi@lists.ozlabs.org, David Airlie , Simona Vetter , Alex Deucher , Danilo Krummrich , Matthew Brost , Philipp Stanner , Harry Wentland , Leo Li , amd-gfx@lists.freedesktop.org, Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, Wolfram Sang , linux-i2c@vger.kernel.org, Mark Brown , Michael Hennerich , =?UTF-8?B?TnVubyBTw6E=?= , linux-spi@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, Chris Mason , David Sterba , linux-btrfs@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Thu, 12 Mar 2026 16:48:06 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Mar 12, 2026 at 11:49=E2=80=AFAM Mathieu Desnoyers wrote: > > On 2026-03-12 11:40, Steven Rostedt wrote: > > On Thu, 12 Mar 2026 11:28:07 -0400 > > Mathieu Desnoyers wrote: > > > >>> Note, Vineeth came up with the naming. I would have done "do" but whe= n I > >>> saw "invoke" I thought it sounded better. > >> > >> It works as long as you don't have a tracing subsystem called > >> "invoke", then you get into identifier clash territory. > > > > True. Perhaps we should do the double underscore trick. > > > > Instead of: trace_invoke_foo() > > > > use: trace_invoke__foo() > > > > > > Which will make it more visible to what the trace event is. > > > > Hmm, we probably should have used: trace__foo() for all tracepoints, as > > there's still functions that are called trace_foo() that are not > > tracepoints :-p > > One certain way to eliminate identifier clash would be to go for a > prefix to "trace_", e.g. > > do_trace_foo() > call_trace_foo() This was the initial idea, but it had conflict in the existing source: call_trace_sched_update_nr_running. do_trace_##name also had collisions when I checked. So, went with trace_invoke_##name. Did not check rest of the suggestions here though. Thanks, Vineeth > emit_trace_foo() > __trace_foo() > invoke_trace_foo() > dispatch_trace_foo() > > Thanks, > > Mathieu > > > > -- > Mathieu Desnoyers > EfficiOS Inc. > https://www.efficios.com