Re: [PATCH v1 1/2] dt-bindings: display: tegra: document Tegra20 HDMI port

[Svyatoslav Ryhel <clamor95@gmail.com>]

10 лютого 2026 р. 16:19:17 GMT+02:00, Rob Herring <robh@kernel.org> пише:
>On Tue, Feb 10, 2026 at 11:49:07AM +0200, Svyatoslav Ryhel wrote:
>> Tegra HDMI can be modeled using an OF graph. Reflect this in the bindings.
>> 
>> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
>> ---
>>  .../bindings/display/tegra/nvidia,tegra20-hdmi.yaml | 13 +++++++++++--
>>  1 file changed, 11 insertions(+), 2 deletions(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-hdmi.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-hdmi.yaml
>> index f77197e4869f..f33b700bf0ee 100644
>> --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-hdmi.yaml
>> +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-hdmi.yaml
>> @@ -82,6 +82,10 @@ properties:
>>      description: phandle of a display panel
>>      $ref: /schemas/types.yaml#/definitions/phandle
>>  
>> +  port:
>> +    description: connection to controller receiving HDMI signals
>
>Describe this in terms of this block, not what it is connected to. It 
>could be an hdmi-connector node or a bridge.
>

Isn't the idea of port to provide connection to the remove device. How should I word it: "links HDMI host with the receiver" or "output of HDMI"? I don't quite understand what you mean. Maybe I should remove description entirely, HDMI has a single port and its function is pretty strait forward.

>> +    $ref: /schemas/graph.yaml#/properties/port
>> +
>>    "#sound-dai-cells":
>>      const: 0
>>  
>> @@ -97,8 +101,13 @@ required:
>>    - reset-names
>>    - pll-supply
>>    - vdd-supply
>> -  - nvidia,ddc-i2c-bus
>> -  - nvidia,hpd-gpio
>> +
>> +anyOf:
>> +  - required:
>> +    - nvidia,ddc-i2c-bus
>> +    - nvidia,hpd-gpio
>> +  - required:
>> +    - port
>>  
>>  examples:
>>    - |
>> -- 
>> 2.51.0
>>