From: "Danilo Krummrich" <dakr@kernel.org>
To: "Maxime Ripard" <mripard@kernel.org>
Cc: "Matthew Brost" <matthew.brost@intel.com>,
"Philipp Stanner" <phasta@kernel.org>,
"Christian Koenig" <christian.koenig@amd.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Matthew Auld" <matthew.auld@intel.com>,
"Arun Pravin" <arunpravin.paneerselvam@amd.com>,
"Simona Vetter" <simona.vetter@ffwll.ch>,
"David Airlie" <airlied@gmail.com>,
<dri-devel@lists.freedesktop.org>,
"Tvrtko Ursulin" <tursulin@ursulin.net>
Subject: Re: [PATCH] drm/tests: Mark slow tests as slow
Date: Tue, 24 Feb 2026 12:43:27 +0100 [thread overview]
Message-ID: <DGN5YXMO9CBB.5T29K0XHUXMF@kernel.org> (raw)
In-Reply-To: <20260224110310.1854608-1-mripard@kernel.org>
(Cc: Tvrtko)
On Tue Feb 24, 2026 at 12:03 PM CET, Maxime Ripard wrote:
> Some DRM tests cross the 1s execution time threshold that defines a test
> as slow. Let's flag them as such.
<snip>
> static struct kunit_case drm_sched_credits_tests[] = {
> - KUNIT_CASE(drm_sched_test_credits),
> + KUNIT_CASE_SLOW(drm_sched_test_credits),
Hm..I don't think this test should be that slow.
Looking at the code, I see intentional timeouts through:
done = drm_mock_sched_job_wait_scheduled(job[1], HZ);
KUNIT_ASSERT_FALSE(test, done);
Since the timeout is in jiffies, this should be always 1s, which seems a bit
overkill.
Maybe we should just change this to msecs_to_jiffies(200), which should still be
plenty and keep the test below 500ms.
next prev parent reply other threads:[~2026-02-24 11:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 11:03 [PATCH] drm/tests: Mark slow tests as slow Maxime Ripard
2026-02-24 11:12 ` Thomas Zimmermann
2026-02-24 11:43 ` Danilo Krummrich [this message]
2026-02-24 12:29 ` Tvrtko Ursulin
2026-02-24 12:44 ` Philipp Stanner
2026-02-24 12:49 ` Tvrtko Ursulin
2026-02-26 10:56 ` Maxime Ripard
2026-02-26 12:42 ` Tvrtko Ursulin
2026-02-26 12:48 ` Philipp Stanner
2026-02-26 13:02 ` Tvrtko Ursulin
2026-02-26 13:17 ` Philipp Stanner
2026-02-26 13:23 ` Tvrtko Ursulin
2026-02-24 13:07 ` Arunpravin Paneer Selvam
2026-02-27 5:13 ` Claude review: " Claude Code Review Bot
2026-02-27 5:13 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGN5YXMO9CBB.5T29K0XHUXMF@kernel.org \
--to=dakr@kernel.org \
--cc=airlied@gmail.com \
--cc=arunpravin.paneerselvam@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.auld@intel.com \
--cc=matthew.brost@intel.com \
--cc=mripard@kernel.org \
--cc=phasta@kernel.org \
--cc=simona.vetter@ffwll.ch \
--cc=tursulin@ursulin.net \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox