From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dri-devel-bounces@lists.freedesktop.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.lore.kernel.org (Postfix) with ESMTPS id 38C17E9B250
	for <dri-devel@archiver.kernel.org>; Tue, 24 Feb 2026 11:43:34 +0000 (UTC)
Received: from gabe.freedesktop.org (localhost [127.0.0.1])
	by gabe.freedesktop.org (Postfix) with ESMTP id 8656D10E29A;
	Tue, 24 Feb 2026 11:43:33 +0000 (UTC)
Authentication-Results: gabe.freedesktop.org;
	dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="QU3QYEk1";
	dkim-atps=neutral
Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])
 by gabe.freedesktop.org (Postfix) with ESMTPS id B80B410E29A
 for <dri-devel@lists.freedesktop.org>; Tue, 24 Feb 2026 11:43:32 +0000 (UTC)
Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])
 by tor.source.kernel.org (Postfix) with ESMTP id B9B5261332;
 Tue, 24 Feb 2026 11:43:31 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A3BAC116D0;
 Tue, 24 Feb 2026 11:43:28 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
 s=k20201202; t=1771933411;
 bh=WFO0FMP0ZkIjT7q1qvREiyHrV6yYl5FohSSycAyQHxk=;
 h=Date:Subject:Cc:To:From:References:In-Reply-To:From;
 b=QU3QYEk1C7eiNqnC8bSji+efrn76LSvARsliu3yJ6Dd2Jh1IOmaLNK+ebwWuNwq66
 M5hYq+t2VPSs0JtKqVoYB4WYqAensQAMoZW91MHJjc93enEmAjh1RGis4cIa5EDJaI
 BoFOUzKDooZzGFgIzBxBri+DxDuqTYhbDhGR3HYWwZDKIT4YjACGpP8mShqD4IRBJ0
 lTsT5zOENjq1SQjctASjb8EYxqH/YdJLBpb6Et50GDXT2FYNF8fUxI3bMR0y9QO+PD
 5KdiGDtCrHAuag+e0UqB92oD0z6VtuX0Uk35yqaxOOW0kC4l6iQNMF0Ul/D4gTDIYH
 GjIrI/UbFh86g==
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Tue, 24 Feb 2026 12:43:27 +0100
Message-Id: <DGN5YXMO9CBB.5T29K0XHUXMF@kernel.org>
Subject: Re: [PATCH] drm/tests: Mark slow tests as slow
Cc: "Matthew Brost" <matthew.brost@intel.com>, "Philipp Stanner"
 <phasta@kernel.org>, "Christian Koenig" <christian.koenig@amd.com>,
 "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>, "Thomas
 Zimmermann" <tzimmermann@suse.de>, "Matthew Auld" <matthew.auld@intel.com>,
 "Arun Pravin" <arunpravin.paneerselvam@amd.com>, "Simona Vetter"
 <simona.vetter@ffwll.ch>, "David Airlie" <airlied@gmail.com>,
 <dri-devel@lists.freedesktop.org>, "Tvrtko Ursulin" <tursulin@ursulin.net>
To: "Maxime Ripard" <mripard@kernel.org>
From: "Danilo Krummrich" <dakr@kernel.org>
References: <20260224110310.1854608-1-mripard@kernel.org>
In-Reply-To: <20260224110310.1854608-1-mripard@kernel.org>
X-BeenThere: dri-devel@lists.freedesktop.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Direct Rendering Infrastructure - Development
 <dri-devel.lists.freedesktop.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>

(Cc: Tvrtko)

On Tue Feb 24, 2026 at 12:03 PM CET, Maxime Ripard wrote:
> Some DRM tests cross the 1s execution time threshold that defines a test
> as slow. Let's flag them as such.

<snip>

>  static struct kunit_case drm_sched_credits_tests[] =3D {
> -	KUNIT_CASE(drm_sched_test_credits),
> +	KUNIT_CASE_SLOW(drm_sched_test_credits),

Hm..I don't think this test should be that slow.

Looking at the code, I see intentional timeouts through:

	done =3D drm_mock_sched_job_wait_scheduled(job[1], HZ);
	KUNIT_ASSERT_FALSE(test, done);

Since the timeout is in jiffies, this should be always 1s, which seems a bi=
t
overkill.

Maybe we should just change this to msecs_to_jiffies(200), which should sti=
ll be
plenty and keep the test below 500ms.