From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 224C6E9A771 for ; Tue, 24 Mar 2026 11:24:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4CCC310E150; Tue, 24 Mar 2026 11:24:01 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="nJHAqGFQ"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id ABF2D10E150 for ; Tue, 24 Mar 2026 11:24:00 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 45619409A2; Tue, 24 Mar 2026 11:24:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EEF1C19424; Tue, 24 Mar 2026 11:23:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774351440; bh=jkSgQ0k3gtHnCBhH7lha3CHXwIcOO/0T5Q8w+r82dvI=; h=Date:Cc:To:From:Subject:References:In-Reply-To:From; b=nJHAqGFQl0aak+Tk7Na/PlCKYrLyGZ7gM2tbH4UMDPdQORaBuLuOJ7WrLTN3pNQau QSUZ+QPHbcXhNwd5Gdk2RbactyTJ+FJPSdL5lYcWbejcpehH/TC4aBkT/Zyv0GpGuG TX2M8KVCt9+qwEIOn4MTOzypbmvw0aYW8TVKIxHpIrgFI12YHtdIhM23lRbKzJzp87 B8FYlMmswRjRTg5mVHdObT40MG/yqVYQNYxTM1QC8XOqF+lnib6iOg8hKcfWnH644p LGeYHkD8WKGLCBsG+E+3SSBi5sWfqOZdpuy3qv9er1MY2Ay71qmLhGpY9eCUFkr0+3 sLBT6EiPJI0uQ== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 24 Mar 2026 12:23:54 +0100 Message-Id: Cc: , , "Boqun Feng" , "Alice Ryhl" , "Daniel Almeida" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Miguel Ojeda" , "Gary Guo" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Benno Lossin" , "Andreas Hindborg" , "Trevor Gross" , "Steven Price" , "Boris Brezillon" , "Dirk Behme" , "Alexandre Courbot" To: "Deborah Brouwer" From: "Danilo Krummrich" Subject: Re: [PATCH v3 01/12] drm/tyr: Use register! macro for GPU_CONTROL References: <20260323-b4-tyr-use-register-macro-v3-v3-0-a87daf9e4701@collabora.com> <20260323-b4-tyr-use-register-macro-v3-v3-1-a87daf9e4701@collabora.com> In-Reply-To: <20260323-b4-tyr-use-register-macro-v3-v3-1-a87daf9e4701@collabora.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue Mar 24, 2026 at 1:18 AM CET, Deborah Brouwer wrote: > + register! { > + /// GPU identification register. > + pub(crate) GPU_ID(u32) @ 0x0 { > + /// Status of the GPU release. > + 3:0 ver_status; > + /// Minor release version number. > + 11:4 ver_minor; > + /// Major release version number. > + 15:12 ver_major; > + /// Product identifier. > + 19:16 prod_major; > + /// Architecture patch revision. > + 23:20 arch_rev; > + /// Architecture minor revision. > + 27:24 arch_minor; > + /// Architecture major revision. > + 31:28 arch_major; > + } Are you sure that this is the field order you want to choose for Tyr? nova-= core had this order in the past (we're changing this currently), as it came from OpenRM headers, but it is pretty unusual for datasheets and TRMs, which is = also why the register!() macro examples use the typical and recommended order, i= .e. pub(crate) GPU_ID(u32) @ 0x0 { /// Architecture major revision. 31:28 arch_major; /// Architecture minor revision. 27:24 arch_minor; /// Architecture patch revision. 23:20 arch_rev; /// Product identifier. 19:16 prod_major; /// Major release version number. 15:12 ver_major; /// Minor release version number. 11:4 ver_minor; /// Status of the GPU release. 3:0 ver_status; }