public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: "Manna, Animesh" <animesh.manna@intel.com>
To: "Hogander, Jouni" <jouni.hogander@intel.com>,
	"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Cc: "Murthy, Arun R" <arun.r.murthy@intel.com>,
	"Nikula, Jani" <jani.nikula@intel.com>,
	"Deak, Imre" <imre.deak@intel.com>
Subject: RE: [PATCH v7 0/3] Panel Replay BW optimization
Date: Thu, 12 Mar 2026 08:41:05 +0000	[thread overview]
Message-ID: <DS0PR11MB80499A087C5EAF931B58F491F944A@DS0PR11MB8049.namprd11.prod.outlook.com> (raw)
In-Reply-To: <07a6b5ed17b3781aa6f769d92b8409d3519c21ea.camel@intel.com>



> -----Original Message-----
> From: Hogander, Jouni <jouni.hogander@intel.com>
> Sent: Thursday, March 12, 2026 1:36 PM
> To: intel-xe@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Manna,
> Animesh <animesh.manna@intel.com>; intel-gfx@lists.freedesktop.org
> Cc: Murthy, Arun R <arun.r.murthy@intel.com>; Nikula, Jani
> <jani.nikula@intel.com>; Deak, Imre <imre.deak@intel.com>
> Subject: Re: [PATCH v7 0/3] Panel Replay BW optimization
> 
> On Thu, 2026-03-12 at 10:30 +0530, Animesh Manna wrote:
> > Unused bandwidth can be used by external display agents for Panel
> > Replay enabled DP panel during idleness with link on. This patch
> > series enabling the same.
> 
> Generic comment on this patch set. Maybe we should add one more patch
> with "Fixes" tag:
> 
> Fixes: e60cff453b82 ("drm/i915/dp: Enable DP tunnel BW allocation
> mode")
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: <stable@vger.kernel.org> # v6.9+
> 
> This patch would just add:
> 
> if (intel_dp_tunnel_bw_alloc_is_enabled(intel_dp)) {
> 	drm_dbg_kms(display->drm,
> 		    "Panel Replay is disabled as DP tunneling enabled\n");
> 	return false;
> }
> 
> into _panel_replay_compute_config. this could be first patch in your set.
> What do you think?
Ok to me. Will take care in next version.

Regards,
Animesh
> 
> BR,
> Jouni Högander
> 
> >
> > Signed-off-by: Animesh Manna <animesh.manna@intel.com>
> >
> > Animesh Manna (3):
> >   drm/i915/display: Add drm helper to check pr optimization support
> >   drm/i915/display: Panel Replay BW optimization for DP2.0 tunneling
> >   drm/i915/display: Disable Panel Replay for DP-tunneling without
> >     optimization
> >
> >  drivers/gpu/drm/display/drm_dp_tunnel.c       | 17 ++++++++++
> >  .../gpu/drm/i915/display/intel_display_regs.h |  1 +
> >  .../gpu/drm/i915/display/intel_dp_tunnel.c    | 14 +++++++++
> >  .../gpu/drm/i915/display/intel_dp_tunnel.h    |  6 ++++
> >  drivers/gpu/drm/i915/display/intel_psr.c      | 31
> > +++++++++++++++++--
> >  include/drm/display/drm_dp_tunnel.h           |  6 ++++
> >  6 files changed, 73 insertions(+), 2 deletions(-)
> >


  reply	other threads:[~2026-03-12  8:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12  5:00 [PATCH v7 0/3] Panel Replay BW optimization Animesh Manna
2026-03-12  5:00 ` [PATCH v7 1/3] drm/i915/display: Add drm helper to check pr optimization support Animesh Manna
2026-03-12  6:40   ` Hogander, Jouni
2026-03-12  8:36     ` Manna, Animesh
2026-03-13  4:30   ` Claude review: " Claude Code Review Bot
2026-03-12  5:00 ` [PATCH v7 2/3] drm/i915/display: Panel Replay BW optimization for DP2.0 tunneling Animesh Manna
2026-03-12  6:44   ` Hogander, Jouni
2026-03-12  8:44     ` Manna, Animesh
2026-03-13  4:30   ` Claude review: " Claude Code Review Bot
2026-03-12  5:00 ` [PATCH v7 3/3] drm/i915/display: Disable Panel Replay for DP-tunneling without optimization Animesh Manna
2026-03-12  6:17   ` Hogander, Jouni
2026-03-12  8:33     ` Manna, Animesh
2026-03-13  4:30   ` Claude review: " Claude Code Review Bot
2026-03-12  8:05 ` [PATCH v7 0/3] Panel Replay BW optimization Hogander, Jouni
2026-03-12  8:41   ` Manna, Animesh [this message]
2026-03-12 15:18   ` Imre Deak
2026-03-13  4:30 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DS0PR11MB80499A087C5EAF931B58F491F944A@DS0PR11MB8049.namprd11.prod.outlook.com \
    --to=animesh.manna@intel.com \
    --cc=arun.r.murthy@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=jouni.hogander@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox