Re: [PATCH v3 2/3] dt-bindings: display: panel: add YAML schema for LXD M9189A

[Krzysztof Kozlowski <krzk@kernel.org>]

On 11/02/2026 11:06, Michael Tretter wrote:
> On Wed, 11 Feb 2026 07:28:55 +0100, Krzysztof Kozlowski wrote:
>> On Tue, Feb 10, 2026 at 12:22:33PM +0100, Michael Tretter wrote:
>>> From: Rouven Czerwinski <r.czerwinski@pengutronix.de>
>>>
>>> The LXD M9189A is a 1024x600 MIPI-DSI panel.
>>>
>>> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
>>> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
>>
>> I do not see any improvements.
> 
> Changes in v3:
> - [...]
> - Use panel-common.yaml as base
> - [...]
> 
> This change addresses your comment on v2:
> 
>>> You should reference proper panel schema in top-level.
> 
> I changed the schema to include panel-common.yaml as a $ref. Did I
> misunderstand the comment?
> 
> What else needs improvement?
> 
> I am confused and any guidance would be appreciated.
> 

In such case I find it helpful when you go via previous comments and
ack/acknowledge each of them. It is not necessary if you implement all
of them, but that did not happen here. BTW, I stopped review on the
first missing review feedback to save myself time.


Best regards,
Krzysztof