From: Michael Tretter <m.tretter@pengutronix.de>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Rouven Czerwinski <r.czerwinski@pengutronix.de>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jesszhan0024@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
kernel@pengutronix.de
Subject: Re: [PATCH v3 2/3] dt-bindings: display: panel: add YAML schema for LXD M9189A
Date: Wed, 11 Feb 2026 11:06:30 +0100 [thread overview]
Message-ID: <aYxUpoWETYB9vaK2@pengutronix.de> (raw)
In-Reply-To: <20260211-practical-coyote-of-awe-0dc0a4@quoll>
On Wed, 11 Feb 2026 07:28:55 +0100, Krzysztof Kozlowski wrote:
> On Tue, Feb 10, 2026 at 12:22:33PM +0100, Michael Tretter wrote:
> > From: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> >
> > The LXD M9189A is a 1024x600 MIPI-DSI panel.
> >
> > Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
>
> I do not see any improvements.
Changes in v3:
- [...]
- Use panel-common.yaml as base
- [...]
This change addresses your comment on v2:
>> You should reference proper panel schema in top-level.
I changed the schema to include panel-common.yaml as a $ref. Did I
misunderstand the comment?
What else needs improvement?
I am confused and any guidance would be appreciated.
Michael
>
> NAK
>
> Best regards,
> Krzysztof
>
>
next prev parent reply other threads:[~2026-02-11 10:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 11:22 [PATCH v3 0/3] drm/panel: add LXD M9189A Michael Tretter
2026-02-10 11:22 ` [PATCH v3 1/3] dt-bindings: vendor-prefixes: Add lxd Michael Tretter
2026-02-11 6:26 ` Claude review: " Claude Code Review Bot
2026-02-10 11:22 ` [PATCH v3 2/3] dt-bindings: display: panel: add YAML schema for LXD M9189A Michael Tretter
2026-02-11 6:26 ` Claude review: " Claude Code Review Bot
2026-02-11 6:28 ` [PATCH v3 2/3] " Krzysztof Kozlowski
2026-02-11 10:06 ` Michael Tretter [this message]
2026-02-11 10:12 ` Krzysztof Kozlowski
2026-02-10 11:22 ` [PATCH v3 3/3] drm/panel: add LXD M9189A panel driver Michael Tretter
2026-02-11 6:26 ` Claude review: " Claude Code Review Bot
2026-02-11 6:26 ` Claude review: drm/panel: add LXD M9189A Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYxUpoWETYB9vaK2@pengutronix.de \
--to=m.tretter@pengutronix.de \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=r.czerwinski@pengutronix.de \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox