public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: Yujie Liu <yujie.liu@intel.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	Christian König <christian.koenig@amd.com>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Kenneth Feng <kenneth.feng@amd.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
	Danilo Krummrich <dakr@kernel.org>,
	"Philipp Stanner" <phasta@kernel.org>,
	Thomas Hellström <thomas.hellstrom@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,
	"Srinivasan Shanmugam" <srinivasan.shanmugam@amd.com>,
	Tvrtko Ursulin <tvrtko.ursulin@igalia.com>,
	Sunil Khatri <sunil.khatri@amd.com>,
	Lijo Lazar <lijo.lazar@amd.com>, Asad Kamal <asad.kamal@amd.com>,
	Yang Wang <kevinyang.wang@amd.com>,
	Hawking Zhang <Hawking.Zhang@amd.com>,
	Tao Zhou <tao.zhou1@amd.com>, Gangliang Xie <ganglxie@amd.com>,
	Candice Li <candice.li@amd.com>,
	YiPeng Chai <YiPeng.Chai@amd.com>,
	Matthew Auld <matthew.auld@intel.com>,
	Luben Tuikov <luben.tuikov@amd.com>,
	Ville Syrjälä <ville.syrjala@linux.intel.com>,
	Michał Winiarski <michal.winiarski@intel.com>,
	"Michal Wajdeczko" <michal.wajdeczko@intel.com>,
	<amd-gfx@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	<intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH 1/7] drm/gpusvm: fix kernel-doc warning for drm_gpusvm_pages_valid_unlocked()
Date: Wed, 25 Feb 2026 19:06:25 -0800	[thread overview]
Message-ID: <aZ+4sZoTzX4C/P2T@lstrano-desk.jf.intel.com> (raw)
In-Reply-To: <20260226030038.1182961-2-yujie.liu@intel.com>

On Thu, Feb 26, 2026 at 11:00:32AM +0800, Yujie Liu wrote:
> Warning: drivers/gpu/drm/drm_gpusvm.c:1351 function parameter 'svm_pages' not described in 'drm_gpusvm_pages_valid_unlocked'
> Warning: drivers/gpu/drm/drm_gpusvm.c:1351 expecting prototype for drm_gpusvm_range_pages_valid_unlocked(). Prototype was for drm_gpusvm_pages_valid_unlocked() instead
> 
> Fixes: 6364afd532bc ("drm/gpusvm: refactor core API to use pages struct")

I fix this one already. Believe it merged yesterday.

74b6e83942dc drm/gpusvm: Fix drm_gpusvm_pages_valid_unlocked() kernel-doc

Matt

> Signed-off-by: Yujie Liu <yujie.liu@intel.com>
> ---
>  drivers/gpu/drm/drm_gpusvm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_gpusvm.c b/drivers/gpu/drm/drm_gpusvm.c
> index 24180bfdf5a2..93f7e594256d 100644
> --- a/drivers/gpu/drm/drm_gpusvm.c
> +++ b/drivers/gpu/drm/drm_gpusvm.c
> @@ -1338,9 +1338,9 @@ bool drm_gpusvm_range_pages_valid(struct drm_gpusvm *gpusvm,
>  EXPORT_SYMBOL_GPL(drm_gpusvm_range_pages_valid);
>  
>  /**
> - * drm_gpusvm_range_pages_valid_unlocked() - GPU SVM range pages valid unlocked
> + * drm_gpusvm_pages_valid_unlocked() - GPU SVM range pages valid unlocked
>   * @gpusvm: Pointer to the GPU SVM structure
> - * @range: Pointer to the GPU SVM range structure
> + * @svm_pages: Pointer to the GPU SVM pages structure
>   *
>   * This function determines if a GPU SVM range pages are valid. Expected be
>   * called without holding gpusvm->notifier_lock.
> -- 
> 2.43.0
> 

  reply	other threads:[~2026-02-26  3:06 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26  3:00 [PATCH 0/7] drm: fix some kernel-doc warnings Yujie Liu
2026-02-26  3:00 ` [PATCH 1/7] drm/gpusvm: fix kernel-doc warning for drm_gpusvm_pages_valid_unlocked() Yujie Liu
2026-02-26  3:06   ` Matthew Brost [this message]
2026-02-26  5:56     ` Yujie Liu
2026-02-26 11:39       ` Christian König
2026-02-27  2:08         ` Yujie Liu
2026-02-27  2:40   ` Claude review: " Claude Code Review Bot
2026-02-26  3:00 ` [PATCH 2/7] drm/scheduler: fix kernel-doc warning for drm_sched_job_done() Yujie Liu
2026-02-27  2:40   ` Claude review: " Claude Code Review Bot
2026-02-26  3:00 ` [PATCH 3/7] drm/gma500: fix kernel-doc warning for framebuffer init/create functions Yujie Liu
2026-02-27  2:40   ` Claude review: " Claude Code Review Bot
2026-02-26  3:00 ` [PATCH 4/7] drm/amdgpu: fix kernel-doc warning for amdgpu_ttm_alloc_mmio_remap_bo() Yujie Liu
2026-02-26 16:52   ` Alex Deucher
2026-02-27  2:40   ` Claude review: " Claude Code Review Bot
2026-02-26  3:00 ` [PATCH 5/7] drm/xe/pf: fix kernel-doc warning for SR-IOV VF restore function Yujie Liu
2026-02-26 11:36   ` Michal Wajdeczko
2026-02-27  2:40   ` Claude review: " Claude Code Review Bot
2026-02-26  3:00 ` [PATCH 6/7] drm/amd/pm: fix kernel-doc warning for smu_msg_v1_send_msg() Yujie Liu
2026-02-26 16:54   ` Alex Deucher
2026-02-27  2:40   ` Claude review: " Claude Code Review Bot
2026-02-26  3:00 ` [PATCH 7/7] drm/amd/ras: fix kernel-doc warning for ras_eeprom_append() Yujie Liu
2026-02-26 16:53   ` Alex Deucher
2026-02-27  2:40   ` Claude review: " Claude Code Review Bot
2026-02-27  2:40 ` Claude review: drm: fix some kernel-doc warnings Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZ+4sZoTzX4C/P2T@lstrano-desk.jf.intel.com \
    --to=matthew.brost@intel.com \
    --cc=Hawking.Zhang@amd.com \
    --cc=YiPeng.Chai@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=asad.kamal@amd.com \
    --cc=candice.li@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ganglxie@amd.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=kenneth.feng@amd.com \
    --cc=kevinyang.wang@amd.com \
    --cc=lijo.lazar@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luben.tuikov@amd.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthew.auld@intel.com \
    --cc=michal.wajdeczko@intel.com \
    --cc=michal.winiarski@intel.com \
    --cc=mripard@kernel.org \
    --cc=patrik.r.jakobsson@gmail.com \
    --cc=phasta@kernel.org \
    --cc=pierre-eric.pelloux-prayer@amd.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=simona@ffwll.ch \
    --cc=srinivasan.shanmugam@amd.com \
    --cc=sunil.khatri@amd.com \
    --cc=tao.zhou1@amd.com \
    --cc=thomas.hellstrom@linux.intel.com \
    --cc=tvrtko.ursulin@igalia.com \
    --cc=tzimmermann@suse.de \
    --cc=ville.syrjala@linux.intel.com \
    --cc=yujie.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox