public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Raag Jadav <raag.jadav@intel.com>
Cc: <intel-xe@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>, <airlied@gmail.com>,
	<simona@ffwll.ch>, <mripard@kernel.org>,
	<matthew.brost@intel.com>, <riana.tauro@intel.com>,
	<christian.koenig@amd.com>, <andrealmeid@igalia.com>
Subject: Re: [PATCH v1 1/3] drm/doc: Update documentation for 'none' recovery method
Date: Tue, 3 Mar 2026 10:32:17 -0500	[thread overview]
Message-ID: <aab_AevtalGw0fdO@intel.com> (raw)
In-Reply-To: <20260303110556.3577612-2-raag.jadav@intel.com>

On Tue, Mar 03, 2026 at 04:35:17PM +0530, Raag Jadav wrote:
> Expand 'none' recovery method for wedged event to include debug cases
> where driver wants to hint "no recovery" without resetting the device
> from driver context.
> 
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> ---
>  Documentation/gpu/drm-uapi.rst | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst
> index d98428a592f1..af20136108b7 100644
> --- a/Documentation/gpu/drm-uapi.rst
> +++ b/Documentation/gpu/drm-uapi.rst
> @@ -439,13 +439,11 @@ following expectations.
>      =============== ========================================
>  
>  The only exception to this is ``WEDGED=none``, which signifies that the device

I don't believe it is an 'exception'. The recovery method is none. It means 'do nothing
to recover'.

> -was temporarily 'wedged' at some point but was recovered from driver context
> -using device specific methods like reset. No explicit recovery is expected from
> -the consumer in this case, but it can still take additional steps like gathering
> -telemetry information (devcoredump, syslog). This is useful because the first
> -hang is usually the most critical one which can result in consequential hangs or
> -complete wedging.
> -
> +was temporarily 'wedged' at some point but no explicit recovery is expected

temporarily or definitive it doesn't matter. none still means 'do nothing to recover'.

> +from the consumer in this case. The consumer can still try to gather telemetry
> +information (devcoredump, syslog) for debug purpose in order to root cause the
> +hang. This is useful because the first hang is usually the most critical one
> +which can result in consequential hangs or complete wedging.

What about replacing this entire sentence to something like:

WEDGED=none indicates that no recovery action is expected from userspace—regardless of whether the driver already handled the condition—and consumers may optionally collect telemetry (e.g., devcoredump, syslog) for debugging.

(AI assisted text)

>  
>  Vendor Specific Recovery
>  ------------------------
> -- 
> 2.43.0
> 

  reply	other threads:[~2026-03-03 15:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03 11:05 [PATCH v1 0/3] Update 'none' recovery method for DRM wedged event Raag Jadav
2026-03-03 11:05 ` [PATCH v1 1/3] drm/doc: Update documentation for 'none' recovery method Raag Jadav
2026-03-03 15:32   ` Rodrigo Vivi [this message]
2026-03-03 21:31   ` Claude review: " Claude Code Review Bot
2026-03-03 11:05 ` [PATCH v1 2/3] drm: Update log " Raag Jadav
2026-03-03 15:33   ` Rodrigo Vivi
2026-03-03 21:31   ` Claude review: " Claude Code Review Bot
2026-03-03 11:05 ` [PATCH v1 3/3] drm/xe: Send 'none' recovery method for XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET Raag Jadav
2026-03-03 15:34   ` Rodrigo Vivi
2026-03-03 21:31   ` Claude review: " Claude Code Review Bot
2026-03-03 21:31 ` Claude review: Update 'none' recovery method for DRM wedged event Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aab_AevtalGw0fdO@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=airlied@gmail.com \
    --cc=andrealmeid@igalia.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=mripard@kernel.org \
    --cc=raag.jadav@intel.com \
    --cc=riana.tauro@intel.com \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox