From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66110112583A for ; Wed, 11 Mar 2026 14:49:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CEBED10E901; Wed, 11 Mar 2026 14:48:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="i+EAgAnQ"; dkim-atps=neutral Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4AD3B10E901 for ; Wed, 11 Mar 2026 14:48:58 +0000 (UTC) Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-439b94a19fdso9606731f8f.0 for ; Wed, 11 Mar 2026 07:48:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773240537; x=1773845337; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4lgNy5yMCcnmCSkcJzhlt2CENGm8tHrdHSldEAqpwXg=; b=i+EAgAnQVALbvRl9Qz0jtW1OwESm3jYeqwx8g12BS1rFTheXoFDsL0BCAbs3h+5VED a4PI79qnlvrH8olw+2DtXCP0cEp3vO8DrVT6uKPVwzbBha20rsdUexO0Lje28NRJuHnV f3cxv1WzB68Fv254caS0LX8Fs4igRp3z9xIz461HhL+HqPtHsYQM0ChbEmCucfs5Bnx2 bGzwn9SRznyH0oZ758teJbcfFVAohZJTqLVMbTvnECP3NOR4FgwvWH2p1GsLrwoD9sHn +c6+mRFZRUGOsdW1ThuRhjEtsh2VMHbfD8odDJxJ+tqrWgG7Sx5M1lVkfp0UXLBrs4O8 clyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773240537; x=1773845337; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4lgNy5yMCcnmCSkcJzhlt2CENGm8tHrdHSldEAqpwXg=; b=KpSDaUAccBRhmf7csphqLAE328qK6p5eWo8/xamF2PTV1/pfg7Nf67uadSCjbCfS6d kHu7pQp2+mK1lSI1eagVe138Nb9YaA6cHbJZW5hr/bX8XuJQv4y6oZ/puXuSujURuiSY EOCA5OcaDpr6yu8NG7R5eWhBiIMNT3fwlq2Z6fmIVr6YtHgyhsVSMgmsnobfXxcEXO4T YHfoAm7GYVpTHNNtHUdILfyRAa0d/PS/V6tvLd4ov9hvnGFQ4mG3m+cBQSmbziZL9F80 GaL4mPXr45l/dY9gHlodg5rT+nWVC6OT/mvQCXWCe2YztGAA+SpD+zM5c3jwyzqabnOU DU6A== X-Forwarded-Encrypted: i=1; AJvYcCUJlYmxeJDCyBwp/JAdsZCelep3UOCQuk/XK8guoxYipP6Q5VfWdIZxcCRqGPEw+aN/wEbjuylvFiM=@lists.freedesktop.org X-Gm-Message-State: AOJu0YxtCNkYt3CtXEZOD8iIxXw3B/vsha4XQd/1JT14ZReGdYTMxq3J D+4v5KA8pxgitchSyQyIriUmAXWCIVyEPNJIpG9e7Pt6QVammt0k0n2uJDWfeiV4QMU= X-Gm-Gg: ATEYQzwYJiFCMzOtHynKcjSz/1YgDJBv8q8Bae/gxkB4WBozx2X0MwTsyAkRd7UdzE3 oMpCBfC+sZ6ENiSwy7hUS8eppyzvB2vpRhefLIDyVaR8v/MjzG6ew+Z8GZLufO47+8FJjeZp+YN MK3uMpf4jkzWbY2J/d5utHHB9aEqTU/fwA8aHRa0Er7m1SmcL6rQPxakxrQqYLl5fDAUS+8iUFi Bw9Qe6BsmnBBtSWYUN9TEA992vVxFf4ITIfRAk1jBSl1Spegwh+YZ/o/SBEz3lF8sVAf9oXZtZz kdbWdaR3ESFFuWZhK+MEGyvIqiY4dE8+5ouyH9l/jLLwcCqQuWGA3oQ+uS9V1VFaJluVgxDexGE Qh13ky8TWLS4Lc/QSfwu1aTFUiHa/kv6tJa5ijwNXn+xyaZP0qTsKTp96dwlpkU5FXBHYfaCTNe Y8Wz00NoMy6cEMPAx3OEeTZm022gkJ X-Received: by 2002:a05:6000:288c:b0:439:cf1f:22a7 with SMTP id ffacd0b85a97d-439f81e295amr5406937f8f.6.1773240536680; Wed, 11 Mar 2026 07:48:56 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439f81a0307sm7214870f8f.11.2026.03.11.07.48.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 07:48:56 -0700 (PDT) Date: Wed, 11 Mar 2026 17:48:53 +0300 From: Dan Carpenter To: Anas Iqbal Cc: andy@kernel.org, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fbtft: fb_tinylcd: replace udelay() with usleep_range() Message-ID: References: <20260311142407.35403-1-mohd.abd.6602@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260311142407.35403-1-mohd.abd.6602@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Mar 11, 2026 at 02:24:07PM +0000, Anas Iqbal wrote: > Replace udelay() with usleep_range() for a 250 microsecond delay > as recommended by checkpatch.pl. usleep_range() avoids busy > waiting and allows the scheduler to schedule other tasks. > > Signed-off-by: Anas Iqbal > --- > drivers/staging/fbtft/fb_tinylcd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c > index 9469248f2c50..51e6493b050f 100644 > --- a/drivers/staging/fbtft/fb_tinylcd.c > +++ b/drivers/staging/fbtft/fb_tinylcd.c > @@ -38,10 +38,10 @@ static int init_display(struct fbtft_par *par) > write_reg(par, 0xE5, 0x00); > write_reg(par, 0xF0, 0x36, 0xA5, 0x53); > write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00, > - 0x00, 0x35, 0x33, 0x00, 0x00, 0x00); > + 0x00, 0x35, 0x33, 0x00, 0x00, 0x00); Don't do this. 1) It's unrelated. 2) The previous alignment was done deliberate to make it easier to read. Checkpatch is not perfect so don't always do what it says. > write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, 0x55); > write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE); > - udelay(250); > + usleep_range(250, 500); Do a search for init_display on lore https://lore.kernel.org/all/?q=init_display regards, dan carpenter