From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 780B5112584F for ; Wed, 11 Mar 2026 16:01:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C2C4910E9BC; Wed, 11 Mar 2026 16:01:36 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Gs7Fpa7w"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6738810E9BC for ; Wed, 11 Mar 2026 16:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773244895; x=1804780895; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/Q4nI9GnPBiJS9h+l3JqwUOCgULwdWzmb5FA/Ol9xy4=; b=Gs7Fpa7wTgX7QJtTmjQtxyrEWwTfW8UYrfjyfs7geI6y2M2jJ1LdfwxP /CmeyCbEbM6RAYhYQb75hqXLaPM75sN9aNkVeVt/C7vSPHk8WuRr7pxmr bcj/s7aESRpEtZnnHnrdaPMtqi3Tq6AfG3HUeyDkJgjTjSTPFsvss+0Oy 9iAbIn3mHAkbQ00MQQVj0tDnWzQq9Yu/YPS9BOr3mJaSIoZUVGQcvcW8K hMY8AuGkoanxn1iqS7HBAPtO8/yndM6N998yVsSd4DuL2WTMesvZAM3wU oVVxepJAfXYhBT6lZw4MVITRszExMGqvlq9v49eUQlpLLEPzwebrJ6gcb A==; X-CSE-ConnectionGUID: heL3kkY+SnaMomXThoBGsA== X-CSE-MsgGUID: 2CfOqq9lTWKxPrNe/Uwgnw== X-IronPort-AV: E=McAfee;i="6800,10657,11726"; a="96934100" X-IronPort-AV: E=Sophos;i="6.23,113,1770624000"; d="scan'208";a="96934100" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2026 09:01:35 -0700 X-CSE-ConnectionGUID: tcplHEL5RR6kBr0DO502Hw== X-CSE-MsgGUID: moA3q3/wTK2j/j7bnZT68g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,113,1770624000"; d="scan'208";a="258436055" Received: from amilburn-desk.amilburn-desk (HELO localhost) ([10.245.244.178]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2026 09:01:33 -0700 Date: Wed, 11 Mar 2026 18:01:30 +0200 From: Andy Shevchenko To: Anas Iqbal Cc: andy@kernel.org, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fbtft: fb_tinylcd: replace udelay() with usleep_range() Message-ID: References: <20260311142407.35403-1-mohd.abd.6602@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260311142407.35403-1-mohd.abd.6602@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Mar 11, 2026 at 02:24:07PM +0000, Anas Iqbal wrote: > Replace udelay() with usleep_range() for a 250 microsecond delay > as recommended by checkpatch.pl. usleep_range() avoids busy > waiting and allows the scheduler to schedule other tasks. Now, read README here: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/staging/fbtft/README and act accordingly. If you have been mentored on this, show the above link to your mentors. ... > write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00, > - 0x00, 0x35, 0x33, 0x00, 0x00, 0x00); > + 0x00, 0x35, 0x33, 0x00, 0x00, 0x00); Use the common sense here. This change won't be accepted. ... > - udelay(250); > + usleep_range(250, 500); No. -- With Best Regards, Andy Shevchenko