From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47A1C1067020 for ; Thu, 12 Mar 2026 13:57:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8E73610EA0F; Thu, 12 Mar 2026 13:57:04 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="QjNpIV7o"; dkim-atps=neutral Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 509B610EA0F for ; Thu, 12 Mar 2026 13:57:03 +0000 (UTC) Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-439b7a87fb5so851326f8f.3 for ; Thu, 12 Mar 2026 06:57:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773323822; x=1773928622; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ktVDN7qYq0WOHCD00szxOqNnI17BzE5korotOZpq77s=; b=QjNpIV7oHTyJr0T+xqNR7GRyku+NYbHIBFTC+mj/AuTXy+B+acV7qe1vO1G6BYVDAd jtFxknTl+SjHPBOv9DYBbevMlU1qVk6YMHqdDekrNe/ypBhWZBsdzof4UFs/Md4pHaD+ ICitPxjCLXNratn5Ystfba9fElEWSxhz7ATLNsnoJ1ugpLgFYmV4455VLUP+xeQj2dBx 1SX9AXGSUg22BygQLQ1bxSZjgBxiYZOpyGnsE0BrMtjfnOvYahOAyjHRb1PzSFHgDDjA vwNtRIq7pN8U9Xgp7uZW4LIZxoVgYM1TWSds46lWpUcJG8/ksHt7is5K+uVeFxZKlLDj xtUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773323822; x=1773928622; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ktVDN7qYq0WOHCD00szxOqNnI17BzE5korotOZpq77s=; b=HGzQv0oVCVQmcY4GvcYC4gs1t1OjZ3S25M5GbjCcoCXfhm1FVOQ8zOm5Q7nMRCNJ1N zkqgrTPgJgVv1IImwnktAQR4EI6TIz8M8yrwn0woFyZQ3K0JEY6DxNGgWCH1Sq+7oV6d 7xzPWmuGm0wo02qMPznWM2nHece7jF9gEf7OUYP35l3f+P/RYRyHnbFRRGMSY4W63Bi2 B7f8NZQ3GXDWLleaKl3U3POscqpfzUZ9568jeDbu1ptqEuDuz1GWXKgBmbWvv77Pfgbu 0D1NXEEjcdeXNIjB/Qr1ra2+MyaBhYOYpXQebC+dEsGTpMABhtN3ua9nGVF8roUzy7PU Q+Ug== X-Forwarded-Encrypted: i=1; AJvYcCXKv+KL+JWuldrZWpnQNIW1pGxb/9mIeT3OQgsqNmq7IrTKZe7jhM2KCTyLLaZ9b6JEElLWGbge3OA=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzVkXevp90oPP3+2cYsAfMwpVZrYz6KWsEAnfYnhXwdj1YtNY3j yoFnzZ2uM2L3qTtiVti3M5tcR3FuhLNeq5rxR/WfNAzuvaO9SBRkkYd2ke2YRd4s1SM= X-Gm-Gg: ATEYQzzC0WKINOZNgO6OhzaQOC8pMvLkYvU1xE18epdFOM6N7vOVsNCktOA4AiLS+BN RZ+OM/J9gWq9oFfgGsIgSXnT2oUuL5dkB2ZzPtfOKi0JiE0eLoWeBmIp76uD+r0HRv4ipOSiZb3 pVcHuS1Ijgdq9k/r0mywkEkpXwoz1IwOMdK0Kjky1ybRZhZ4/9leT90JWIhKsH4kF3hn87TU8ls iouWvZYBtJGVqWEnl/j45upXBLnNGqelGiRbJD+wKzT78wVxOmyt44LQxFJbayDOUliPmb52lUU U+fukIfnPBGXe9u+GJPcVlMKC0hb6dVYFDQwr3CgzuOZk3iQKSBqrP4ekmk1bFFRcQizhNUquFD liISrXmQyhsbU0KIiysFBJC8uoGFlZi7AQ5kfgaSoVl4vQFKKUBJzQS/i+BcF6lmijhjSwfMXfZ hs/D9hi+8chirYBi08m80m25Jxg8WS X-Received: by 2002:a05:600c:458e:b0:477:7ab8:aba with SMTP id 5b1f17b1804b1-4854b0ac93fmr97513165e9.1.1773323821702; Thu, 12 Mar 2026 06:57:01 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe226473sm7606686f8f.32.2026.03.12.06.57.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:57:01 -0700 (PDT) Date: Thu, 12 Mar 2026 16:56:58 +0300 From: Dan Carpenter To: Zile Xiong Cc: andy@kernel.org, gregkh@linuxfoundation.org, deller@gmx.de, abdun.nihaal@gmail.com, chintanlike@gmail.com, niejianglei2021@163.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fbtft: avoid empty macro argument in define_fbtft_write_reg Message-ID: References: <20260312111807.96789-1-xiongzile99@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260312111807.96789-1-xiongzile99@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Mar 12, 2026 at 07:18:07PM +0800, Zile Xiong wrote: > Replace the empty modifier argument with a simple identity macro. > This fixes the error reported by scripts/checkpatch.pl while keeping > the original semantics unchanged. > > The generated code is equivalent and builds successfully. > > Signed-off-by: Zile Xiong > --- > drivers/staging/fbtft/fbtft-bus.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c > index 30e436ff19e4..380dd374a566 100644 > --- a/drivers/staging/fbtft/fbtft-bus.c > +++ b/drivers/staging/fbtft/fbtft-bus.c > @@ -61,10 +61,10 @@ out: \ > va_end(args); \ > } \ > EXPORT_SYMBOL(func); > - > -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, ) > +#define fbtft_identity(x) (x) Someone sent this exact same patch before. Same name and everything. https://lore.kernel.org/all/aYECoy7Apjwgzr9r@stanley.mountain/ A better sollution is to learn to just ignore checkpatch when it is wrong. My previous email was longer. regards, dan carpenter